From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#2388: 23.0.90; wrong-type-argument in vc-dir Date: Wed, 11 Mar 2009 17:48:22 -0700 (PDT) Message-ID: <200903120048.n2C0mMkj009754@godzilla.ics.uci.edu> References: <87zlgi1p9f.fsf@tnei.co.uk> <200902201612.n1KGCFvg006453@rodan.ics.uci.edu> <49A2B431.6030302@tnei.co.uk> <18851.37147.636647.611430@kahikatea.snap.net.nz> <18862.21659.153250.510667@snap.net.nz> <49B6361C.8050702@tnei.co.uk> <200903102111.n2ALB1OM029132@godzilla.ics.uci.edu> <49B779ED.5000000@tnei.co.uk> Reply-To: Dan Nicolaescu , 2388@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236819888 6806 80.91.229.12 (12 Mar 2009 01:04:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Mar 2009 01:04:48 +0000 (UTC) Cc: 2388@emacsbugs.donarmstrong.com To: robert marshall Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 12 02:06:02 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhZMI-00015T-VA for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Mar 2009 02:05:51 +0100 Original-Received: from localhost ([127.0.0.1]:38942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhZKw-0002To-G3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Mar 2009 21:03:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhZKr-0002T7-HI for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 21:03:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhZKr-0002Sa-2m for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 21:03:45 -0400 Original-Received: from [199.232.76.173] (port=44809 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhZKq-0002SQ-Eg for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 21:03:44 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:60215) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LhZKp-00033q-Mk for bug-gnu-emacs@gnu.org; Wed, 11 Mar 2009 21:03:44 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2C13fp6014434; Wed, 11 Mar 2009 18:03:41 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2C0t3GE012069; Wed, 11 Mar 2009 17:55:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , owner@emacsbugs.donarmstrong.com Resent-Date: Thu, 12 Mar 2009 00:55:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2388 X-Emacs-PR-Package: emacs,vc-dir X-Emacs-PR-Keywords: Original-Received: via spool by 2388-submit@emacsbugs.donarmstrong.com id=B2388.123681892210731 (code B ref 2388); Thu, 12 Mar 2009 00:55:03 +0000 Original-Received: (at 2388) by emacsbugs.donarmstrong.com; 12 Mar 2009 00:48:42 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2C0mdHJ010725 for <2388@emacsbugs.donarmstrong.com>; Wed, 11 Mar 2009 17:48:40 -0700 Original-Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n2C0mMqc011475; Wed, 11 Mar 2009 17:48:22 -0700 (PDT) Original-Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n2C0mMkj009754; Wed, 11 Mar 2009 17:48:22 -0700 (PDT) In-Reply-To: <49B779ED.5000000@tnei.co.uk> (robert marshall's message of "Wed, 11 Mar 2009 08:44:29 +0000") Original-Lines: 77 X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n2C0mMqc011475 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 11 Mar 2009 21:03:45 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26252 Archived-At: robert marshall writes: > Dan Nicolaescu wrote: > > robert marshall writes: > > > > > Nick Roberts wrote: > > > > Nick Roberts writes: > > > > > > > I can't reproduce this. > > > > > > > Can you please post step by step recipe of how you get this, starting > > > > > > > with emacs -Q. > > > The output of > > > svn -u status > > > > > > > in that directory might be helpful too. > > > > > > > > > I can't reproduce this either now :-( > > > > > > I have seen this sometimes when files have needed > > > > merging/updating. I don't > > > > > think it happened earlier because with SVN emacs didn't consult the remote > > > > > repository by default: > > > > > > > > I still see this. Here's a recent backtrace: > > > > > > > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > > > > ewoc-data(nil) > > .. > > > > vc-dir-update((("." needs-update) ("mydir" needs-update) > > > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ... > > > > > > > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil. > > > > > > > > > I'm seeing this, today, the status gives me > > > > svn -u status > > > * 7243 tests/compare.py > > > * 7243 tests/harm.py > > > * 7243 tests/setup-win.py > > > * 7243 ipsa.i > > > * 7243 Makefile > > > * 7243 IscNetComponent.cpp > > > * 7243 IscNetComparator.h > > > * 7243 IpsaComparator.cpp > > > * 7243 IscNetComponent.h > > > * 7243 IscNetComparator.cpp > > > * IscCompareData.h > > > ? ipsa_wrap.cpp > > > M * 7243 IscInterface.cpp > > > ? ipsa.py > > > * IscCompareData.cpp > > > * 7243 Scripting.vcproj > > > * 7243 . > > ^^^^^^^^^^^^^^^^^^^^^^^^ This might be the cause of the > > problem. Can you please try thing > > patch: > > > > > > Index: vc-svn.el > > =================================================================== > > RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v > > retrieving revision 1.112 > > diff -u -3 -p -u -p -r1.112 vc-svn.el > > --- vc-svn.el 10 Feb 2009 05:59:14 -0000 1.112 > > +++ vc-svn.el 10 Mar 2009 20:49:23 -0000 > > @@ -176,7 +176,7 @@ want to force an empty list of arguments > > ;; FIXME are there other possible combinations? > > (cond ((eq state 'edited) (setq state 'needs-merge)) > > ((not state) (setq state 'needs-update)))) > > - (when state > > + (when (and state (not (string= "." filename))) > > (setq result (cons (list filename state) result))))) > > (funcall callback result))) > > > Thanks for this, I've installed it and will persuade my colleagues to > do a few checkins :-) > Not sure why svn should list '.' as needing an update. Unfortunately > my svn is now > up to date so I can't, currently, replicate this issue. I would say it would be better to not install the above patch. You can install it whenever you hit the problem again and see if it help. In case it doesn't saving the tree that generates the problem would help testing a different fix.