From: Alexander Miller <alexanderm@web.de>
To: rudalics@gmx.at
Cc: 45620@debbugs.gnu.org
Subject: bug#45620: 28.0.50; Child frames should have their own border width and colour
Date: Mon, 4 Jan 2021 14:38:37 +0100 [thread overview]
Message-ID: <f4d634a0-9b66-cef5-96e1-dffbd1c29ff6@web.de> (raw)
In-Reply-To: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de>
> Isn't the situation even worse than how you describe it here? When I
> customize 'internal-border' face, that affects all frames, including
> those for which I have set it already via 'set-face-background'. Which
> means that whatever a package does to set that face for a specific
> (child) frame, that setting is undone by a later customization. IIUC
> the discussion you refer to above arrived at the same conclusion.
What customisations are you referring to? I cannot think of any
scenario, other than changing and reloading your theme, that could
change the settings of already present child frames.
> If I'm not mistaken we use that face for our tooltip frames too which
> means one more conflict.
Partially. On my system the internal-border colour and width only
applied to the top and left sides of the tooltip frame.
> "clearly" is clearly too strong here. Ultimately, the package must have
> the choice and its choice should prevail (it currently doesn't).
Packages do have the choice, they just have to make sure to override the
frame-local faces whenever they show something. The problem, as I see
it, is that they *have to* create a face to override the local
internal-border, instead of just having the option to do it, because
themes cannot offer a general setting, like an easily visible dark
border on a bright foreground, because they run into the frame margin
colour conflict like modus did in the linked issue. So if a package
doesn't overwrite the local internal-border your default look-and-feel
is a badly visible same-colour-on-same-colour popup.
> So what should we do? Provide a separate 'child-frame-internal-border'
> face and then probably also a 'tooltip-internal-border-face'?
That would be perfectly good enough for themes like modus, yes.
next prev parent reply other threads:[~2021-01-04 13:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 13:24 bug#45620: 28.0.50; Child frames should have their own border width and colour Alexander Miller
2021-01-03 16:15 ` martin rudalics
2021-01-04 13:38 ` Alexander Miller [this message]
2021-01-04 16:22 ` martin rudalics
2021-01-04 17:48 ` Alexander Miller
2021-01-04 18:54 ` martin rudalics
2021-01-05 12:50 ` Alexander Miller
2021-01-05 15:33 ` martin rudalics
2021-01-05 15:34 ` martin rudalics
2021-01-06 11:32 ` Arthur Miller
2021-01-06 13:36 ` martin rudalics
2021-01-06 15:01 ` Arthur Miller
2021-01-05 16:26 ` Eli Zaretskii
2021-01-06 16:32 ` Alexander Miller
2021-01-06 18:48 ` martin rudalics
2021-01-13 9:17 ` Alexander Miller
2021-01-13 18:07 ` martin rudalics
2021-01-25 12:08 ` Alexander Miller
2021-01-25 19:05 ` martin rudalics
2021-01-26 15:59 ` martin rudalics
2021-01-27 20:49 ` Alan Third
2021-01-28 9:42 ` martin rudalics
2021-01-28 16:35 ` Alan Third
2021-01-29 7:51 ` martin rudalics
2021-01-27 20:44 ` Alexander Miller
2021-01-28 3:33 ` Eli Zaretskii
2021-01-28 7:06 ` Alexander Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d634a0-9b66-cef5-96e1-dffbd1c29ff6@web.de \
--to=alexanderm@web.de \
--cc=45620@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).