From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alexander Miller Newsgroups: gmane.emacs.bugs Subject: bug#45620: 28.0.50; Child frames should have their own border width and colour Date: Mon, 4 Jan 2021 14:38:37 +0100 Message-ID: References: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 Cc: 45620@debbugs.gnu.org To: rudalics@gmx.at Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 04 14:33:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwPyw-0009z9-Oe for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jan 2021 14:33:10 +0100 Original-Received: from localhost ([::1]:34724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwPyv-00060S-M7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jan 2021 08:33:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwPyo-000604-6y for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 08:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwPyn-0005rS-Vl for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 08:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwPyn-00064O-S2 for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 08:33:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <30630458-2ef4-7da9-ea28-cdb12052dba2@web.de> Resent-From: Alexander Miller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 13:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45620 X-GNU-PR-Package: emacs Original-Received: via spool by 45620-submit@debbugs.gnu.org id=B45620.160976716623309 (code B ref 45620); Mon, 04 Jan 2021 13:33:01 +0000 Original-Received: (at 45620) by debbugs.gnu.org; 4 Jan 2021 13:32:46 +0000 Original-Received: from localhost ([127.0.0.1]:58121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPyY-00063s-JW for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:32:46 -0500 Original-Received: from mout.web.de ([212.227.15.4]:40777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPyX-00063f-H4 for 45620@debbugs.gnu.org; Mon, 04 Jan 2021 08:32:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609767159; bh=LuZS3/QTR95Yjm9JJ69w1DH3AddsYhI30HefdcBk/aM=; h=X-UI-Sender-Class:To:Cc:Subject:From:Date; b=N7xZxdySOoZCYXK87IGo9zbw5OPldn7XlfMixlTU5x/viBwzOyQqdZZlfLWiMOUkY /Z1ttjTJfH3iQjljQIuAn+nROsdmdEodn5aJNZjhT0+CMw9A4FZ1zdTFncwb43dxvI DSGcBKzsFhuDtBjRJx/CQ9/NDVvEOAh2I7yPveAI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from [192.168.2.104] ([217.241.231.57]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MgOQQ-1kb1jV0YBa-00NiYp; Mon, 04 Jan 2021 14:32:39 +0100 Content-Language: en-US X-Provags-ID: V03:K1:q88wDpFyBAdLuO6DZDF3Nssk+wdqbwMOF0KuonQ0Vgu1zhfauz1 r549hndy6bdphMKZ6fM5E/ateyea+klGE4bC2vkm5MHOJkIKYGKFpjjCNnJ5wHtQW68PG8A 6lOXsaGlW0hBYd3T63vt0AtzuiapNCNNWT5DQGyNkGTSak7kSh5Qri1McOLIjeEz8WX5XGp IxlgGAUrYAxi/JvJ9PnTg== X-UI-Out-Filterresults: notjunk:1;V03:K0:rvkTNeUBjDA=:530zLSHERdI6bcpDuJ8aq6 5ldQKh7DU12Ya44axQFSfNAIzMZPi35DE/C5bdjMuHUv+IJL/m0/Q0Hk+N3qjYHG3d/tSQfU3 o04kzqnw/0NY5NQij0J4Q6xk2EMxXwqkMO/0fehUdfxn79iZJvoOC8rg9rop5XqCAO0nxcsfQ gqKr28oCsBtDe5Nr3CSUAa/Da+UuZ7yfZwdxOS7UkbiineyPgesi01OjWkbYEsogyNnAZ18gQ 6MHADxyGntzz/CVDtfQfJWzOUP9opVlT7hrgI9rQJguKfpR+g0WW3L5z85AY9+klBFCQL02/S 2YUSlMraLUBsqDmLYGCxd/nPqXBouxOkQ+tNHhDeobSf0I+h+tfMBZJxYXb7A04WG11uGKtPu lE6gkzcdfIG84zSxgovjY7o0crRXO0TWUSb3+KoYD8fBe0/K7MjSVH3BGpgvNePco0r3jwp6R jZA+bfkjlCMJPdIYLnDxoitmRSljH+TT/WDwmDZedB756WPWRo1KPnXEDKgNVl33Ub2Dbz9Ev 2SoOmtIsiwjBeKMOTHgT5XavT5WP3VQgvWcDgqCc7BwEFriMy5lqbocAPfSX/r7Lt30IrgXV6 ygBQfy5DuGHKip8MRLOBPJpHXjwEH2fDqckcP5ueWZxkLRDhGut1bPtmkCYAZSXAR+nET4SOs M/8Hm2jWSMSP5Bsw9LQHY9feHeqT2xwaTW1RjPJy+Z7tisGSC062tF2uh3Oyck1Cb1FejojQ1 GV0eRzkG+TweEl0RUXORwXBh0QP9xfZ1Z4Ikw9mc3TOigLQ0HZT/rwJqtqtyYOytWaFBS0PL X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197307 Archived-At: > Isn't the situation even worse than how you describe it here? When I > customize 'internal-border' face, that affects all frames, including > those for which I have set it already via 'set-face-background'. Which > means that whatever a package does to set that face for a specific > (child) frame, that setting is undone by a later customization. IIUC > the discussion you refer to above arrived at the same conclusion. What customisations are you referring to? I cannot think of any scenario, other than changing and reloading your theme, that could change the settings of already present child frames. > If I'm not mistaken we use that face for our tooltip frames too which > means one more conflict. Partially. On my system the internal-border colour and width only applied to the top and left sides of the tooltip frame. > "clearly" is clearly too strong here. Ultimately, the package must have > the choice and its choice should prevail (it currently doesn't). Packages do have the choice, they just have to make sure to override the frame-local faces whenever they show something. The problem, as I see it, is that they *have to* create a face to override the local internal-border, instead of just having the option to do it, because themes cannot offer a general setting, like an easily visible dark border on a bright foreground, because they run into the frame margin colour conflict like modus did in the linked issue. So if a package doesn't overwrite the local internal-border your default look-and-feel is a badly visible same-colour-on-same-colour popup. > So what should we do? Provide a separate 'child-frame-internal-border' > face and then probably also a 'tooltip-internal-border-face'? That would be perfectly good enough for themes like modus, yes.