From: martin rudalics <rudalics@gmx.at>
To: Alexander Miller <alexanderm@web.de>
Cc: 45620@debbugs.gnu.org, tumashu@163.com
Subject: bug#45620: 28.0.50; Child frames should have their own border width and colour
Date: Tue, 5 Jan 2021 16:33:05 +0100 [thread overview]
Message-ID: <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> (raw)
In-Reply-To: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de>
> To be honest I've don't really like C as a language, and learning it
> would not do anything professionally for me either. So I'm jumping into
> this strictly for the sake of improving Emacs.
Then please jump into this as often as you want.
> x, ns and w32 all used the same code, so I changed them all to look like
> this now.
OK. I think a main reason that we usually do not factor out code in
these is that only one of them gets compiled in anyway - so we just save
an extra call.
> >> - Currently the actual width of the border is still controlled by the
> >> `internal-border-width` parameter for both frame types. Should I try to
> >> do something about that as well? If yes, what's my entry point?
> >
> > Add a 'child-frame-border-width' parameter. But in this case I would
> > propose to proceed as follows:
> >
> > - If for a frame the 'child-frame-border-width' was explicitly set, use
> > it.
> >
> > - If it was not set, use the 'internal-border-width' parameter.
>
> That's done now too, at least for X. I'll attach patches of my first
> working drafts for both changes. Let me know if I'm on the right path so
> far.
You're already at the end of it. Please document the changes in the
Elisp manual and announce them as (probably incompatible) changes in
NEWS.
> >> - I think I'll need to sign the FSF copyright assignment, unless the
> >> limit is higher than the 15 lines I am remembering.
> >
> > I think so too.
> >
>
> Ok, what do I do?
Eli, can you send Arthur the forms please?
Thanks, martin
next prev parent reply other threads:[~2021-01-05 15:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 13:24 bug#45620: 28.0.50; Child frames should have their own border width and colour Alexander Miller
2021-01-03 16:15 ` martin rudalics
2021-01-04 13:38 ` Alexander Miller
2021-01-04 16:22 ` martin rudalics
2021-01-04 17:48 ` Alexander Miller
2021-01-04 18:54 ` martin rudalics
2021-01-05 12:50 ` Alexander Miller
2021-01-05 15:33 ` martin rudalics [this message]
2021-01-05 15:34 ` martin rudalics
2021-01-06 11:32 ` Arthur Miller
2021-01-06 13:36 ` martin rudalics
2021-01-06 15:01 ` Arthur Miller
2021-01-05 16:26 ` Eli Zaretskii
2021-01-06 16:32 ` Alexander Miller
2021-01-06 18:48 ` martin rudalics
2021-01-13 9:17 ` Alexander Miller
2021-01-13 18:07 ` martin rudalics
2021-01-25 12:08 ` Alexander Miller
2021-01-25 19:05 ` martin rudalics
2021-01-26 15:59 ` martin rudalics
2021-01-27 20:49 ` Alan Third
2021-01-28 9:42 ` martin rudalics
2021-01-28 16:35 ` Alan Third
2021-01-29 7:51 ` martin rudalics
2021-01-27 20:44 ` Alexander Miller
2021-01-28 3:33 ` Eli Zaretskii
2021-01-28 7:06 ` Alexander Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at \
--to=rudalics@gmx.at \
--cc=45620@debbugs.gnu.org \
--cc=alexanderm@web.de \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).