From: Dmitry Gutov <dmitry@gutov.dev>
To: Yuan Fu <casouri@gmail.com>
Cc: "Theodor Thornhill" <theo@thornhill.no>,
66988@debbugs.gnu.org, "Loïc Lemaître" <loic.lemaitre@gmail.com>
Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode
Date: Sat, 11 Nov 2023 12:49:21 +0200 [thread overview]
Message-ID: <e88344bd-0acc-a9a1-b91f-bd4339282824@gutov.dev> (raw)
In-Reply-To: <BFD5D5A3-8E6C-463F-AE8A-CE12256D16D0@gmail.com>
On 11/11/2023 04:41, Yuan Fu wrote:
> I regret not doing this by default for treesit-indent-rules and traverse functions. Now it’s hard to change without creating confusion and breaking backward compatibility. I wonder if there are good way to smoothly transition to match full names by default…
>
> Treesit-thing-settings can be changed to match full names, but only if we can change treesit-indent-rules and friends too. Otherwise it would be too confusing.
It's my understanding that the current implementation, when it doesn't
use a full match, is a potential bug in every single instance.
Perhaps you have an example of when partial match is intended and
beneficial? If so, we can just go through all other regexps and wrap
them in \` and \'. And should.
next prev parent reply other threads:[~2023-11-11 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 14:56 bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Loïc Lemaître
2023-11-10 1:41 ` Dmitry Gutov
2023-11-10 7:37 ` Juri Linkov
2023-11-11 2:41 ` Yuan Fu
2023-11-11 7:35 ` Eli Zaretskii
2023-11-15 6:28 ` Yuan Fu
2023-11-15 12:19 ` Eli Zaretskii
2023-11-18 18:57 ` Yuan Fu
2023-11-19 5:48 ` Eli Zaretskii
2023-11-19 6:19 ` Yuan Fu
2023-11-11 10:49 ` Dmitry Gutov [this message]
2023-11-15 6:32 ` Yuan Fu
2023-11-11 15:43 ` Loïc Lemaître
2023-11-11 23:40 ` Dmitry Gutov
2023-11-12 12:10 ` Loïc Lemaître
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e88344bd-0acc-a9a1-b91f-bd4339282824@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66988@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=loic.lemaitre@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).