From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Date: Sat, 11 Nov 2023 12:49:21 +0200 Message-ID: References: <9cf7d7d0-33a3-4c07-bd66-bc4c59bdfefb@gmail.com> <39b0057b-ac0c-8271-0fe2-f4deef7ae8d3@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Theodor Thornhill , 66988@debbugs.gnu.org, =?UTF-8?Q?Lo=C3=AFc_?= =?UTF-8?Q?Lema=C3=AEtre?= To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 11 11:50:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1lZV-000AE2-JE for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Nov 2023 11:50:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1lZJ-0005Yt-GH; Sat, 11 Nov 2023 05:50:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1lZG-0005Yj-BK for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 05:50:23 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1lZG-0000gY-3c for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 05:50:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1lZt-00059g-KK for bug-gnu-emacs@gnu.org; Sat, 11 Nov 2023 05:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Nov 2023 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66988 X-GNU-PR-Package: emacs Original-Received: via spool by 66988-submit@debbugs.gnu.org id=B66988.169969981719755 (code B ref 66988); Sat, 11 Nov 2023 10:51:01 +0000 Original-Received: (at 66988) by debbugs.gnu.org; 11 Nov 2023 10:50:17 +0000 Original-Received: from localhost ([127.0.0.1]:52137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1lZA-00058Z-V1 for submit@debbugs.gnu.org; Sat, 11 Nov 2023 05:50:17 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1lZ6-00058I-9M for 66988@debbugs.gnu.org; Sat, 11 Nov 2023 05:50:15 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2F02B3200957; Sat, 11 Nov 2023 05:49:25 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 11 Nov 2023 05:49:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1699699764; x=1699786164; bh=ovlbu77Ag5OJV/fSb5xMAq3/K57M0D/Lxvy K1xkdshg=; b=ihK72ODXCwLgxFG1oE3cNWv4nNx+gdJ3g3J/9JuJ9qjzJjqphMB WLHF7wVsGwWaByb0bV6ryh97buhyxHc7FluLAqiojZ1JCT1VstzgQ3xw1T6/wM8O j+E1TNhJhJXUvTfp5gbIwLaw/+YKnnuXEbanqoPACeHkbltv4+iK9XUHpt7GM5n2 TKphLBOCmKrdYvrOFmtDRGp6M+Faeszz2D1N6o9SqvQPbf6tysL5PWyWnPK4fci4 Pq11oTFd5AufPEvMEAIE05t1LZPVyyU7EqV5y4BX8NRprJ88WDB7LxwPSyTzofvN 03l9KrisROr6H+mpVPWYH5CfTH9Pp7QxZ5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699699764; x=1699786164; bh=ovlbu77Ag5OJV/fSb5xMAq3/K57M0D/Lxvy K1xkdshg=; b=gCPyMIYcFGvtvB1cMnENXgY10N6+DBfbYQ6ISxz+a7LreT4NFIK OgeqVbna446QkyI8ClRoeBfBBN4jvuEsIKexuCiS6SxakggCKrjJkBrZCrcWY5Eq R9AL8Sh+c4XrU2EFCConPqluKouidG1l0vfGMYTUweehnD50zs5HnKfN1PADIbA7 nC7JyP3kw1R7t/A1VTC3nPDqgdBa1PtEVnhPGPVJaWfM9UvoJ/2Gw6tFtadGlOr0 NI0LB9xz8xa/S5QQ/z/r/vz4HTcrReXVgT1I6fkGfB19Ogv5SOmbu6KXhCHKcvqX ZeiECQvIStA1tmAzqWH6UHPQpTswFwmeAZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvhedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Nov 2023 05:49:22 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274154 Archived-At: On 11/11/2023 04:41, Yuan Fu wrote: > I regret not doing this by default for treesit-indent-rules and traverse functions. Now it’s hard to change without creating confusion and breaking backward compatibility. I wonder if there are good way to smoothly transition to match full names by default… > > Treesit-thing-settings can be changed to match full names, but only if we can change treesit-indent-rules and friends too. Otherwise it would be too confusing. It's my understanding that the current implementation, when it doesn't use a full match, is a potential bug in every single instance. Perhaps you have an example of when partial match is intended and beneficial? If so, we can just go through all other regexps and wrap them in \` and \'. And should.