From: "Loïc Lemaître" <loic.lemaitre@gmail.com>
To: Dmitry Gutov <dmitry@gutov.dev>,
66988@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode
Date: Sun, 12 Nov 2023 13:10:14 +0100 [thread overview]
Message-ID: <b43386de-1444-458f-8203-c914ab51e9a8@gmail.com> (raw)
In-Reply-To: <a26ca9d5-54de-0079-6f68-5d13f2a9d8a0@gutov.dev>
Sorry for my example that is actually not valid JSX...
Yours demontrates better the remaining issue.
Thanks
Loïc
Le 12/11/2023 à 00:40, Dmitry Gutov a écrit :
> On 11/11/2023 17:43, Loïc Lemaître wrote:
>> Thanks for the patch ! It fixes the bug.
>> But unfortunatly, there is another similar bug in
>> /treesit-forward-sexp/, that you can reproduce with that example:
>> ({(<A></A>)});
>
> The problem in this case is that the code doesn't parse (one of the
> nodes in the parse tree is ERROR). Removing either the curlies, or the
> outer parens pair makes the code valid and the behavior
> correspondingly better.
>
> Although for treesit-forward-sexp to jump between curlies in
>
> {(<A></A>)};
>
> we'll also need to add "statement_block" to js--treesit-sexp-nodes.
prev parent reply other threads:[~2023-11-12 12:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 14:56 bug#66988: 30.0.50; treesit-forward-sexp not working properly in js-ts-mode and tsx-ts-mode Loïc Lemaître
2023-11-10 1:41 ` Dmitry Gutov
2023-11-10 7:37 ` Juri Linkov
2023-11-11 2:41 ` Yuan Fu
2023-11-11 7:35 ` Eli Zaretskii
2023-11-15 6:28 ` Yuan Fu
2023-11-15 12:19 ` Eli Zaretskii
2023-11-18 18:57 ` Yuan Fu
2023-11-19 5:48 ` Eli Zaretskii
2023-11-19 6:19 ` Yuan Fu
2023-11-11 10:49 ` Dmitry Gutov
2023-11-15 6:32 ` Yuan Fu
2023-11-11 15:43 ` Loïc Lemaître
2023-11-11 23:40 ` Dmitry Gutov
2023-11-12 12:10 ` Loïc Lemaître [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b43386de-1444-458f-8203-c914ab51e9a8@gmail.com \
--to=loic.lemaitre@gmail.com \
--cc=66988@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dmitry@gutov.dev \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).