From: montag451 via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 60083@debbugs.gnu.org
Subject: bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host
Date: Mon, 19 Dec 2022 12:29:27 +0100 [thread overview]
Message-ID: <df6376c51d477868c76904b02f5693ad9569d721.camel@laposte.net> (raw)
In-Reply-To: <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
Le dimanche 18 décembre 2022 à 12:04 -0800, Jim Porter a écrit :
> On 12/18/2022 2:34 AM, Eli Zaretskii wrote:
> > > Date: Thu, 15 Dec 2022 00:46:50 +0100
> > > From: montag451 via "Bug reports for GNU Emacs,
> > > the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> > >
> > > While testing the new eshell module 'eshell-elecslash' I found a
> > > bug
> > > when the default-directory is the root of a remote host. To
> > > reproduce
> > > the problem type the following in a eshell buffer (replacing
> > > "method"
> > > and "host" by appropriate values):
> > >
> > > $ cd /method:host:/
> > > $ cd / <--- here the "/" should be replaced by "/method:host:/"
> > > but
> > > instead nothing happen
> > >
> > > I've attached a patch to this email which fixes this issue.
> >
> > Jim, are you looking into this issue?
>
> Thanks. I missed the original message. The patch looks good to me,
> although it compiles with the following warning:
>
> In eshell-electric-forward-slash:
> ../../lisp/eshell/em-elecslash.el:98:18: Warning: Unused lexical
> variable `localname'
>
> Looking through the code, I think we can just remove that variable.
>
> Since this is a small change, and fixes a corner case in a new
> feature,
> I think it would make sense to go on the release branch, though I'll
> defer to you on this, Eli. The fact that the new code (with the
> removal
> of 'localname') is a bit simpler helps too.
Thanks for looking into this. I've attached to this email a new patch
which fixes the compilation warning.
[-- Attachment #2: eshell-elecslash.patch --]
[-- Type: text/x-patch, Size: 1571 bytes --]
diff --git a/lisp/eshell/em-elecslash.el b/lisp/eshell/em-elecslash.el
index 091acb9a86..0ce3a4cc96 100644
--- a/lisp/eshell/em-elecslash.el
+++ b/lisp/eshell/em-elecslash.el
@@ -74,8 +74,9 @@ eshell-electric-forward-slash
(command (save-excursion
(eshell-bol)
(skip-syntax-forward " ")
- (thing-at-point 'sexp))))
- (if (and (file-remote-p default-directory)
+ (thing-at-point 'sexp)))
+ (prefix (file-remote-p default-directory)))
+ (if (and prefix
;; We can't formally parse the input. But if there is
;; one of these operators behind us, then looking at
;; the first command would not be sensible. So be
@@ -93,14 +94,9 @@ eshell-electric-forward-slash
(or eshell-prefer-lisp-functions
(not (eshell-search-path command))))))))
(let ((map (make-sparse-keymap))
- (start (if tilde-before (1- (point)) (point)))
- (localname
- (tramp-file-name-localname
- (tramp-dissect-file-name default-directory))))
+ (start (if tilde-before (1- (point)) (point))))
(when tilde-before (delete-char -1))
- (insert
- (substring default-directory 0
- (string-search localname default-directory)))
+ (insert prefix)
(unless tilde-before (insert "/"))
;; Typing a second slash undoes the insertion, for when
;; you really do want to type a local absolute file name.
next prev parent reply other threads:[~2022-12-19 11:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 23:46 bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host montag451 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 10:34 ` Eli Zaretskii
2022-12-18 20:04 ` Jim Porter
2022-12-18 20:15 ` Eli Zaretskii
2022-12-19 11:29 ` montag451 via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-12-21 6:55 ` Jim Porter
2022-12-21 12:42 ` Eli Zaretskii
2022-12-21 22:27 ` Jim Porter
2022-12-23 19:46 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df6376c51d477868c76904b02f5693ad9569d721.camel@laposte.net \
--to=bug-gnu-emacs@gnu.org \
--cc=60083@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=montag451@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).