From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: montag451@laposte.net, 60083@debbugs.gnu.org
Subject: bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host
Date: Sun, 18 Dec 2022 22:15:24 +0200 [thread overview]
Message-ID: <83359cfoyr.fsf@gnu.org> (raw)
In-Reply-To: <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com> (message from Jim Porter on Sun, 18 Dec 2022 12:04:47 -0800)
> Date: Sun, 18 Dec 2022 12:04:47 -0800
> Cc: 60083@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 12/18/2022 2:34 AM, Eli Zaretskii wrote:
> >> Date: Thu, 15 Dec 2022 00:46:50 +0100
> >> From: montag451 via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >>
> >> While testing the new eshell module 'eshell-elecslash' I found a bug
> >> when the default-directory is the root of a remote host. To reproduce
> >> the problem type the following in a eshell buffer (replacing "method"
> >> and "host" by appropriate values):
> >>
> >> $ cd /method:host:/
> >> $ cd / <--- here the "/" should be replaced by "/method:host:/" but
> >> instead nothing happen
> >>
> >> I've attached a patch to this email which fixes this issue.
> >
> > Jim, are you looking into this issue?
>
> Thanks. I missed the original message. The patch looks good to me,
> although it compiles with the following warning:
>
> In eshell-electric-forward-slash:
> ../../lisp/eshell/em-elecslash.el:98:18: Warning: Unused lexical
> variable `localname'
>
> Looking through the code, I think we can just remove that variable.
>
> Since this is a small change, and fixes a corner case in a new feature,
> I think it would make sense to go on the release branch, though I'll
> defer to you on this, Eli. The fact that the new code (with the removal
> of 'localname') is a bit simpler helps too.
Yes, the release branch is fine for this. Especially since this
module is AFAIU new in Emacs 29.
Thanks.
next prev parent reply other threads:[~2022-12-18 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 23:46 bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host montag451 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-18 10:34 ` Eli Zaretskii
2022-12-18 20:04 ` Jim Porter
2022-12-18 20:15 ` Eli Zaretskii [this message]
2022-12-19 11:29 ` montag451 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-21 6:55 ` Jim Porter
2022-12-21 12:42 ` Eli Zaretskii
2022-12-21 22:27 ` Jim Porter
2022-12-23 19:46 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83359cfoyr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60083@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=montag451@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).