From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: montag451 via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60083: 29.0.60; eshell-elecslash when in the root directory of a remote host Date: Mon, 19 Dec 2022 12:29:27 +0100 Message-ID: References: <3f509b4aaaa957d43a429b2ee843c88312486e86.camel@laposte.net> <83o7s1f1at.fsf@gnu.org> <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com> Reply-To: montag451 Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-1Yi+4HWOZ2yRPPUyVMSY" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12955"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.46.1-1 Cc: 60083@debbugs.gnu.org To: Jim Porter , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 12:30:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7ELX-000390-PB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 12:30:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7ELN-0000Cz-Mx; Mon, 19 Dec 2022 06:30:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7ELL-0000BY-Lv for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 06:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7ELL-0002NO-7X for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 06:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7ELK-0004dY-Rd for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 06:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: montag451 Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60083 X-GNU-PR-Package: emacs Original-Received: via spool by 60083-submit@debbugs.gnu.org id=B60083.167144938117788 (code B ref 60083); Mon, 19 Dec 2022 11:30:02 +0000 Original-Received: (at 60083) by debbugs.gnu.org; 19 Dec 2022 11:29:41 +0000 Original-Received: from localhost ([127.0.0.1]:38290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7EKy-0004cq-TC for submit@debbugs.gnu.org; Mon, 19 Dec 2022 06:29:41 -0500 Original-Received: from smtp-outgoing-2002.laposte.net ([160.92.124.109]:46968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7EKw-0004ck-C5 for 60083@debbugs.gnu.org; Mon, 19 Dec 2022 06:29:39 -0500 X-mail-filterd: {"version":"1.5.1", "queueID":"4NbHY47239z14K1h", "contextId":"fbac1b07-d238-43e3-8c82-e7f665fca265"} Original-Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0109.laposte.net (SMTP Server) with ESMTP id 4NbHY47239z14K1h; Mon, 19 Dec 2022 12:29:28 +0100 (CET) X-mail-filterd: {"version":"1.5.1", "queueID":"4NbHY361cKz14K1f", "contextId":"76224273-14ac-4ba8-bd24-81332b4604a8"} X-lpn-mailing: LEGIT X-lpn-spamrating: 36 X-lpn-spamlevel: not-spam Original-Received: from [192.168.1.44] (214.122.141.88.rev.sfr.net [88.141.122.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0109.laposte.net (SMTP Server) with ESMTPSA id 4NbHY361cKz14K1f; Mon, 19 Dec 2022 12:29:27 +0100 (CET) In-Reply-To: <5cddf6c8-ac52-0bd7-c523-82ce1e75c99f@gmail.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laposte.net; s=lpn-wlmd; t=1671449370; bh=VCmpn2mRC5D+HxmuJEV0TJdy8vCEqIZVcZGjVO66YgM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:Content-Type:MIME-Version; b=A/bQkaLAeXq+gToMPeGRQz+F/PnO3dqzi/flzYX1dQT7xzDdtUbAP9ntQ2vwC06rthr+xvDhZ8EVRyH7XW89apnXMA1KWb85TlJwY74JhPKncneAJOgEPm2Qf6CY/UONj5UGKb/8T/0+J30yYLJKm77KS9EVwjuRTOp+AmHYZN9R9uWpfMSrSqoLEqxhgJuhwSTDupTkEgJ1zL2AqjrwxhsUtkSNudAFIBRIVREjeZe+ycsaMWzEntKDlAr13IdeWzu0GuQXbCgEl0YjjTwEXF8PS1OU3uG6jMKlwThyX6DOHKth7N7c1WkvFvTnYoAcfvMZug/iFp2jMnBnTTjItg==; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251416 Archived-At: --=-1Yi+4HWOZ2yRPPUyVMSY Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le dimanche 18 d=C3=A9cembre 2022 =C3=A0 12:04 -0800, Jim Porter a =C3=A9cr= it=C2=A0: > On 12/18/2022 2:34 AM, Eli Zaretskii wrote: > > > Date: Thu, 15 Dec 2022 00:46:50 +0100 > > > From:=C2=A0 montag451 via "Bug reports for GNU Emacs, > > > =C2=A0 the Swiss army knife of text editors" > > >=20 > > > While testing the new eshell module 'eshell-elecslash' I found a > > > bug > > > when the default-directory is the root of a remote host. To > > > reproduce > > > the problem type the following in a eshell buffer (replacing > > > "method" > > > and "host" by appropriate values): > > >=20 > > > $ cd /method:host:/ > > > $ cd / <--- here the "/" should be replaced by "/method:host:/" > > > but > > > instead nothing happen > > >=20 > > > I've attached a patch to this email which fixes this issue. > >=20 > > Jim, are you looking into this issue? >=20 > Thanks. I missed the original message. The patch looks good to me,=20 > although it compiles with the following warning: >=20 > =C2=A0=C2=A0 In eshell-electric-forward-slash: > =C2=A0=C2=A0 ../../lisp/eshell/em-elecslash.el:98:18: Warning: Unused lex= ical=20 > variable `localname' >=20 > Looking through the code, I think we can just remove that variable. >=20 > Since this is a small change, and fixes a corner case in a new > feature,=20 > I think it would make sense to go on the release branch, though I'll=20 > defer to you on this, Eli. The fact that the new code (with the > removal=20 > of 'localname') is a bit simpler helps too. Thanks for looking into this. I've attached to this email a new patch which fixes the compilation warning. --=-1Yi+4HWOZ2yRPPUyVMSY Content-Disposition: attachment; filename="eshell-elecslash.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="eshell-elecslash.patch"; charset="UTF-8" ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLWVsZWNzbGFzaC5lbCBiL2xpc3AvZXNoZWxsL2Vt LWVsZWNzbGFzaC5lbAppbmRleCAwOTFhY2I5YTg2Li4wY2UzYTRjYzk2IDEwMDY0NAotLS0gYS9s aXNwL2VzaGVsbC9lbS1lbGVjc2xhc2guZWwKKysrIGIvbGlzcC9lc2hlbGwvZW0tZWxlY3NsYXNo LmVsCkBAIC03NCw4ICs3NCw5IEBAIGVzaGVsbC1lbGVjdHJpYy1mb3J3YXJkLXNsYXNoCiAgICAg ICAgICAgKGNvbW1hbmQgKHNhdmUtZXhjdXJzaW9uCiAgICAgICAgICAgICAgICAgICAgICAoZXNo ZWxsLWJvbCkKICAgICAgICAgICAgICAgICAgICAgIChza2lwLXN5bnRheC1mb3J3YXJkICIgIikK LSAgICAgICAgICAgICAgICAgICAgICh0aGluZy1hdC1wb2ludCAnc2V4cCkpKSkKLSAgICAgIChp ZiAoYW5kIChmaWxlLXJlbW90ZS1wIGRlZmF1bHQtZGlyZWN0b3J5KQorICAgICAgICAgICAgICAg ICAgICAgKHRoaW5nLWF0LXBvaW50ICdzZXhwKSkpCisgICAgICAgICAgKHByZWZpeCAoZmlsZS1y ZW1vdGUtcCBkZWZhdWx0LWRpcmVjdG9yeSkpKQorICAgICAgKGlmIChhbmQgcHJlZml4CiAgICAg ICAgICAgICAgICA7OyBXZSBjYW4ndCBmb3JtYWxseSBwYXJzZSB0aGUgaW5wdXQuICBCdXQgaWYg dGhlcmUgaXMKICAgICAgICAgICAgICAgIDs7IG9uZSBvZiB0aGVzZSBvcGVyYXRvcnMgYmVoaW5k IHVzLCB0aGVuIGxvb2tpbmcgYXQKICAgICAgICAgICAgICAgIDs7IHRoZSBmaXJzdCBjb21tYW5k IHdvdWxkIG5vdCBiZSBzZW5zaWJsZS4gIFNvIGJlCkBAIC05MywxNCArOTQsOSBAQCBlc2hlbGwt ZWxlY3RyaWMtZm9yd2FyZC1zbGFzaAogCQkJICAgICAgICAgKG9yIGVzaGVsbC1wcmVmZXItbGlz cC1mdW5jdGlvbnMKIAkJCQkgICAgIChub3QgKGVzaGVsbC1zZWFyY2gtcGF0aCBjb21tYW5kKSkp KSkpKSkKIAkgIChsZXQgKChtYXAgKG1ha2Utc3BhcnNlLWtleW1hcCkpCi0JICAgICAgICAoc3Rh cnQgKGlmIHRpbGRlLWJlZm9yZSAoMS0gKHBvaW50KSkgKHBvaW50KSkpCi0gICAgICAgICAgICAg ICAgKGxvY2FsbmFtZQotICAgICAgICAgICAgICAgICAodHJhbXAtZmlsZS1uYW1lLWxvY2FsbmFt ZQotICAgICAgICAgICAgICAgICAgKHRyYW1wLWRpc3NlY3QtZmlsZS1uYW1lIGRlZmF1bHQtZGly ZWN0b3J5KSkpKQorCSAgICAgICAgKHN0YXJ0IChpZiB0aWxkZS1iZWZvcmUgKDEtIChwb2ludCkp IChwb2ludCkpKSkKIAkgICAgKHdoZW4gdGlsZGUtYmVmb3JlIChkZWxldGUtY2hhciAtMSkpCi0J ICAgIChpbnNlcnQKLSAgICAgICAgICAgICAoc3Vic3RyaW5nIGRlZmF1bHQtZGlyZWN0b3J5IDAK LSAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctc2VhcmNoIGxvY2FsbmFtZSBkZWZhdWx0 LWRpcmVjdG9yeSkpKQorCSAgICAoaW5zZXJ0IHByZWZpeCkKIAkgICAgKHVubGVzcyB0aWxkZS1i ZWZvcmUgKGluc2VydCAiLyIpKQogCSAgICA7OyBUeXBpbmcgYSBzZWNvbmQgc2xhc2ggdW5kb2Vz IHRoZSBpbnNlcnRpb24sIGZvciB3aGVuCiAJICAgIDs7IHlvdSByZWFsbHkgZG8gd2FudCB0byB0 eXBlIGEgbG9jYWwgYWJzb2x1dGUgZmlsZSBuYW1lLgo= --=-1Yi+4HWOZ2yRPPUyVMSY--