From: Jim Porter <jporterbugs@gmail.com>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 67661@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
john muhl <jm@pub.pink>, Eshel Yaron <me@eshelyaron.com>,
Juri Linkov <juri@linkov.net>
Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer
Date: Wed, 17 Jan 2024 11:18:32 -0800 [thread overview]
Message-ID: <dc4c39cd-6ddf-2e41-cd62-d55d954a1516@gmail.com> (raw)
In-Reply-To: <871qapnkdl.fsf@zephyr.silentflame.com>
On 1/10/2024 9:55 AM, Sean Whitton wrote:
>> --- a/test/lisp/eshell/em-cmpl-tests.el
>> +++ b/test/lisp/eshell/em-cmpl-tests.el
>> @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique
>> (save-excursion
>> (goto-char (point-max))
>> (forward-line -1)
>> - (should (looking-at "Complete, but not unique")))))))
>> + (should (looking-at "Making completion list...")))))))
>>
>> (ert-deftest em-cmpl-test/file-completion/glob ()
>> "Test completion of file names using a glob."
>
> Jim, does this seem reasonable?
Sorry, I missed this the first time around (I've got a lot of other
stuff I'm trying to balance at the moment). I think this would fix the
issue, but I've instead pushed 5f5faad2497 which solves this in a
more-direct way by checking whether the *Completions* buffer is visible.
That's what the test is really trying to test anyway.
next prev parent reply other threads:[~2024-01-17 19:18 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 15:30 bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Sean Whitton
2023-12-06 17:13 ` Juri Linkov
2023-12-06 18:14 ` Sean Whitton
2023-12-06 18:41 ` Eli Zaretskii
2023-12-07 11:42 ` Sean Whitton
2023-12-09 12:09 ` Sean Whitton
2023-12-09 13:08 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 13:25 ` Eli Zaretskii
2023-12-09 14:13 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 14:40 ` Eli Zaretskii
2023-12-09 15:22 ` Sean Whitton
2023-12-09 16:03 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 16:07 ` Sean Whitton
2023-12-09 17:19 ` Juri Linkov
2023-12-09 19:04 ` Sean Whitton
2023-12-10 17:46 ` Juri Linkov
2023-12-10 21:42 ` Sean Whitton
2023-12-11 17:15 ` Juri Linkov
2023-12-15 12:28 ` Sean Whitton
2023-12-19 17:29 ` Juri Linkov
2023-12-19 18:31 ` Sean Whitton
2023-12-19 18:58 ` Juri Linkov
2023-12-20 10:34 ` Sean Whitton
2023-12-20 17:14 ` Juri Linkov
2023-12-22 12:00 ` Sean Whitton
2023-12-23 17:38 ` Juri Linkov
2023-12-29 17:47 ` Sean Whitton
2023-12-29 18:00 ` Sean Whitton
2023-12-29 19:27 ` Eli Zaretskii
2023-12-29 20:24 ` Sean Whitton
2023-12-30 6:30 ` Eli Zaretskii
2023-12-30 10:41 ` Sean Whitton
2023-12-30 17:52 ` Juri Linkov
2023-12-30 19:43 ` Sean Whitton
2023-12-30 17:50 ` Juri Linkov
2023-12-30 19:43 ` Sean Whitton
2023-12-31 8:29 ` Juri Linkov
2024-01-10 3:12 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 17:55 ` Sean Whitton
2024-01-17 19:18 ` Jim Porter [this message]
2023-12-09 16:22 ` Eli Zaretskii
2023-12-07 17:28 ` Juri Linkov
2023-12-07 22:04 ` Sean Whitton
2023-12-08 6:28 ` Eli Zaretskii
2023-12-08 10:19 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc4c39cd-6ddf-2e41-cd62-d55d954a1516@gmail.com \
--to=jporterbugs@gmail.com \
--cc=67661@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jm@pub.pink \
--cc=juri@linkov.net \
--cc=me@eshelyaron.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).