From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Date: Wed, 17 Jan 2024 11:18:32 -0800 Message-ID: References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <87zfxdvq3t.fsf@pub.pink> <871qapnkdl.fsf@zephyr.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17320"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67661@debbugs.gnu.org, Eli Zaretskii , john muhl , Eshel Yaron , Juri Linkov To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 17 20:19:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQBRM-0004KA-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jan 2024 20:19:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQBRG-00061j-BU; Wed, 17 Jan 2024 14:19:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQBRF-00061I-0q for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2024 14:19:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQBRE-0000KD-Ox for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2024 14:19:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rQBRF-0003uo-L8 for bug-gnu-emacs@gnu.org; Wed, 17 Jan 2024 14:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jan 2024 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67661 X-GNU-PR-Package: emacs Original-Received: via spool by 67661-submit@debbugs.gnu.org id=B67661.170551912315015 (code B ref 67661); Wed, 17 Jan 2024 19:19:01 +0000 Original-Received: (at 67661) by debbugs.gnu.org; 17 Jan 2024 19:18:43 +0000 Original-Received: from localhost ([127.0.0.1]:53526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQBQw-0003u7-SF for submit@debbugs.gnu.org; Wed, 17 Jan 2024 14:18:43 -0500 Original-Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:51415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQBQv-0003ts-Dx for 67661@debbugs.gnu.org; Wed, 17 Jan 2024 14:18:41 -0500 Original-Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6d9a79a1ad4so6218952b3a.2 for <67661@debbugs.gnu.org>; Wed, 17 Jan 2024 11:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705519114; x=1706123914; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=6AcaYyi6iclkjXFp1MSr4ZM7x/5w7Spc6yDugMHvCl0=; b=LJ9PS78YHM/lGvZvkNdImVpgMwCl6AQY36O+HcxTrsSKI+tU5dVjYGqCcgRpAOYiXv tevp7VkpH82xf76bvLgUyMSRFknRFcG81JxIdNPMIgO7seu6E6lfsHpxa3FvEmqcaysd gnuzcOPuA2IG9Uz8L5YzkzWW3KoYpIDhPV3hlsH2J8bGYeYTICrjEylycYofQ50jkgQF ObqoP5P08kZ6tgQ6KcnV3MNnN1ODg4oPNC3aQwDsYv/ggx6OKBAhyCUNZSoT9WByEWRF Jox5Z1tlPIQ79rXynrUvbOeqYZD6dFbuc08XKxcb24SNgedeQjNQcjfbKIgtY5H+mtCR fMCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705519114; x=1706123914; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6AcaYyi6iclkjXFp1MSr4ZM7x/5w7Spc6yDugMHvCl0=; b=uwpfQQfE6b809Si8XkGJPHNZUmZw7z5d5GvOylsB76zkBSlV26ud77RkV0UYdeEznQ lX9fFPFFxDl0TjSwKdaQtnuol+dnR0OaCRFn+2CaIddoSsF3lyhbBqCC63SBO2eMoaxo cgpDwTgHjKXYZVoylNv/9uSfeKGeZ6aEd2HQUQKHduGpT2PhMJow3ZWswnios+uf/3cM TsSFh/SeDVAdJfNnsBHODBoGXKRtsI9B8x3UYY14WmdkQbVRVVcIfVYiLX+lWpddUdIA uftLoCLS2n+oDYIfA4wb3v4w3yudjtIlrTis7f8/0VK77O9m6q3OaVJ+r62WqTFZe5lf zR8w== X-Gm-Message-State: AOJu0YzdMTbuFXvqy7PT2rqAe7If6402+96dvPz/GvE1cC7HfJDjgvyu y6moCN2e3BBG6JpqbVT5cTk= X-Google-Smtp-Source: AGHT+IGPDownS8tT800gncP/jQ8PycJiC6T4tNbqqL8vjWHq1ssxa4mKt80KL+qjDMVQ+xdjgzoGzQ== X-Received: by 2002:a05:6a21:18c:b0:19a:427c:5c4a with SMTP id le12-20020a056a21018c00b0019a427c5c4amr5801565pzb.22.1705519114083; Wed, 17 Jan 2024 11:18:34 -0800 (PST) Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a14-20020aa7864e000000b006d93afd243asm1806151pfo.72.2024.01.17.11.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jan 2024 11:18:33 -0800 (PST) Content-Language: en-US In-Reply-To: <871qapnkdl.fsf@zephyr.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278406 Archived-At: On 1/10/2024 9:55 AM, Sean Whitton wrote: >> --- a/test/lisp/eshell/em-cmpl-tests.el >> +++ b/test/lisp/eshell/em-cmpl-tests.el >> @@ -186,7 +186,7 @@ em-cmpl-test/file-completion/non-unique >> (save-excursion >> (goto-char (point-max)) >> (forward-line -1) >> - (should (looking-at "Complete, but not unique"))))))) >> + (should (looking-at "Making completion list..."))))))) >> >> (ert-deftest em-cmpl-test/file-completion/glob () >> "Test completion of file names using a glob." > > Jim, does this seem reasonable? Sorry, I missed this the first time around (I've got a lot of other stuff I'm trying to balance at the moment). I think this would fix the issue, but I've instead pushed 5f5faad2497 which solves this in a more-direct way by checking whether the *Completions* buffer is visible. That's what the test is really trying to test anyway.