From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: 67661@debbugs.gnu.org, me@eshelyaron.com, juri@linkov.net
Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer
Date: Sat, 30 Dec 2023 08:30:29 +0200 [thread overview]
Message-ID: <838r5c5hiy.fsf@gnu.org> (raw)
In-Reply-To: <877ckw21vp.fsf@zephyr.silentflame.com> (message from Sean Whitton on Fri, 29 Dec 2023 20:24:26 +0000)
> From: Sean Whitton <spwhitton@spwhitton.name>
> Cc: me@eshelyaron.com, 67661@debbugs.gnu.org
> Date: Fri, 29 Dec 2023 20:24:26 +0000
>
> On Fri 29 Dec 2023 at 09:27pm +02, Eli Zaretskii wrote:
>
> > To which entry in Emacs 29's NEWS would this be related?
>
> I'm talking about how Juri fixed icomplete-in-buffer for Emacs 29, and
> how it's now working differently. Juri's fix wasn't noted in NEWS.29,
> so there isn't a relevant entry.
I thought you were suggesting to add something to NEWS in Emacs 29.
If there's no suitable entry there, then I wonder what did you have in
mind for Emacs 29 in this area.
> Thus, I propose adding a NEWS.30 entry like this:
>
> There have been some changes which normalise some behaviour of
> in-buffer completion that affect users of icomplete-in-buffer.
>
> Firstly, completion-auto-help now governs icomplete-in-buffer,
> whereas previously it affected only minibuffer completion. You may
> wish to review any existing customisation for completion-auto-help
> if in-buffer completion behaves in a way that surprises you.
>
> Secondly, the *Completions* buffer now always pops up at the same
> time that Icomplete displays its in-buffer completion. If you would
> prefer to see only Icomplete's display, which is what you might be
> used to, you could use
>
> (advice-add 'completion-at-point :after #'minibuffer-hide-completions)
AFAIU, this should also mention changes in Emacs 29 wrt previous
versions.
Also, the entry should in terms of user-facing behavior, not in terms
of how code works. It should also be more concrete; phrases like "you
may wish to review existing customizations" are too vague to be
useful.
The last paragraph seems to indicate we lack some user option or a
variable to get back the old behavior, since using advice-add is less
friendly than flipping a variable.
(IMO, we are making too many backward-incompatible changes in this
area lately. But that's me.)
next prev parent reply other threads:[~2023-12-30 6:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 15:30 bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Sean Whitton
2023-12-06 17:13 ` Juri Linkov
2023-12-06 18:14 ` Sean Whitton
2023-12-06 18:41 ` Eli Zaretskii
2023-12-07 11:42 ` Sean Whitton
2023-12-09 12:09 ` Sean Whitton
2023-12-09 13:08 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 13:25 ` Eli Zaretskii
2023-12-09 14:13 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 14:40 ` Eli Zaretskii
2023-12-09 15:22 ` Sean Whitton
2023-12-09 16:03 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 16:07 ` Sean Whitton
2023-12-09 17:19 ` Juri Linkov
2023-12-09 19:04 ` Sean Whitton
2023-12-10 17:46 ` Juri Linkov
2023-12-10 21:42 ` Sean Whitton
2023-12-11 17:15 ` Juri Linkov
2023-12-15 12:28 ` Sean Whitton
2023-12-19 17:29 ` Juri Linkov
2023-12-19 18:31 ` Sean Whitton
2023-12-19 18:58 ` Juri Linkov
2023-12-20 10:34 ` Sean Whitton
2023-12-20 17:14 ` Juri Linkov
2023-12-22 12:00 ` Sean Whitton
2023-12-23 17:38 ` Juri Linkov
2023-12-29 17:47 ` Sean Whitton
2023-12-29 18:00 ` Sean Whitton
2023-12-29 19:27 ` Eli Zaretskii
2023-12-29 20:24 ` Sean Whitton
2023-12-30 6:30 ` Eli Zaretskii [this message]
2023-12-30 10:41 ` Sean Whitton
2023-12-30 17:52 ` Juri Linkov
2023-12-30 19:43 ` Sean Whitton
2023-12-30 17:50 ` Juri Linkov
2023-12-30 19:43 ` Sean Whitton
2023-12-31 8:29 ` Juri Linkov
2024-01-10 3:12 ` john muhl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 17:55 ` Sean Whitton
2024-01-17 19:18 ` Jim Porter
2023-12-09 16:22 ` Eli Zaretskii
2023-12-07 17:28 ` Juri Linkov
2023-12-07 22:04 ` Sean Whitton
2023-12-08 6:28 ` Eli Zaretskii
2023-12-08 10:19 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838r5c5hiy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67661@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=me@eshelyaron.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).