From: martin rudalics <rudalics@gmx.at>
To: Sujith Manoharan <sujith.wall@gmail.com>,
48493@debbugs.gnu.org, pillule <pillule@riseup.net>
Subject: bug#48493: 28.0.50; quit-window doesn't work
Date: Tue, 18 May 2021 10:01:20 +0200 [thread overview]
Message-ID: <db835985-2e8a-e53d-62e6-9be79a6e9c3b@gmx.at> (raw)
In-Reply-To: <87h7j0wwkf.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
> quit-window doesn't work properly with the master branch.
>
> To see the issue with emacs -Q, in any git repo:
>
> * C-x v L
> * C-x 1 (if the screen is split).
> * Hitting 'q' now doesn't close the window.
>
> Looks like commit 0a681590268a4039f95a5a919b6b6d4f4e880d4c is
> the problem.
Right. Can you try the attached patch? pillule, please also have a
look into this.
Thanks for the report, martin
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: quit-restore-window.diff --]
[-- Type: text/x-patch; name="quit-restore-window.diff", Size: 603 bytes --]
diff --git a/lisp/window.el b/lisp/window.el
index 026cde5901..8a767140bc 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -5110,8 +5110,7 @@ quit-restore-window
(set-window-parameter window 'quit-restore nil)
;; Make sure that WINDOW is no more dedicated.
(set-window-dedicated-p window nil)
- (if prev-buffer
- (switch-to-prev-buffer window bury-or-kill)
+ (unless (switch-to-prev-buffer window bury-or-kill)
;; Delete WINDOW if there is no previous buffer (Bug#48367).
(window--delete window nil (eq bury-or-kill 'kill)))))
next prev parent reply other threads:[~2021-05-18 8:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 3:21 bug#48493: 28.0.50; quit-window doesn't work Sujith Manoharan
2021-05-18 8:01 ` martin rudalics [this message]
2021-05-18 10:23 ` Sujith Manoharan
2021-05-18 13:31 ` martin rudalics
2021-05-19 7:43 ` martin rudalics
2021-05-24 14:53 ` pillule
2021-05-24 16:51 ` martin rudalics
2021-05-25 1:58 ` pillule
2021-05-25 6:50 ` martin rudalics
2021-05-25 13:01 ` pillule
2021-05-25 16:28 ` martin rudalics
2021-05-26 16:10 ` pillule
2021-05-27 7:47 ` martin rudalics
2021-06-07 23:23 ` pillule
2021-06-08 9:24 ` pillule
2021-06-09 8:33 ` martin rudalics
2021-06-09 12:34 ` pillule
2021-06-09 13:00 ` pillule
2021-06-09 13:36 ` pillule
2021-06-13 8:49 ` martin rudalics
2021-06-13 9:28 ` pillule
2021-06-13 14:52 ` martin rudalics
2021-06-14 8:28 ` martin rudalics
2021-06-15 16:53 ` pillule
2021-06-08 12:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db835985-2e8a-e53d-62e6-9be79a6e9c3b@gmx.at \
--to=rudalics@gmx.at \
--cc=48493@debbugs.gnu.org \
--cc=pillule@riseup.net \
--cc=sujith.wall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).