unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: pillule <pillule@riseup.net>
Cc: Sujith Manoharan <sujith.wall@gmail.com>, 48493@debbugs.gnu.org
Subject: bug#48493: 28.0.50; quit-window doesn't work
Date: Mon, 24 May 2021 18:51:18 +0200	[thread overview]
Message-ID: <b800d2b4-0079-8f73-5d36-27b0fca565f3@gmx.at> (raw)
In-Reply-To: <87cztg41zy.fsf@host.localdomain>

 > I think there is still edges cases :
 >
 > with emacs -Q
 >
 > ;; set some rules
 > (setq display-buffer-alist
 >      '(("\\*\\(Backtrace\\)\\*"
 >        (display-buffer-in-side-window)
 >        (window-height . 0.2)
 >        (side . bottom))
 >        ("\\*\\(Messages\\)\\*"
 >        (display-buffer-in-side-window)
 >        (window-height . 0.2)
 >        (side . bottom))))
 >
 > ;; display the *Messages* buffer
 > (view-echo-area-messages)
 >
 > ;; trigger a logical error to display the *Backtrace* buffer
 > (> vim emacs)
 >
 > ;; trigger a quit-restore-window by calling kill-buffer in a   dedicated window
 > (kill-buffer (get-buffer "*Backtrace*"))
 > ;; the dedicated property has been cleaned from the window,
 > ;; yet *Messages* is displayed in place of this window !
 > (kill-buffer (get-buffer "*Messages*"))
 > ;; calling kill-buffer in a non-dedicated window,
 > ;; does not trigger quit-restore-window anymore
 > ;; resulting in an undesirable buffer being displayed in place.
 >
 >
 > What is the desired behavior of a dedicated window here ?
 > Must *Messages* be displayed after we killed *Backtrace* in the first
 > place ?

I think so, yes.

 > I am suspecting that the locale value of `kill-buffer-hook' in
 > *Backtrace* is interfering with this test but I have difficulties to
 > find its human readable form.

I doubt that.  It's probably due to my fix for Bug#48493.  When
*Messages* is killed, the window should have no more previous buffers to
display and we should be able to kill it.  But `switch-to-prev-buffer'
shows the "next" buffer instead.  Try to come up with a solution that
does not reintroduce Bug#48493 and deletes the window when no previous
buffer is found.

martin





  reply	other threads:[~2021-05-24 16:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  3:21 bug#48493: 28.0.50; quit-window doesn't work Sujith Manoharan
2021-05-18  8:01 ` martin rudalics
2021-05-18 10:23   ` Sujith Manoharan
2021-05-18 13:31     ` martin rudalics
2021-05-19  7:43     ` martin rudalics
2021-05-24 14:53   ` pillule
2021-05-24 16:51     ` martin rudalics [this message]
2021-05-25  1:58       ` pillule
2021-05-25  6:50         ` martin rudalics
2021-05-25 13:01           ` pillule
2021-05-25 16:28             ` martin rudalics
2021-05-26 16:10               ` pillule
2021-05-27  7:47                 ` martin rudalics
2021-06-07 23:23                   ` pillule
2021-06-08  9:24                     ` pillule
2021-06-09  8:33                       ` martin rudalics
2021-06-09 12:34                         ` pillule
2021-06-09 13:00                           ` pillule
2021-06-09 13:36                             ` pillule
2021-06-13  8:49                               ` martin rudalics
2021-06-13  9:28                                 ` pillule
2021-06-13 14:52                                   ` martin rudalics
2021-06-14  8:28                               ` martin rudalics
2021-06-15 16:53                                 ` pillule
2021-06-08 12:09                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b800d2b4-0079-8f73-5d36-27b0fca565f3@gmx.at \
    --to=rudalics@gmx.at \
    --cc=48493@debbugs.gnu.org \
    --cc=pillule@riseup.net \
    --cc=sujith.wall@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).