From: pillule <pillule@riseup.net>
To: pillule <pillule@riseup.net>
Cc: Sujith Manoharan <sujith.wall@gmail.com>, 48493@debbugs.gnu.org
Subject: bug#48493: 28.0.50; quit-window doesn't work
Date: Wed, 09 Jun 2021 15:00:38 +0200 [thread overview]
Message-ID: <87v96ni41i.fsf@riseup.net> (raw)
In-Reply-To: <87y2bji58t.fsf@riseup.net>
>> What's wrong with putting the first disjunct into the
>> conditional as in
>> the below? In general, always try to avoid larger indentation
>> changes -
>> they can make forensics cumbersome while bisecting.
>>
>> (cond
>> ;; First try to delete dedicated windows that are not
>> side windows
>> ((and dedicated (not (eq dedicated 'side))
>> (window--delete window 'dedicated (eq bury-or-kill
>> 'kill))))
>> ((and (not prev-buffer)
>> (eq (nth 1 quit-restore) 'tab)
>> (eq (nth 3 quit-restore) buffer))
>
> The difference is a window dedicated with flag t may not be
> deletable, and in this case, we want it
> to pass through the others conditionals branch of
> quit-restore-window, so it can try to use the
> 'quit-restore parameter, close the tab or to fallback in t, etc.
> Explaining it makes me thing I could use 'window-deletable-p' in
> its conditional and ...
> I guess, problem solved
>
I read it again and think you were right,
when (window--delete window 'dedicated (eq bury-or-kill 'kill))
is part of the conditional, it indeed already fail if the window
is not deletable ;
I will correct that in the next revision.
--
next prev parent reply other threads:[~2021-06-09 13:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 3:21 bug#48493: 28.0.50; quit-window doesn't work Sujith Manoharan
2021-05-18 8:01 ` martin rudalics
2021-05-18 10:23 ` Sujith Manoharan
2021-05-18 13:31 ` martin rudalics
2021-05-19 7:43 ` martin rudalics
2021-05-24 14:53 ` pillule
2021-05-24 16:51 ` martin rudalics
2021-05-25 1:58 ` pillule
2021-05-25 6:50 ` martin rudalics
2021-05-25 13:01 ` pillule
2021-05-25 16:28 ` martin rudalics
2021-05-26 16:10 ` pillule
2021-05-27 7:47 ` martin rudalics
2021-06-07 23:23 ` pillule
2021-06-08 9:24 ` pillule
2021-06-09 8:33 ` martin rudalics
2021-06-09 12:34 ` pillule
2021-06-09 13:00 ` pillule [this message]
2021-06-09 13:36 ` pillule
2021-06-13 8:49 ` martin rudalics
2021-06-13 9:28 ` pillule
2021-06-13 14:52 ` martin rudalics
2021-06-14 8:28 ` martin rudalics
2021-06-15 16:53 ` pillule
2021-06-08 12:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v96ni41i.fsf@riseup.net \
--to=pillule@riseup.net \
--cc=48493@debbugs.gnu.org \
--cc=sujith.wall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).