From: Dmitry Gutov <dgutov@yandex.ru>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: 46358@debbugs.gnu.org
Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git
Date: Tue, 9 Feb 2021 15:05:39 +0200 [thread overview]
Message-ID: <d35fcfba-c46f-cab7-0e9e-4ea2dc6bfb43@yandex.ru> (raw)
In-Reply-To: <87h7mlu96b.fsf@protesilaos.com>
On 09.02.2021 07:01, Protesilaos Stavrou wrote:
> I also think that 4 faces should suffice. Having checked the doc string
> of 'vc-state' this is how I feel they should be organised.
>
> | status | face ("?" means suggestion) |
> |------------------+-----------------------------|
> | up-to-date | vc-dir-status-up-to-date |
> | edited | vc-dir-status-edited |
> | USER | vc-dir-status-warning? |
> | needs-update | vc-dir-status-warning? |
> | unlocked-changes | vc-dir-status-warning? |
> | added | vc-dir-status-edited |
> | removed | vc-dir-status-edited |
> | conflict | vc-dir-status-warning |
> | missing | vc-dir-status-warning |
> | ignored | vc-dir-ignored |
> | unregistered | vc-dir-status-edited |
Looks good.
> With regard to 'vc-dir-ignored', do you think we should rename it to
> 'vc-dir-status-ignored' for the sake of consistency?
Yes, probably. Let's see how your discussion with Juri ends up.
But if the only one use of this face is related to stashes, perhaps
introduce a stash-specific face instead.
prev parent reply other threads:[~2021-02-09 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 11:42 bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Protesilaos Stavrou
2021-02-07 15:15 ` Eli Zaretskii
2021-02-07 16:15 ` Protesilaos Stavrou
2021-02-08 6:55 ` Lars Ingebrigtsen
2021-02-08 18:17 ` Juri Linkov
2021-02-08 23:24 ` Dmitry Gutov
2021-02-09 6:42 ` Protesilaos Stavrou
2021-02-09 9:19 ` Juri Linkov
2021-02-09 16:30 ` Protesilaos Stavrou
2021-02-09 17:46 ` Protesilaos Stavrou
2021-02-10 1:48 ` Dmitry Gutov
2021-02-10 4:06 ` Protesilaos Stavrou
2021-02-10 13:32 ` Dmitry Gutov
2021-02-08 15:54 ` Dmitry Gutov
2021-02-08 16:35 ` Protesilaos Stavrou
2021-02-08 23:33 ` Dmitry Gutov
2021-02-09 5:01 ` Protesilaos Stavrou
2021-02-09 13:05 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d35fcfba-c46f-cab7-0e9e-4ea2dc6bfb43@yandex.ru \
--to=dgutov@yandex.ru \
--cc=46358@debbugs.gnu.org \
--cc=info@protesilaos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).