From: Juri Linkov <juri@linkov.net>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 46358@debbugs.gnu.org, Protesilaos Stavrou <info@protesilaos.com>
Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git
Date: Mon, 08 Feb 2021 20:17:33 +0200 [thread overview]
Message-ID: <87im72o6r6.fsf@mail.linkov.net> (raw)
In-Reply-To: <87im73m4ki.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 08 Feb 2021 07:55:25 +0100")
>> Very well! I am doing just that in the revised patch. So there should
>> be no visual difference between this and the prior state, except for one
>> case: the empty Git stash header, which will ultimately inherit from
>> 'shadow' (before there was a "FIXME" to disambiguate it from other
>> header values).
>
> Looks good to me; pushed to Emacs 28 now.
I don't know if anyone else has such problem, but now highlighting
the empty Git stash header with a different color distinguishes it
from other header lines, and thus attracts more attention.
So now the most noticeable thing in the vc-dir is the Git stash header
(that I almost never use).
Maybe better to display the empty Git stash header using the default
colors, and then highlight it differently only when it's non-empty?
next prev parent reply other threads:[~2021-02-08 18:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 11:42 bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Protesilaos Stavrou
2021-02-07 15:15 ` Eli Zaretskii
2021-02-07 16:15 ` Protesilaos Stavrou
2021-02-08 6:55 ` Lars Ingebrigtsen
2021-02-08 18:17 ` Juri Linkov [this message]
2021-02-08 23:24 ` Dmitry Gutov
2021-02-09 6:42 ` Protesilaos Stavrou
2021-02-09 9:19 ` Juri Linkov
2021-02-09 16:30 ` Protesilaos Stavrou
2021-02-09 17:46 ` Protesilaos Stavrou
2021-02-10 1:48 ` Dmitry Gutov
2021-02-10 4:06 ` Protesilaos Stavrou
2021-02-10 13:32 ` Dmitry Gutov
2021-02-08 15:54 ` Dmitry Gutov
2021-02-08 16:35 ` Protesilaos Stavrou
2021-02-08 23:33 ` Dmitry Gutov
2021-02-09 5:01 ` Protesilaos Stavrou
2021-02-09 13:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im72o6r6.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=46358@debbugs.gnu.org \
--cc=info@protesilaos.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).