From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46358: 28.0.50; [PATCH] Add vc-dir faces; also apply them to vc-git Date: Tue, 9 Feb 2021 15:05:39 +0200 Message-ID: References: <87czxc5cku.fsf@protesilaos.com> <83tuqnnc3s.fsf@gnu.org> <87pn1b4zxp.fsf@protesilaos.com> <87zh0eo6uk.fsf@protesilaos.com> <8f588591-bef5-3e8e-816e-d9ae3658eca1@yandex.ru> <87h7mlu96b.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7683"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: 46358@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 09 14:06:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Sia-0001tN-3t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 14:06:12 +0100 Original-Received: from localhost ([::1]:45388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9SiZ-0000dC-6x for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 08:06:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9SiR-0000cp-LO for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 08:06:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9SiQ-0002bB-Bu for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 08:06:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9SiP-0006G6-TT for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 08:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Feb 2021 13:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46358 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 46358-submit@debbugs.gnu.org id=B46358.161287594924039 (code B ref 46358); Tue, 09 Feb 2021 13:06:01 +0000 Original-Received: (at 46358) by debbugs.gnu.org; 9 Feb 2021 13:05:49 +0000 Original-Received: from localhost ([127.0.0.1]:52878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9SiC-0006Ff-Pi for submit@debbugs.gnu.org; Tue, 09 Feb 2021 08:05:49 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:34346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9SiB-0006FS-OW for 46358@debbugs.gnu.org; Tue, 09 Feb 2021 08:05:48 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id hs11so31297766ejc.1 for <46358@debbugs.gnu.org>; Tue, 09 Feb 2021 05:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LfFuO9iqiz0iI3mH5BpbmOUO/xYpaySN13FaFrIDLKI=; b=qUMxkMV/Ifv8ZeyrtKMnFeH7nLtbH50oLOfyQwWI+CREnb/WVlJH1+Y0ammGiDy8Lo OP02x/7KeglQBpwT9eDNoPoPaUHWGfL0kzLxHgFvSbPnUoG+JocVBoCYmU2RC2x+LpuV M6BRcgy7pgZTwEP78+3cddmAcHxDp+Y8XJtDVhnj6UiruncKlF657zo9kbUErJTsDtkl PS79/lxQ/2RU33hyP5o4uZZUfIJReE44AXLP7rqqfpYTWAbhX91/CqzBXC8CVvpwg/Cy 7+OZwqoeLSDdUOynkZwevEleQ1gSbdsDKXTv+IcGy0yG6t+jg86GEkqGNalJ7KRxcC6I vbdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LfFuO9iqiz0iI3mH5BpbmOUO/xYpaySN13FaFrIDLKI=; b=eO/P82z1t6EdUwQlhRL1/D2+Z8Mswoa/uPgVhl+vIwlgikD3gVjeN7Yz+3TxlNX/t4 smVXwpbDEaWZ03rRM5HW3vjiG1igRq9+G5Ov64XwO3DmHTSCUGrpTW3Uj6HvF7YzePi8 9VKO9PuGyRIX7szIZKJByWsdJVBUEy/8i3lR2gW7ctvYprYK4A4Lz3ED9Ls+Pmx3T553 Kce/UhV+24PNcfG09eBSbLXEBmotGpJQyyBT5dOHZqmHv3CHEV9q7zKyCnUNNQhQD8cQ c2YWelgcBz2NnALsQSWJUdI2F6ZOFO5o03EIaCZCRhHi82PPkrLIoGp4461tVFdfojyX X0nQ== X-Gm-Message-State: AOAM5321xPA221V9+yNV95EG9LEVSxIQNmrIF3Nu7/Q8hafLa8u6HJKu 02Xonz/PUTDeCIB8Y/GHiVeNMqWOIms= X-Google-Smtp-Source: ABdhPJy9WAWKihkXcUGcppBfehT/oFJnnCmasXaGKEi3wWgR0dxeFNQTzRLCcvHE6XmJkp484SkBYQ== X-Received: by 2002:a17:907:210d:: with SMTP id qn13mr21796837ejb.377.1612875941623; Tue, 09 Feb 2021 05:05:41 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id ga5sm3028914ejb.114.2021.02.09.05.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Feb 2021 05:05:41 -0800 (PST) In-Reply-To: <87h7mlu96b.fsf@protesilaos.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199689 Archived-At: On 09.02.2021 07:01, Protesilaos Stavrou wrote: > I also think that 4 faces should suffice. Having checked the doc string > of 'vc-state' this is how I feel they should be organised. > > | status | face ("?" means suggestion) | > |------------------+-----------------------------| > | up-to-date | vc-dir-status-up-to-date | > | edited | vc-dir-status-edited | > | USER | vc-dir-status-warning? | > | needs-update | vc-dir-status-warning? | > | unlocked-changes | vc-dir-status-warning? | > | added | vc-dir-status-edited | > | removed | vc-dir-status-edited | > | conflict | vc-dir-status-warning | > | missing | vc-dir-status-warning | > | ignored | vc-dir-ignored | > | unregistered | vc-dir-status-edited | Looks good. > With regard to 'vc-dir-ignored', do you think we should rename it to > 'vc-dir-status-ignored' for the sake of consistency? Yes, probably. Let's see how your discussion with Juri ends up. But if the only one use of this face is related to stashes, perhaps introduce a stash-specific face instead.