unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: 55836@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#55836: 29.0.50; (iconify-frame) freezes buffer view under Wayland.
Date: Mon, 3 Oct 2022 14:28:11 +0200 (CEST)	[thread overview]
Message-ID: <c31acde9-7f81-98f4-121-2ce3b78a5453@gmail.com> (raw)
In-Reply-To: <87bkqx57do.fsf@yahoo.com>



On Fri, 30 Sep 2022, Po Lu wrote:

>> 1. The breakpoint at gdk_wayland_window_handle_configure is never reached.
>>     I have tried with both patches discussed above, and the master branch
>>     with no success: such breakpoint is not reached.

It turned out I was missing some debugging symbols.
Once iinstalled all the debugging symbols the breakpoint is reached as 
expected.


>>> Could you install debug info for GDK, put breakpoints on both
>>> window_state_event (in pgtkterm.c) and
>>> gdk_wayland_window_handle_configure (in gdkwindow-wayland.c)?
>>
>>> Please see whether the former is called after the latter, and in doing
>>> so clears the iconified flag?

The iconified flag is cleared, but I cannot tell you where this happens.
Of course, that prevents us to enter in the `if` branch at line 5472:
if (FRAME_ICONIFIED_P (f))


My two fixes point to the `else` branch at line 5505:

```
   if (new_state & GDK_WINDOW_STATE_ICONIFIED)
     SET_FRAME_ICONIFIED (f, true);
   else
     {
       FRAME_X_OUTPUT (f)->has_been_visible = true;
       inev.ie.kind = DEICONIFY_EVENT;
       XSETFRAME (inev.ie.frame_or_window, f);
       SET_FRAME_ICONIFIED (f, false);
     }
```

1. The first one "extends" this branch by adding this line:

SET_FRAME_VISIBLE (f, 1);

2. The second one just removes that `else` branch.

Both seems to fix the issue in my Wayland session.





  reply	other threads:[~2022-10-03 12:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <c49677c5-8fe8-6038-7776-f42b5fba91e4@gmail.com>
2022-09-25 12:06 ` bug#55836: 29.0.50; (iconify-frame) freezes buffer view under Wayland Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <b5a17ec6-345-9df5-f5d3-1f1c803d6e8c@gmail.com>
2022-09-25 12:33     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]       ` <d3757b8e-8699-fe39-3534-f01789bedaf@gmail.com>
2022-09-26  0:15         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]           ` <c128677a-64b0-ba6f-4a6-df9a3e02b61@gmail.com>
2022-09-27  0:25             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-28 15:06               ` Tino Calancha
2022-09-29  0:21                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-30 12:36                   ` Tino Calancha
2022-09-30 13:17                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-03 12:28                       ` Tino Calancha [this message]
2022-11-09 12:28                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 10:59                           ` Tino Calancha
2022-11-10 11:50                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 18:06 koaaa.outlook
2022-06-08  0:32 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 22:09   ` whainte
2022-06-20  0:51     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23  8:40       ` Lars Ingebrigtsen
2022-09-01 11:26         ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-02  9:31           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-03  4:46             ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-03  5:01               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]                 ` <166219690756.47038.8534222496369366592@localhost>
2022-09-04 11:01                   ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-04 12:50                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-05  9:57                       ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-05 14:08                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c31acde9-7f81-98f4-121-2ce3b78a5453@gmail.com \
    --to=tino.calancha@gmail.com \
    --cc=55836@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).