From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#55836: 29.0.50; (iconify-frame) freezes buffer view under Wayland. Date: Mon, 3 Oct 2022 14:28:11 +0200 (CEST) Message-ID: References: <871qrzbqv3.fsf@yahoo.com> <87wn9rab1g.fsf@yahoo.com> <87sfkf9ej5.fsf@yahoo.com> <87a66lacjv.fsf@yahoo.com> <874jwr6ndk.fsf@yahoo.com> <87bkqx57do.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34949"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55836@debbugs.gnu.org, Tino Calancha To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 03 14:32:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofKcW-0008vS-NY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 14:32:28 +0200 Original-Received: from localhost ([::1]:49364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofKcU-0005tq-S9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 08:32:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofKZE-0005sK-9H for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 08:29:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofKZC-0005bG-OU for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 08:29:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofKZC-00028Z-Bk for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 08:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 12:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55836 X-GNU-PR-Package: emacs Original-Received: via spool by 55836-submit@debbugs.gnu.org id=B55836.16648001128162 (code B ref 55836); Mon, 03 Oct 2022 12:29:02 +0000 Original-Received: (at 55836) by debbugs.gnu.org; 3 Oct 2022 12:28:32 +0000 Original-Received: from localhost ([127.0.0.1]:49258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofKYi-00027a-5x for submit@debbugs.gnu.org; Mon, 03 Oct 2022 08:28:32 -0400 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:38509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofKYg-00027L-9t for 55836@debbugs.gnu.org; Mon, 03 Oct 2022 08:28:30 -0400 Original-Received: by mail-wr1-f51.google.com with SMTP id j16so4553360wrh.5 for <55836@debbugs.gnu.org>; Mon, 03 Oct 2022 05:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:from:to:cc:subject:date; bh=DJoG2hHifcMUKnDnM6T3w5ZxbwpwaUki1W5Lz8DK6kE=; b=VBBy7yiqReSdEtTOA1TsWu47XyRd4ZhH3oO2DLJtkSH9DWsI3A7YKnAX/rNDJeTQzv pvYu4GK3atIq5dik4qqkCRd0W9gEptIqTZ19Bptlj47xRwJ/EmiwaqlG5rSzGMOcqcAc X2cSCv3a8gyNaK4+/1qkvo1ilxJCfwNdSisvOKKGtxr5OC9lpwbeyKIezdOTtg9PAfFa zBdCPoQAfV9BlUa8I7fsLkVCRr7fToJT96FRd0klUCJCtRnVGfBSwNtJs3I94wHru//X 7OvODm90wOXehPUoRClSjFgdUjAFtgbBurHA/soRCkDwZpS0y2I/QejUEPmYaVOfRp+8 IdiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date; bh=DJoG2hHifcMUKnDnM6T3w5ZxbwpwaUki1W5Lz8DK6kE=; b=7ftWx5B2RMuzkfFwJ7niTQ/4aMCgiHdAVyCM9qQ3t2l5ugkVpTYit5sQRVFrJP3BI+ e8x1sbEVojtlL0wgEMU4XKpYc8V5pUCEcWjGZNFxeXMsC8Z8TENeOJPwotNUfwn/yyae h9UEefHCy3/rv/tn2q4qJh7zP8XRZdPqWnqtJS+wRTfiCYI1GX21FJnxhT+IGGQPFzjZ 8T+69EydOAVk/NFdr01yfrduSvPab04QTdM9mZ8P0UCyROmBhI/oi8qNqciOXHQ/fgLx eCY2hRuwdIVFqk/LSzU00687A6wpDfu5iQvKZoXZyH9qCAdMX/OrmNpUgNOoLc0mcdSi LmLQ== X-Gm-Message-State: ACrzQf0XCvHqhwM10mywCNUh2VX0YNKDh5XPlbooGPSkRK0BeP6GM4ht q+7wekx7OwZFQlecbf6KV2U= X-Google-Smtp-Source: AMsMyM64aYuvGzmaekHRVSDVyujA0CHdEPmilSgwKETbpUYdpZJCiMsVVbig0sF8ScgmKzzv7z+ZYA== X-Received: by 2002:a5d:6741:0:b0:22e:2c5c:d611 with SMTP id l1-20020a5d6741000000b0022e2c5cd611mr6822257wrw.210.1664800103331; Mon, 03 Oct 2022 05:28:23 -0700 (PDT) Original-Received: from tcalanch.remote.csb ([193.118.249.171]) by smtp.gmail.com with ESMTPSA id u12-20020adfc64c000000b00225307f43fbsm10456104wrg.44.2022.10.03.05.28.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 05:28:22 -0700 (PDT) X-Google-Original-From: Tino Calancha In-Reply-To: <87bkqx57do.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244297 Archived-At: On Fri, 30 Sep 2022, Po Lu wrote: >> 1. The breakpoint at gdk_wayland_window_handle_configure is never reached. >> I have tried with both patches discussed above, and the master branch >> with no success: such breakpoint is not reached. It turned out I was missing some debugging symbols. Once iinstalled all the debugging symbols the breakpoint is reached as expected. >>> Could you install debug info for GDK, put breakpoints on both >>> window_state_event (in pgtkterm.c) and >>> gdk_wayland_window_handle_configure (in gdkwindow-wayland.c)? >> >>> Please see whether the former is called after the latter, and in doing >>> so clears the iconified flag? The iconified flag is cleared, but I cannot tell you where this happens. Of course, that prevents us to enter in the `if` branch at line 5472: if (FRAME_ICONIFIED_P (f)) My two fixes point to the `else` branch at line 5505: ``` if (new_state & GDK_WINDOW_STATE_ICONIFIED) SET_FRAME_ICONIFIED (f, true); else { FRAME_X_OUTPUT (f)->has_been_visible = true; inev.ie.kind = DEICONIFY_EVENT; XSETFRAME (inev.ie.frame_or_window, f); SET_FRAME_ICONIFIED (f, false); } ``` 1. The first one "extends" this branch by adding this line: SET_FRAME_VISIBLE (f, 1); 2. The second one just removes that `else` branch. Both seems to fix the issue in my Wayland session.