From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 55836@debbugs.gnu.org, "Lars Ingebrigtsen" <larsi@gnus.org>,
"Quách Mỹ Uyên Nhi" <uyennhi.qm@gmail.com>
Subject: bug#55836: 29.0.50; (iconify-frame) freezes buffer view under Wayland.
Date: Sun, 25 Sep 2022 20:06:24 +0800 [thread overview]
Message-ID: <871qrzbqv3.fsf@yahoo.com> (raw)
In-Reply-To: <c49677c5-8fe8-6038-7776-f42b5fba91e4@gmail.com> (Tino Calancha's message of "Sun, 25 Sep 2022 13:03:07 +0200 (CEST)")
Tino Calancha <tino.calancha@gmail.com> writes:
> We can reproduce the issue in our machine [1].
> The following patch works for us:
>
> commit 3f4aec4692b2e87bf69856b6d5870be46fd61f1e
> Fix Bug#55836
>
> * src/pgtkterm.c (window_state_event):
> Always set the frame visible when deiconifying it (Bug#55836).
>
> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
> index 491ba33882..4a62ca0e41 100644
> --- a/src/pgtkterm.c
> +++ b/src/pgtkterm.c
> @@ -5508,6 +5508,7 @@ window_state_event (GtkWidget *widget,
> inev.ie.kind = DEICONIFY_EVENT;
> XSETFRAME (inev.ie.frame_or_window, f);
> SET_FRAME_ICONIFIED (f, false);
>
> + SET_FRAME_VISIBLE (f, 1); /* Bug#55836 */
> }
>
> if (new_state & GDK_WINDOW_STATE_STICKY)
Is that on Wayland or X?
Note that the PGTK build does not support X anyway, but please try this:
diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 491ba33882..cb4351616e 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -6424,10 +6424,12 @@ pgtk_set_event_handler (struct frame *f)
G_CALLBACK (pgtk_handle_event), NULL);
g_signal_connect (G_OBJECT (FRAME_GTK_OUTER_WIDGET (f)), "configure-event",
G_CALLBACK (configure_event), NULL);
+
+ /* The map event always comes from the toplevel window. */
+ g_signal_connect (G_OBJECT (FRAME_GTK_OUTER_WIDGET (f)), "map-event",
+ G_CALLBACK (map_event), NULL);
}
- g_signal_connect (G_OBJECT (FRAME_GTK_WIDGET (f)), "map-event",
- G_CALLBACK (map_event), NULL);
g_signal_connect (G_OBJECT (FRAME_GTK_WIDGET (f)), "size-allocate",
G_CALLBACK (size_allocate), f);
g_signal_connect (G_OBJECT (FRAME_GTK_WIDGET (f)), "key-press-event",
next parent reply other threads:[~2022-09-25 12:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c49677c5-8fe8-6038-7776-f42b5fba91e4@gmail.com>
2022-09-25 12:06 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
[not found] ` <b5a17ec6-345-9df5-f5d3-1f1c803d6e8c@gmail.com>
2022-09-25 12:33 ` bug#55836: 29.0.50; (iconify-frame) freezes buffer view under Wayland Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <d3757b8e-8699-fe39-3534-f01789bedaf@gmail.com>
2022-09-26 0:15 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <c128677a-64b0-ba6f-4a6-df9a3e02b61@gmail.com>
2022-09-27 0:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-28 15:06 ` Tino Calancha
2022-09-29 0:21 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-30 12:36 ` Tino Calancha
2022-09-30 13:17 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-03 12:28 ` Tino Calancha
2022-11-09 12:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-10 10:59 ` Tino Calancha
2022-11-10 11:50 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-07 18:06 koaaa.outlook
2022-06-08 0:32 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-19 22:09 ` whainte
2022-06-20 0:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-07-23 8:40 ` Lars Ingebrigtsen
2022-09-01 11:26 ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-02 9:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-03 4:46 ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-03 5:01 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <166219690756.47038.8534222496369366592@localhost>
2022-09-04 11:01 ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-04 12:50 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-05 9:57 ` 夜坂雅 via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-05 14:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qrzbqv3.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=55836@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
--cc=tino.calancha@gmail.com \
--cc=uyennhi.qm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).