From: Dmitry Gutov <dmitry@gutov.dev>
To: Olivier Certner <ocert.dev@free.fr>, 62693@debbugs.gnu.org
Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it
Date: Thu, 13 Apr 2023 01:48:43 +0300 [thread overview]
Message-ID: <be94acde-23c8-44dc-aaf3-593472a44316@gutov.dev> (raw)
In-Reply-To: <2029306.bkXEbi1Pq8@ravel>
Hi! Thanks for the report.
On 06/04/2023 12:51, Olivier Certner wrote:
> When using CVS 1.12.3+, VC dir doesn't list correctly some missing file, including quotes produced by CVS in the file name, then preventing to operate on it. The fix works on all "recent" versions of CVS (1.11 and 1.12).
>
> Once this is fixed, it's still not possible to revert such a file yet since `vc-default-revert', called by `vc-cvs-revert', tries to backup the non-existing file (`copy-file' just fails).
>
> While here, fixed `vc-cvs-parse-root', which is not correctly reporting whether some repository is local.
>
> All three patches can be applied to 'master' directly (e579c9cc33d).
Regarding patches 1 and 3:
- Could you explain what kind of files are not listed and when? I'm
guessing this has to do with the file name? I've tried to reproduce the
problem with a file name that contained a space, and couldn't see it.
- Could you give an example of the repository CVS root which is
recognized by the current code incorrectly?
next prev parent reply other threads:[~2023-04-12 22:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 9:51 bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Olivier Certner
2023-04-12 22:48 ` Dmitry Gutov [this message]
2023-04-13 16:40 ` Olivier Certner
2023-04-14 22:59 ` Dmitry Gutov
2023-04-15 9:28 ` Eli Zaretskii
2023-04-17 9:24 ` Olivier Certner
2023-04-17 17:48 ` Eli Zaretskii
2023-04-17 20:10 ` Olivier Certner
2023-04-19 0:54 ` Dmitry Gutov
2023-04-19 8:10 ` Olivier Certner
2023-04-20 8:55 ` Eli Zaretskii
2023-04-20 9:42 ` Olivier Certner
2023-04-20 10:22 ` Dmitry Gutov
2023-04-17 8:04 ` Olivier Certner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be94acde-23c8-44dc-aaf3-593472a44316@gutov.dev \
--to=dmitry@gutov.dev \
--cc=62693@debbugs.gnu.org \
--cc=ocert.dev@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).