unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Olivier Certner <ocert.dev@free.fr>, Eli Zaretskii <eliz@gnu.org>
Cc: 62693-done@debbugs.gnu.org
Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it
Date: Wed, 19 Apr 2023 03:54:15 +0300	[thread overview]
Message-ID: <3f5b3502-95a1-26f2-3889-cb99eab05af7@gutov.dev> (raw)
In-Reply-To: <2020915.n1Ql7ez4OO@ravel>

Version: 30.1

On 17/04/2023 12:24, Olivier Certner wrote:
>>> Regarding the new patch, it's great to see the list of examples, but
>>> could you instead move it to a test or several inside
>>> test/lisp/vc/vc-cvs-tests.el? This file does not exist yet, but you can
>>> use vc-git-test.el as an example, in the same directory.
>> Yes, having a test for this would be most welcome.
> The examples in the commit messages have been removed and replaced by a test
> file.
> 
> New patch attached. The only new functional change is to test for an empty
> hostname in `vc-cvs-repository-hostname', in an attempt to make it easier for
> you to see that nothing can be broken as long as `vc-cvs-parse-root' works
> correctly. Compared to the old code, the new implementation can, on an
> *invalid*  CVS/Root specifications, return an empty hostname where the older
> would return nil (assuming a correct parsing case). This has no real practical
> consequences since 'cvs' commands are anyway bound to fail at a later point in
> such a case, but may reassure you about the innocuity of this change.

Very good, I've pushed the three patches to 'master'.

Thank you for your work, and closing.





  parent reply	other threads:[~2023-04-19  0:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06  9:51 bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Olivier Certner
2023-04-12 22:48 ` Dmitry Gutov
2023-04-13 16:40   ` Olivier Certner
2023-04-14 22:59     ` Dmitry Gutov
2023-04-15  9:28       ` Eli Zaretskii
2023-04-17  9:24         ` Olivier Certner
2023-04-17 17:48           ` Eli Zaretskii
2023-04-17 20:10             ` Olivier Certner
2023-04-19  0:54           ` Dmitry Gutov [this message]
2023-04-19  8:10             ` Olivier Certner
2023-04-20  8:55             ` Eli Zaretskii
2023-04-20  9:42               ` Olivier Certner
2023-04-20 10:22                 ` Dmitry Gutov
2023-04-17  8:04       ` Olivier Certner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f5b3502-95a1-26f2-3889-cb99eab05af7@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=62693-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=ocert.dev@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).