From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Date: Thu, 13 Apr 2023 01:48:43 +0300 Message-ID: References: <2029306.bkXEbi1Pq8@ravel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15488"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Olivier Certner , 62693@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 13 00:49:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmjH8-0003nm-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Apr 2023 00:49:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmjGy-0003U8-Uf; Wed, 12 Apr 2023 18:49:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmjGw-0003Tk-WE for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 18:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmjGw-0002mK-Ks for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmjGw-0003mQ-H7 for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 18:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 22:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62693 X-GNU-PR-Package: emacs Original-Received: via spool by 62693-submit@debbugs.gnu.org id=B62693.168133973614517 (code B ref 62693); Wed, 12 Apr 2023 22:49:02 +0000 Original-Received: (at 62693) by debbugs.gnu.org; 12 Apr 2023 22:48:56 +0000 Original-Received: from localhost ([127.0.0.1]:42056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmjGp-0003m5-IJ for submit@debbugs.gnu.org; Wed, 12 Apr 2023 18:48:55 -0400 Original-Received: from new1-smtp.messagingengine.com ([66.111.4.221]:56591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmjGm-0003lr-D6 for 62693@debbugs.gnu.org; Wed, 12 Apr 2023 18:48:54 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 37AA65827C1; Wed, 12 Apr 2023 18:48:46 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 12 Apr 2023 18:48:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681339726; x=1681343326; bh=xSFTieEM7ZO8GiEa2IWRrV1wI+Zg7M7vArR 9GQ0F0s8=; b=KR5ZJTQGyTlYx649wPdiVOlixJ+aLdP3z6NltnHzj9Csm8GKSjB 8YfSwMzRxVyNc9atR8TfTftayp44nZyjVCQP7LLqdeKrk1btmNcExnXkDx4lgL4f HBV00nupAvTOSTqSzeAXAok0w1r3NUX1jR5yP+9GU3KcLfXMkkPS6uIbApRhk9h/ MoKVqrP220hThDr4J9MM95kd9Tf6eBipxbWVWJ+9ifLk/tfbnAzW1eCl4A/MJpwy xj5uIYhUBx0Y/6USA/850OaiYvZ37Kq65sevD9Ri1vXzrRnSGhvEZ/LiCcvfXdqy Qk/dOgGSF3pyRtja50KTM9gLWfAHlw3clkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681339726; x= 1681343326; bh=xSFTieEM7ZO8GiEa2IWRrV1wI+Zg7M7vArR9GQ0F0s8=; b=h nucl2/eRKBlakn+d/X0l1sRHKlj9mi924Nb5q+Sw7Na49XlzpzUS07Y59NkRQnB3 IZ5GVZzxUafioY3AADsP+OGhemEeAO3XPJalITJWhjC7yhG7/wbt/0JcEahwud6m WBDYc3Wc5t4vvLrtXdQKu78qR5rRjhTbl8QMQreglRwwpEG2mnImgH+Iy/CgHVW5 OA/9xls4AwzvfJjda5bjO1yKZTFTm2vnahlLyLBd24elZbGCyKrP98/MpBBrtsn4 4JaaRSB+nQ+fBHlpSDYLWGvpmi45HcMdYvpY8qmyyrRabkw5iCiXpW729mgtXcRR HagEWv12XDkGgktrOkjUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekjedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhu thhovhdruggvvheqnecuggftrfgrthhtvghrnhepgeehtdehudejieetuedttdejkeehje etueekheffuddtjeeuvdefveeuveeiuddunecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Apr 2023 18:48:44 -0400 (EDT) Content-Language: en-US In-Reply-To: <2029306.bkXEbi1Pq8@ravel> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259818 Archived-At: Hi! Thanks for the report. On 06/04/2023 12:51, Olivier Certner wrote: > When using CVS 1.12.3+, VC dir doesn't list correctly some missing file, including quotes produced by CVS in the file name, then preventing to operate on it. The fix works on all "recent" versions of CVS (1.11 and 1.12). > > Once this is fixed, it's still not possible to revert such a file yet since `vc-default-revert', called by `vc-cvs-revert', tries to backup the non-existing file (`copy-file' just fails). > > While here, fixed `vc-cvs-parse-root', which is not correctly reporting whether some repository is local. > > All three patches can be applied to 'master' directly (e579c9cc33d). Regarding patches 1 and 3: - Could you explain what kind of files are not listed and when? I'm guessing this has to do with the file name? I've tried to reproduce the problem with a file name that contained a space, and couldn't see it. - Could you give an example of the repository CVS root which is recognized by the current code incorrectly?