From: Jim Porter <jporterbugs@gmail.com>
To: 60845@debbugs.gnu.org
Cc: gregory@heytings.org
Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)
Date: Sun, 22 Jan 2023 13:34:44 -0800 [thread overview]
Message-ID: <bbea0f18-f5d7-163d-a5d0-5d9a75a5894a@gmail.com> (raw)
In-Reply-To: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com>
X-Debbugs-CC: gregory@heytings.org
On 1/15/2023 5:50 PM, Jim Porter wrote:
> This is a followup from bug#60464 and friends. Over there, we discussed
> problems with Pcomplete when used from Eshell, namely that Eshell
> sometimes gives Pcomplete non-string arguments. I mentioned that we
> should probably have automated tests for the Eshell side so that we can
> make further improvements to Pcomplete without causing regressions, so
> here are some tests.
After studying how Eshell interfaces with Pcomplete, I think I've
convinced myself that Eshell should be the one responsible for
converting all its arguments to strings. It already does this for some
cases (nil becomes "", numbers are stringified, and ".../" forms become
"../../"), so the fact that it doesn't do this universally is probably a
bug.
The third patch in this series fixes this for the Eshell side, so we
could probably remove the workaround in pcomplete.el for Emacs 30.
next prev parent reply other threads:[~2023-01-22 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 1:50 bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Jim Porter
2023-01-22 21:34 ` Jim Porter [this message]
2023-01-22 21:35 ` Jim Porter
2023-01-30 7:14 ` Jim Porter
2023-01-30 14:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-31 2:00 ` Jim Porter
2023-09-05 23:36 ` Stefan Kangas
2023-09-06 0:47 ` Jim Porter
2023-09-06 1:37 ` Jim Porter
2023-10-10 20:07 ` Jim Porter
2023-10-10 21:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbea0f18-f5d7-163d-a5d0-5d9a75a5894a@gmail.com \
--to=jporterbugs@gmail.com \
--cc=60845@debbugs.gnu.org \
--cc=gregory@heytings.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).