From: Stefan Kangas <stefankangas@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 60845@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it)
Date: Tue, 5 Sep 2023 16:36:59 -0700 [thread overview]
Message-ID: <CADwFkm=GK8iXiFMng2rPpneLMs7F_jCOVw4YGG9z=FghvK_3og@mail.gmail.com> (raw)
In-Reply-To: <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> (Jim Porter's message of "Mon, 30 Jan 2023 18:00:33 -0800")
Jim Porter <jporterbugs@gmail.com> writes:
> On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss
> army knife of text editors wrote:
>> It sounds good to me, but I'm definitely not well versed in this aspect
>> of the interaction between Eshell and Pcomplete (more specifically,
>> this is a part of their interaction which I find quite tricky), so it's
>> good that you add corresponding regression tests.
>
> Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave
> this open though to discuss what to do about the Pcomplete side of things. I
> think we can remove the workaround for Emacs 29, but maybe we want some
> additional changes.
That was 9 months ago. Is it still relevant to keep this bug open?
> (It would also be nice to add some more Pcomplete support on the Eshell
> side. For example, when completing arguments to 'echo', Pcomplete shows options
> for the real /bin/echo, instead of showing options for the built-in function
> 'eshell/echo'.)
next prev parent reply other threads:[~2023-09-05 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 1:50 bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Jim Porter
2023-01-22 21:34 ` Jim Porter
2023-01-22 21:35 ` Jim Porter
2023-01-30 7:14 ` Jim Porter
2023-01-30 14:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-31 2:00 ` Jim Porter
2023-09-05 23:36 ` Stefan Kangas [this message]
2023-09-06 0:47 ` Jim Porter
2023-09-06 1:37 ` Jim Porter
2023-10-10 20:07 ` Jim Porter
2023-10-10 21:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=GK8iXiFMng2rPpneLMs7F_jCOVw4YGG9z=FghvK_3og@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=60845@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).