From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Sun, 22 Jan 2023 13:34:44 -0800 Message-ID: References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12451"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org To: 60845@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 22 22:35:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJhzl-000333-UY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Jan 2023 22:35:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJhzT-0002w3-OW; Sun, 22 Jan 2023 16:35:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJhzT-0002vp-49 for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 16:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJhzS-0006og-Qi for bug-gnu-emacs@gnu.org; Sun, 22 Jan 2023 16:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJhzS-0007i6-H7; Sun, 22 Jan 2023 16:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: gregory@heytings.org, bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jan 2023 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Xcc: gregory@heytings.org Original-Received: via spool by 60845-submit@debbugs.gnu.org id=B60845.167442329729625 (code B ref 60845); Sun, 22 Jan 2023 21:35:02 +0000 Original-Received: (at 60845) by debbugs.gnu.org; 22 Jan 2023 21:34:57 +0000 Original-Received: from localhost ([127.0.0.1]:52717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJhzN-0007hk-81 for submit@debbugs.gnu.org; Sun, 22 Jan 2023 16:34:57 -0500 Original-Received: from mail-pf1-f179.google.com ([209.85.210.179]:44913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJhzH-0007hO-Is for 60845@debbugs.gnu.org; Sun, 22 Jan 2023 16:34:55 -0500 Original-Received: by mail-pf1-f179.google.com with SMTP id w2so7451617pfc.11 for <60845@debbugs.gnu.org>; Sun, 22 Jan 2023 13:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=bSWjD9/YYS/D8aG7qObC/abTy04ZOStEUCrSxOYbLJc=; b=ALuimc7r0M/Qr58OT6uUMLWQYkFa1ebMrLwk+0ydMOTkahHM+lHr1yIPmeeMtUxsz4 yBr77xbAzCK7J0AYEqPv0f2HcVzF3R7NyYVUzJ5xh9ubNtZuEG3CKLsppGW3TU8kTDwI IhSIB2AiyzvP/B/upL3tJNagBgdDX+Tw+cXceR2gV7J4v5fK4Uk/MU9n6UkHCY0da8D5 Ia7ArriH5o1IszRBuB/fT+XAjAPhA6Dmqev5B7A5Od2SMlxTo0MDWcaS6FjF0yLXxZ3r Fgcg/igjx/8gI+lxwgBnJP8HLMfIw0/Vml1DpQNaCgk9qe09yBle6xfmVTQeXBzLl5S0 CMWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bSWjD9/YYS/D8aG7qObC/abTy04ZOStEUCrSxOYbLJc=; b=sabV+23ue4+nje9MWrqXnUkoPqH/CuPmhCoaDQFunG2FlzHyjPaSU4b3S6M1HkwiM3 Qg++qaDQ4ajIuWbwH7qPurN3k5Ck+V1B2PDkQn/XnitqezXQVVPZGh8TSNKvMnx5TvmD XZxZjl94XWVWi5fnfmpkbz/LXMPkxRHoN5ILJacDkYINQ9rYtejGVVC861KNBAzbl2qb cOIwuEE3R0R72Q7YFTbwSZ9epEOWNgbMMgWLCyns7Ex4rVCFgoU8OWNB67J5jiToG08O zG3RvZeW246Cncl/c7RNF/KyL9nVJ77svbFWSnESoXhzuLVJusr0BtyGpx8DkcmKLiM6 ADzQ== X-Gm-Message-State: AFqh2kp919/Le3yPn/Lg9jzruSaYGXBCENJe+31yyLCzFzRgvspPdmBR dpJZccLjdIY7kwdQasKOGQzAkG/R/e+UZQ== X-Google-Smtp-Source: AMrXdXv11+U4khVlbVhnyAle8LKS326iggeQ+0J6Xc8inj2xvf+PUs9oeC4N56TT53zj3t0z4nLZbw== X-Received: by 2002:a05:6a00:1496:b0:586:35dd:91c3 with SMTP id v22-20020a056a00149600b0058635dd91c3mr30785951pfu.29.1674423285609; Sun, 22 Jan 2023 13:34:45 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x65-20020a623144000000b0058ba6f416besm17061404pfx.183.2023.01.22.13.34.44 for <60845@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 13:34:45 -0800 (PST) Content-Language: en-US In-Reply-To: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253960 Archived-At: X-Debbugs-CC: gregory@heytings.org On 1/15/2023 5:50 PM, Jim Porter wrote: > This is a followup from bug#60464 and friends. Over there, we discussed > problems with Pcomplete when used from Eshell, namely that Eshell > sometimes gives Pcomplete non-string arguments. I mentioned that we > should probably have automated tests for the Eshell side so that we can > make further improvements to Pcomplete without causing regressions, so > here are some tests. After studying how Eshell interfaces with Pcomplete, I think I've convinced myself that Eshell should be the one responsible for converting all its arguments to strings. It already does this for some cases (nil becomes "", numbers are stringified, and ".../" forms become "../../"), so the fact that it doesn't do this universally is probably a bug. The third patch in this series fixes this for the Eshell side, so we could probably remove the workaround in pcomplete.el for Emacs 30.