bug#12670: 24.2.50; Uncustomizable defcustom

bug#12670: 24.2.50; Uncustomizable defcustom

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Hi,

I realized that a certain defcustom form is unable to customize
a user option.  To reproduce this, evaluate the following form,
perform M-x customize-option, and press the [INS] button.

(defcustom foo nil
  "Doc"
  :type '(repeat (group (group :inline t (choice string function)))))

Then you will find a funny thing there and see it is unable to
edit.  After some investigations I found this is due to
`widget-default-get', that fails to get the default value of
components within an inlined form (I mean (bar :inline t ...)).

A patch is attached, not tested with all sorts of defcustom
forms though.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: DIFF --]
[-- Type: text/x-patch, Size: 792 bytes --]

--- wid-edit.el~	2012-04-22 21:52:01.618551000 +0000
+++ wid-edit.el	2012-10-18 09:27:17.158803700 +0000
@@ -525,9 +525,18 @@
 (defun widget-default-get (widget)
   "Extract the default external value of WIDGET."
   (widget-apply widget :value-to-external
 		(or (widget-get widget :value)
-		    (widget-apply widget :default-get))))
+		    (progn
+		      (when (widget-get widget :args)
+			(let (args)
+			  (dolist (arg (widget-get widget :args))
+			    (setq args (append args
+					       (if (widget-get arg :inline)
+						   (widget-get arg :args)
+						 (list arg)))))
+			  (widget-put widget :args args)))
+		      (widget-apply widget :default-get)))))
 
 (defun widget-match-inline (widget vals)
   "In WIDGET, match the start of VALS."
   (cond ((widget-get widget :inline)

bug#12670: 24.2.50; Uncustomizable defcustom

[Chong Yidong]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> evaluate the following form, perform M-x customize-option, and press
> the [INS] button.
>
> (defcustom foo nil
>   "Doc"
>   :type '(repeat (group (group :inline t (choice string function)))))
>
> Then you will find a funny thing there and see it is unable to
> edit.

I can't reproduce this on Emacs 23.4, the emacs-24 branch, or trunk.
After opening the customization buffer for `foo', I click on INS and it
opens up

INS DEL Choice: Value Menu invalid (nil)

and clicking on "Value Menu" allows me to insert a function or string.

bug#12670: 24.2.50; Uncustomizable defcustom

[Katsumi Yamaoka]

Chong Yidong <cyd@gnu.org> wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> evaluate the following form, perform M-x customize-option, and press
>> the [INS] button.

>> (defcustom foo nil
>>   "Doc"
>>   :type '(repeat (group (group :inline t (choice string function)))))

>> Then you will find a funny thing there and see it is unable to
>> edit.

> I can't reproduce this on Emacs 23.4, the emacs-24 branch, or trunk.
> After opening the customization buffer for `foo', I click on INS and it
> opens up

> INS DEL Choice: Value Menu invalid (nil)

> and clicking on "Value Menu" allows me to insert a function or string.

Oops, you're right.  I don't recall why I said it's uncustomisable,
but please let me rephrase it:
That defcustom form is unable to suggest a default value, that's
the one suitable to beginners for example, to a user.  Could you
try the following two examples?  Both behaviors should be the same.
And my patch solves it.

(defcustom foo1 nil
  "Doc"
  :type '(repeat (group (group :inline t
			       (choice (string :value "foo")
				       function)))))
(defcustom foo2 nil
  "Doc"
  :type '(repeat (group (choice (string :value "foo")
				function))))

bug#12670: 24.2.50; Uncustomizable defcustom

[Chong Yidong]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Oops, you're right.  I don't recall why I said it's uncustomisable,
> but please let me rephrase it:
> That defcustom form is unable to suggest a default value, that's
> the one suitable to beginners for example, to a user.  Could you
> try the following two examples?  Both behaviors should be the same.
> And my patch solves it.

Ah, OK.  Looks fine to me, please go ahead and commit to trunk.

bug#12670: 24.2.50; Uncustomizable defcustom

[Katsumi Yamaoka]

Chong Yidong wrote:
> Ah, OK.  Looks fine to me, please go ahead and commit to trunk.

Thanks.  Done.