From: martin rudalics <rudalics@gmx.at>
To: Boruch Baum <boruch_baum@gmx.com>, 48408@debbugs.gnu.org
Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string
Date: Fri, 14 May 2021 09:09:38 +0200 [thread overview]
Message-ID: <a49a11d1-6f63-c7b1-31ef-5b49c6e24682@gmx.at> (raw)
In-Reply-To: <20210514011519.vsy5jbhyxd4v6kpt@E15-2016.optimum.net>
> In package windows.el, function `window-default-font-height' calls
> function `face-font', which can return a nil value, but performs a
> `string-equal' operation on the output without checking for that
> possibiliy.
Please report this to the author(s) of that package.
> I came across this in an unusual case, of having an 'emacs -nw' server
> an 'emacsclient -nw', and opening a GUI emacsclient to connect to it.
> From that point forward until the fix, every *second* attempt to use the
> minibuffer on the 'emacsclient -nw' would fail.
>
> The fix I'm using is:
>
> (if (and (display-multi-font-p (frame-parameter frame 'display))
> (stringp default-font) ; <<<---!!!
What is `default-font'?
> (not (string-equal (frame-parameter frame 'font) default-font)))
>
> But there could be other considerations to performing things in another way.
martin
next prev parent reply other threads:[~2021-05-14 7:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 1:15 bug#48408: BUGFIX: window-default-font-height: check for nil string Boruch Baum
2021-05-14 6:39 ` Eli Zaretskii
2021-05-16 3:06 ` Boruch Baum
2021-05-16 4:22 ` Eli Zaretskii
2021-05-16 4:42 ` Boruch Baum
2021-05-16 5:25 ` Eli Zaretskii
2021-05-16 6:05 ` Boruch Baum
2021-05-16 6:32 ` Eli Zaretskii
2021-05-16 6:29 ` Eli Zaretskii
[not found] ` <20210516065904.5wweuipi23oy5g2x@E15-2016.optimum.net>
2021-05-16 8:30 ` Eli Zaretskii
2021-05-16 8:35 ` martin rudalics
2021-05-16 8:56 ` Eli Zaretskii
2021-05-16 9:08 ` Eli Zaretskii
2021-05-16 9:28 ` martin rudalics
2021-05-16 9:36 ` Eli Zaretskii
2021-05-19 4:00 ` Boruch Baum
2021-05-19 7:45 ` martin rudalics
2021-05-19 10:39 ` Boruch Baum
2021-05-19 11:29 ` Eli Zaretskii
2021-05-19 11:55 ` Boruch Baum
2021-05-19 14:17 ` Eli Zaretskii
2021-05-19 16:01 ` Eli Zaretskii
2022-07-12 22:59 ` Lars Ingebrigtsen
2021-05-16 8:31 ` martin rudalics
2021-05-14 7:09 ` martin rudalics [this message]
2021-05-14 7:15 ` martin rudalics
2021-05-14 7:26 ` Eli Zaretskii
2021-05-14 8:15 ` martin rudalics
2021-05-14 10:45 ` Eli Zaretskii
2021-05-16 3:11 ` Boruch Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a49a11d1-6f63-c7b1-31ef-5b49c6e24682@gmx.at \
--to=rudalics@gmx.at \
--cc=48408@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).