From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string Date: Fri, 14 May 2021 09:09:38 +0200 Message-ID: References: <20210514011519.vsy5jbhyxd4v6kpt@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6137"; mail-complaints-to="usenet@ciao.gmane.io" To: Boruch Baum , 48408@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 14 09:10:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lhRy2-0001W3-HQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 09:10:38 +0200 Original-Received: from localhost ([::1]:42914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhRy1-0007WO-Kj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 May 2021 03:10:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhRxS-00077n-Gy for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 03:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhRxS-0000zv-9g for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 03:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhRxS-0006rN-51 for bug-gnu-emacs@gnu.org; Fri, 14 May 2021 03:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 May 2021 07:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48408 X-GNU-PR-Package: emacs Original-Received: via spool by 48408-submit@debbugs.gnu.org id=B48408.162097618726336 (code B ref 48408); Fri, 14 May 2021 07:10:02 +0000 Original-Received: (at 48408) by debbugs.gnu.org; 14 May 2021 07:09:47 +0000 Original-Received: from localhost ([127.0.0.1]:44820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhRxD-0006qi-2D for submit@debbugs.gnu.org; Fri, 14 May 2021 03:09:47 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:54341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhRxB-0006qT-1w for 48408@debbugs.gnu.org; Fri, 14 May 2021 03:09:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620976179; bh=QM86YQtnGFCPfPhtgkI1vzBJydFFMpkjnDwNt3BBunc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=BSvBrjYb683Ir9xxIHmax+zG+CQk7YuQrXRWiXRonKMvW3utELTiaz1BJssPLdcSU eZYgIa45UoThxowHocKUf8zUrL0v8gzQ29cidwzmYE7SqbEhSJQr/8siAgmd1+vXyY V9F9LeFzaC171D0Rz6pP9D8Q0nvADEBJB03ya6i0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.218]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mq2j2-1lCDiq44iQ-00n8Pl; Fri, 14 May 2021 09:09:39 +0200 In-Reply-To: <20210514011519.vsy5jbhyxd4v6kpt@E15-2016.optimum.net> Content-Language: en-US X-Provags-ID: V03:K1:M8u/b702adv8G+Y7gGY56RkpghH+Ytysb2/MJrspkxHhCt1NDAw Gr7Cb7lsfbt4j7uaDWRL/csv7EYFXUaGwXqQCMFP6IGnHdljssaebGe0TF2B2fQC+5hgWHR yAc4DSNTuKnwk9sxQ73JsOOpHFqzywgfLGMWJVOjfsuTLeetWVA2e4fhzlb2CdvxUAHyC7L sUrPH3xBeGN5VRkb9w2aQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:aGVrtbCndLo=:rApgsi5JPd5Hq1PIDNk/Uh G5ahVKvlO4N82s+6GlRCh7ZytH4dB8BG7FsVei1y2MZlRtZbYmMkzWNKY1Rt+jXuuiCBsuPI4 9WKFEdR8aFNRYkZPTIItJ3CuAyC+Fn89sSfUE73RvBjdhKuYa6b4N0yahZCeyfSAxC93SfHJJ fLdWX1yyZl5OryJiuG42vYBp5Zm3lkHVni4Zlctb6Q1p+sDa1VHNnk9DIgKuRdhPmRHVH/nUH iMIYsmU1NXKJStPfkwtyRnLmg9VJRJc16cvB8yBXRSLA40w+sXejxHeTnAxC1wI6PAjw850AC IXmbKmoscXgW5Op9H4dFSHOBQsARh7LvMcmXLGt6vliAeXM94uoBcqODkmXo+3zY+izDZE8Dj QxD9ibmNi+vaEZtrae3UXYgZieSQp6KV3wq8lAQkbcGiNzmpMb+WV06zF15lS/Z2xt4RUIwYk bKKIDKxH9FjCv46i2+sgSw4TzcuYT3U3ERkce8F5+yjZ+13+aIn91edHsZQxr7tNOjQK5EYSX HUFc+vO4PHhLabxwneFX7prKZZt3+x4ZyraHIRK7zJ8PIfRGNXh5p2LL+0tkcuFYDoib32AXN WrSUktC1uwQ8Pv+IDPJhRmbWV8YWRkgy0xE1E8rqyYvZzTO9TrPudklBILgjfd1ZTLrMUGVTf eP8rzFzLJ/wejQ6GFQRvbcLb5YiuXfbiPcDu4AxmLVHodzwapCT96fSlhkZ2w5YRcv7cqToYv Cm8rxfzxE7nDdhgyLvH2K0kAPxSAkNwKOv9p/YIYe1hhJ8sK4GajVgdJe1w5dVSQhyuPu1zn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206487 Archived-At: > In package windows.el, function `window-default-font-height' calls > function `face-font', which can return a nil value, but performs a > `string-equal' operation on the output without checking for that > possibiliy. Please report this to the author(s) of that package. > I came across this in an unusual case, of having an 'emacs -nw' server > an 'emacsclient -nw', and opening a GUI emacsclient to connect to it. > From that point forward until the fix, every *second* attempt to use the > minibuffer on the 'emacsclient -nw' would fail. > > The fix I'm using is: > > (if (and (display-multi-font-p (frame-parameter frame 'display)) > (stringp default-font) ; <<<---!!! What is `default-font'? > (not (string-equal (frame-parameter frame 'font) default-font))) > > But there could be other considerations to performing things in another way. martin