From: Eli Zaretskii <eliz@gnu.org>
To: rudalics@gmx.at
Cc: boruch_baum@gmx.com, 48408@debbugs.gnu.org
Subject: bug#48408: BUGFIX: window-default-font-height: check for nil string
Date: Sun, 16 May 2021 12:08:59 +0300 [thread overview]
Message-ID: <83im3jujtg.fsf@gnu.org> (raw)
In-Reply-To: <83lf8fukdu.fsf@gnu.org> (message from Eli Zaretskii on Sun, 16 May 2021 11:56:45 +0300)
> Date: Sun, 16 May 2021 11:56:45 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: boruch_baum@gmx.com, 48408@debbugs.gnu.org
>
> > OK. But was Boruch's original idea just checking for
> >
> > (stringp default-font)
> >
> > worse?
>
> I'm asking for your opinion about that ;-)
Actually, no, I do have an opinion on that: face-font can return a
string even on a TTY frame, at least in a build --without-x. (Which
seems to be an inconsistency in and of itself, btw.)
In general, trusting frame parameters too much is IME not a good idea,
as they are too loosely defined.
next prev parent reply other threads:[~2021-05-16 9:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 1:15 bug#48408: BUGFIX: window-default-font-height: check for nil string Boruch Baum
2021-05-14 6:39 ` Eli Zaretskii
2021-05-16 3:06 ` Boruch Baum
2021-05-16 4:22 ` Eli Zaretskii
2021-05-16 4:42 ` Boruch Baum
2021-05-16 5:25 ` Eli Zaretskii
2021-05-16 6:05 ` Boruch Baum
2021-05-16 6:32 ` Eli Zaretskii
2021-05-16 6:29 ` Eli Zaretskii
[not found] ` <20210516065904.5wweuipi23oy5g2x@E15-2016.optimum.net>
2021-05-16 8:30 ` Eli Zaretskii
2021-05-16 8:35 ` martin rudalics
2021-05-16 8:56 ` Eli Zaretskii
2021-05-16 9:08 ` Eli Zaretskii [this message]
2021-05-16 9:28 ` martin rudalics
2021-05-16 9:36 ` Eli Zaretskii
2021-05-19 4:00 ` Boruch Baum
2021-05-19 7:45 ` martin rudalics
2021-05-19 10:39 ` Boruch Baum
2021-05-19 11:29 ` Eli Zaretskii
2021-05-19 11:55 ` Boruch Baum
2021-05-19 14:17 ` Eli Zaretskii
2021-05-19 16:01 ` Eli Zaretskii
2022-07-12 22:59 ` Lars Ingebrigtsen
2021-05-16 8:31 ` martin rudalics
2021-05-14 7:09 ` martin rudalics
2021-05-14 7:15 ` martin rudalics
2021-05-14 7:26 ` Eli Zaretskii
2021-05-14 8:15 ` martin rudalics
2021-05-14 10:45 ` Eli Zaretskii
2021-05-16 3:11 ` Boruch Baum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83im3jujtg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48408@debbugs.gnu.org \
--cc=boruch_baum@gmx.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).