bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW

bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW

[Randy Taylor]

[-- Attachment #1.1: Type: text/plain, Size: 162 bytes --]

X-Debbugs-CC: casouri@gmail.com

See attached patch.

I think there was a bug report about supporting building tree-sitter modules on Windows but I can't find it.

[-- Attachment #1.2: Type: text/html, Size: 952 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-support-for-building-tree-sitter-modules-with-Mi.patch --]
[-- Type: text/x-patch; name=0001-Add-support-for-building-tree-sitter-modules-with-Mi.patch, Size: 1024 bytes --]

From 23750a5d35a8be6762cdbc7650afdbda3755267b Mon Sep 17 00:00:00 2001
From: Randy Taylor <dev@rjt.dev>
Date: Thu, 19 Jan 2023 09:16:55 -0500
Subject: [PATCH] Add support for building tree-sitter modules with MinGW

* admin/notes/tree-sitter/build-module/build.sh: Add support for
building tree-sitter modules with MinGW.
---
 admin/notes/tree-sitter/build-module/build.sh | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
index f0962940287..9dc674237ca 100755
--- a/admin/notes/tree-sitter/build-module/build.sh
+++ b/admin/notes/tree-sitter/build-module/build.sh
@@ -3,12 +3,17 @@
 lang=$1
 topdir="$PWD"
 
-if [ $(uname) == "Darwin" ]
-then
-    soext="dylib"
-else
-    soext="so"
-fi
+case $(uname) in
+    "Darwin")
+        soext="dylib"
+        ;;
+    *"MINGW"*)
+        soext="dll"
+        ;;
+    *)
+        soext="so"
+        ;;
+esac
 
 echo "Building ${lang}"
 
-- 
2.39.1

bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW

[Randy Taylor]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

> On Thursday, January 19th, 2023 at 09:28, Randy Taylor <dev@rjt.dev> wrote:
>
> X-Debbugs-CC: casouri@gmail.com
>
>See attached patch.
>
>I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.

Ping.

[-- Attachment #2: Type: text/html, Size: 1540 bytes --]

bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW

[Yuan Fu]

> On Jan 24, 2023, at 5:42 PM, Randy Taylor <dev@rjt.dev> wrote:
> 
> > On Thursday, January 19th, 2023 at 09:28, Randy Taylor <dev@rjt.dev> wrote:
> >
> > X-Debbugs-CC: casouri@gmail.com
> >
> >See attached patch.
> >
> >I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.
> 
> Ping.

Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure.

Yuan

bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW

[Eli Zaretskii]

> Cc: 60945@debbugs.gnu.org
> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 24 Jan 2023 19:08:16 -0800
> 
> 
> 
> > On Jan 24, 2023, at 5:42 PM, Randy Taylor <dev@rjt.dev> wrote:
> > 
> > > On Thursday, January 19th, 2023 at 09:28, Randy Taylor <dev@rjt.dev> wrote:
> > >
> > > X-Debbugs-CC: casouri@gmail.com
> > >
> > >See attached patch.
> > >
> > >I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.
> > 
> > Ping.
> 
> Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure.

I indeed think that maintaining this script in admin is no longer
worth our while, since we have the treesit-install-langauge-grammar
command, which is both more portable and convenient, and doesn't need
a Posix shell to run.

bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW

[Randy Taylor]

On Tuesday, January 24th, 2023 at 22:08, Yuan Fu <casouri@gmail.com> wrote:
> 
> > On Jan 24, 2023, at 5:42 PM, Randy Taylor dev@rjt.dev wrote:
> > 
> > > On Thursday, January 19th, 2023 at 09:28, Randy Taylor dev@rjt.dev wrote:
> > > 
> > > X-Debbugs-CC: casouri@gmail.com
> > > 
> > > See attached patch.
> > > 
> > > I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it.
> > 
> > Ping.
> 
> 
> Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure.
> 
> Yuan

Thanks, closing this. I plan to try out that new functionality sometime next week.