From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60945: [PATCH] Add support for building tree-sitter modules with MinGW Date: Wed, 25 Jan 2023 14:23:21 +0200 Message-ID: <83zga6g5vq.fsf@gnu.org> References: <81D8FD6F-DA72-4836-9305-33C00E501B1F@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14038"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dev@rjt.dev, 60945@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 13:24:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKepa-0003Rz-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 13:24:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKepD-0007fx-Or; Wed, 25 Jan 2023 07:24:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKeow-0007Zb-91 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 07:24:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKeos-0001Lf-7h for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 07:24:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKeos-0003jC-0n for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 07:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 12:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60945-submit@debbugs.gnu.org id=B60945.167464940514273 (code B ref 60945); Wed, 25 Jan 2023 12:24:01 +0000 Original-Received: (at 60945) by debbugs.gnu.org; 25 Jan 2023 12:23:25 +0000 Original-Received: from localhost ([127.0.0.1]:58540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKeoH-0003i9-9H for submit@debbugs.gnu.org; Wed, 25 Jan 2023 07:23:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKeoF-0003hv-9S for 60945@debbugs.gnu.org; Wed, 25 Jan 2023 07:23:24 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKeo4-0001DJ-23; Wed, 25 Jan 2023 07:23:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/zrTM535xR13neOmZesIMF5MBHmD5I9Wz4vs1hObm+Y=; b=TX1MVy19f0eN n7aZpCI2/2NoZZk/bUY3QYXJhrZEMf1j77wbW04UnZWVdJJA7zTZ09fD8TAevrojw+zbDlCF/Ubs0 uL3tqsRrTJJErAmv2mdwk2GW4hzGFsO6gfqBBDPCiK1ipTSZJLhoamjO1a5DA5mA4Ix3vIoMNelGV s58y85eXnHD6P5+SrjcffSMx93pZshhDAX4pFub7Pp8RruLLcTDUEif1xIqlKGUVGgwW05j6g4iLA nHVceQnp0E6D4Z11XN9yqTopEGuG3I2hUq/IM505Rx6KdL3MWlm+f7QHDwvgQ7nVQomg88gMtX7AS vaErA6Xu7+f2Xxkkyzzq5g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKeo0-0005H2-17; Wed, 25 Jan 2023 07:23:09 -0500 In-Reply-To: <81D8FD6F-DA72-4836-9305-33C00E501B1F@gmail.com> (message from Yuan Fu on Tue, 24 Jan 2023 19:08:16 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254117 Archived-At: > Cc: 60945@debbugs.gnu.org > From: Yuan Fu > Date: Tue, 24 Jan 2023 19:08:16 -0800 > > > > > On Jan 24, 2023, at 5:42 PM, Randy Taylor wrote: > > > > > On Thursday, January 19th, 2023 at 09:28, Randy Taylor wrote: > > > > > > X-Debbugs-CC: casouri@gmail.com > > > > > >See attached patch. > > > > > >I think there was a bug report about supporting building tree-sitter modules on >Windows but I can't find it. > > > > Ping. > > Thanks, I applied it. Treesit-install-langauge-grammar should already handle windows, if all the difference is the extension, but someone with a Windows could give it a try and see, so we know for sure. I indeed think that maintaining this script in admin is no longer worth our while, since we have the treesit-install-langauge-grammar command, which is both more portable and convenient, and doesn't need a Posix shell to run.