From: Alan Mackenzie <acm@muc.de>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: acm@muc.de, Lars Ingebrigtsen <larsi@gnus.org>, 54990@debbugs.gnu.org
Subject: bug#54990: Byte compiler bug
Date: Wed, 20 Apr 2022 19:33:41 +0000 [thread overview]
Message-ID: <YmBgFdkboHkUvEsU@ACM> (raw)
In-Reply-To: <1417691E-D86C-4318-9320-BA5B0E162C55@acm.org>
Hello, Mattias.
On Mon, Apr 18, 2022 at 17:43:46 +0200, Mattias Engdegård wrote:
> 18 apr. 2022 kl. 12.48 skrev Alan Mackenzie <acm@muc.de>:
> > I've committed a fix, which I'm pretty sure works, so I'm closing the bug
> > with this post.
> Very happy to see that you found a solution quickly!
> A few items of concern:
> 1. There should be a regression test for it -- don't you agree?
I suppose so.
> 2. Your solution comprises stripping position from symbols during the
> lowering of lapcode to bytecode.
Yes. It preserves symbols' positions as long as possible.
> Why did this bug only affect `compile-defun`, not `byte-compile` or
> `byte-compile-file`? The change is in code common to all three.
Yes, I find that intriguing, too. I'm meaning to try to find out why
that was the case. The first priority was to fix the bug. The
differences between the ways the compiler was called might hide further
bugs, though.
So, I haven't forgotten this.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2022-04-20 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 12:31 bug#54990: Byte compiler bug Alan Mackenzie
2022-04-17 13:02 ` Lars Ingebrigtsen
2022-04-17 13:53 ` Alan Mackenzie
2022-04-17 14:32 ` Mattias Engdegård
2022-04-18 10:48 ` Alan Mackenzie
2022-04-18 15:43 ` Mattias Engdegård
2022-04-20 19:33 ` Alan Mackenzie [this message]
2022-04-21 9:49 ` Alan Mackenzie
2022-05-02 13:45 ` Mattias Engdegård
2022-05-02 18:46 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmBgFdkboHkUvEsU@ACM \
--to=acm@muc.de \
--cc=54990@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).