From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#54990: Byte compiler bug Date: Wed, 20 Apr 2022 19:33:41 +0000 Message-ID: References: <1417691E-D86C-4318-9320-BA5B0E162C55@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19508"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, Lars Ingebrigtsen , 54990@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 20 21:57:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhGS1-0004rj-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Apr 2022 21:57:21 +0200 Original-Received: from localhost ([::1]:51950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhGS0-0004vG-62 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Apr 2022 15:57:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhG5T-0005pA-DW for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2022 15:34:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhG5S-0005yw-PR for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2022 15:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nhG5S-0001U4-Eu for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2022 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Apr 2022 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54990 X-GNU-PR-Package: emacs Original-Received: via spool by 54990-submit@debbugs.gnu.org id=B54990.16504832315680 (code B ref 54990); Wed, 20 Apr 2022 19:34:02 +0000 Original-Received: (at 54990) by debbugs.gnu.org; 20 Apr 2022 19:33:51 +0000 Original-Received: from localhost ([127.0.0.1]:47544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhG5G-0001TY-Pd for submit@debbugs.gnu.org; Wed, 20 Apr 2022 15:33:50 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:54828 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1nhG5F-0001TI-Af for 54990@debbugs.gnu.org; Wed, 20 Apr 2022 15:33:49 -0400 Original-Received: (qmail 83786 invoked by uid 3782); 20 Apr 2022 19:33:42 -0000 Original-Received: from acm.muc.de (p4fe15b88.dip0.t-ipconnect.de [79.225.91.136]) (using STARTTLS) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 20 Apr 2022 21:33:41 +0200 Original-Received: (qmail 8837 invoked by uid 1000); 20 Apr 2022 19:33:41 -0000 Content-Disposition: inline In-Reply-To: <1417691E-D86C-4318-9320-BA5B0E162C55@acm.org> X-Submission-Agent: TMDA/1.3.x (Ph3nix) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230335 Archived-At: Hello, Mattias. On Mon, Apr 18, 2022 at 17:43:46 +0200, Mattias Engdegård wrote: > 18 apr. 2022 kl. 12.48 skrev Alan Mackenzie : > > I've committed a fix, which I'm pretty sure works, so I'm closing the bug > > with this post. > Very happy to see that you found a solution quickly! > A few items of concern: > 1. There should be a regression test for it -- don't you agree? I suppose so. > 2. Your solution comprises stripping position from symbols during the > lowering of lapcode to bytecode. Yes. It preserves symbols' positions as long as possible. > Why did this bug only affect `compile-defun`, not `byte-compile` or > `byte-compile-file`? The change is in code common to all three. Yes, I find that intriguing, too. I'm meaning to try to find out why that was the case. The first priority was to fix the bug. The differences between the ways the compiler was called might hide further bugs, though. So, I haven't forgotten this. -- Alan Mackenzie (Nuremberg, Germany).