unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Alan Mackenzie <acm@muc.de>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 54990-done@debbugs.gnu.org
Subject: bug#54990: Byte compiler bug
Date: Mon, 18 Apr 2022 17:43:46 +0200	[thread overview]
Message-ID: <1417691E-D86C-4318-9320-BA5B0E162C55@acm.org> (raw)
In-Reply-To: <Yl1CCxxxwpCt3nIJ@ACM>

18 apr. 2022 kl. 12.48 skrev Alan Mackenzie <acm@muc.de>:

> I've committed a fix, which I'm pretty sure works, so I'm closing the bug
> with this post.

Very happy to see that you found a solution quickly!

A few items of concern:

1. There should be a regression test for it -- don't you agree?

2. Your solution comprises stripping position from symbols during the lowering of lapcode to bytecode. Why did this bug only affect `compile-defun`, not `byte-compile` or `byte-compile-file`? The change is in code common to all three.






  reply	other threads:[~2022-04-18 15:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 12:31 bug#54990: Byte compiler bug Alan Mackenzie
2022-04-17 13:02 ` Lars Ingebrigtsen
2022-04-17 13:53   ` Alan Mackenzie
2022-04-17 14:32 ` Mattias Engdegård
2022-04-18 10:48   ` Alan Mackenzie
2022-04-18 15:43     ` Mattias Engdegård [this message]
2022-04-20 19:33       ` Alan Mackenzie
2022-04-21  9:49         ` Alan Mackenzie
2022-05-02 13:45           ` Mattias Engdegård
2022-05-02 18:46             ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417691E-D86C-4318-9320-BA5B0E162C55@acm.org \
    --to=mattiase@acm.org \
    --cc=54990-done@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).