From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: contact@jimeh.me, 49271@debbugs.gnu.org
Subject: bug#49271: 28.0.50: native-comp: Signing macOS self-contained .app bundle fails due to new *.eln location
Date: Thu, 1 Jul 2021 20:56:51 +0100 [thread overview]
Message-ID: <YN4eA8NAt5Y3LtX5@breton.holly.idiocy.org> (raw)
In-Reply-To: <83y2apkgb6.fsf@gnu.org>
On Thu, Jul 01, 2021 at 10:03:09PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 1 Jul 2021 19:45:46 +0100
> > From: Alan Third <alan@idiocy.org>
> > Cc: contact@jimeh.me, 49271@debbugs.gnu.org
> >
> > > It should work, although I'd prefer writing such code the other way
> > > around: first create an uninitialized Lisp string (with
> > > make_uninit_multibyte_string or make_uninit_string), then copy the
> > > bytes while making the conversions. The reason for this preference is
> > > that you could then make sure the produced string has the same
> > > multibyte-ness as the original, whereas the way you did it relies on
> > > whatever build_string decides, which is not necessarily the same.
> >
> > Thanks. I think the attached is doing what you suggested.
>
> Yes. But I think you can simplify (and make it a tad faster) if you
> just copy bytes in either case. Since a multibyte string is
> represented by a superset of UTF-8, you are guaranteed that no
> multibyte sequence will ever include '.'. So converting from
> multibyte sequences to characters and back, as well as calls to
> string_char_advance, can be avoided.
I'm glad I asked about this because I had completely misunderstood how
multibyte strings are represented. This makes a lot more sense.
Thanks!
--
Alan Third
next prev parent reply other threads:[~2021-07-01 19:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 11:58 bug#49271: 28.0.50: native-comp: Signing macOS self-contained .app bundle fails due to new *.eln location Jim Myhrberg
2021-06-29 19:18 ` Alan Third
2021-06-30 10:04 ` Jim Myhrberg
2021-06-30 12:20 ` Eli Zaretskii
2021-06-30 12:39 ` Jim Myhrberg
2021-06-30 12:52 ` Alan Third
2021-06-30 13:10 ` Jim Myhrberg
2021-06-30 19:05 ` Alan Third
2021-07-01 7:13 ` Eli Zaretskii
2021-07-01 18:45 ` Alan Third
2021-07-01 19:03 ` Eli Zaretskii
2021-07-01 19:56 ` Alan Third [this message]
2021-07-01 14:53 ` Jim Myhrberg
2021-07-01 20:13 ` Alan Third
2021-07-01 20:43 ` Jim Myhrberg
2021-07-01 21:16 ` Alan Third
2021-06-30 12:42 ` Alan Third
2021-06-30 12:51 ` Jim Myhrberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YN4eA8NAt5Y3LtX5@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=49271@debbugs.gnu.org \
--cc=contact@jimeh.me \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).