From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#49271: 28.0.50: native-comp: Signing macOS self-contained .app bundle fails due to new *.eln location Date: Thu, 1 Jul 2021 20:56:51 +0100 Message-ID: References: <83zgv7mtly.fsf@gnu.org> <83v95uld6n.fsf@gnu.org> <83y2apkgb6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6461"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contact@jimeh.me, 49271@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 01 21:58:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lz2pE-0001Wi-Go for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jul 2021 21:58:16 +0200 Original-Received: from localhost ([::1]:50832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lz2pD-00081p-Fq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Jul 2021 15:58:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lz2p0-00080P-F2 for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50429) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lz2oz-0008HR-OY for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lz2oz-00049i-OJ for bug-gnu-emacs@gnu.org; Thu, 01 Jul 2021 15:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 19:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49271 X-GNU-PR-Package: emacs Original-Received: via spool by 49271-submit@debbugs.gnu.org id=B49271.162516942315911 (code B ref 49271); Thu, 01 Jul 2021 19:58:01 +0000 Original-Received: (at 49271) by debbugs.gnu.org; 1 Jul 2021 19:57:03 +0000 Original-Received: from localhost ([127.0.0.1]:33742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz2o3-00048Y-HH for submit@debbugs.gnu.org; Thu, 01 Jul 2021 15:57:03 -0400 Original-Received: from outbound.soverin.net ([116.202.126.228]:47513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz2o1-00047d-Dj for 49271@debbugs.gnu.org; Thu, 01 Jul 2021 15:57:02 -0400 Original-Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 261898D5; Thu, 1 Jul 2021 19:56:55 +0000 (UTC) Original-Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1625169414; bh=gX/RgrWYViK3AWRpVOlWcQINJAMvGyczA/Q3wu7zEz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nAm9kU5Zs87tgDvYm53Zc3mmBkb0d1TzwY0JE1R0z2nIoEBTwp/FmNS+gueegrmqz WJ7Pnuqqt1O3NdQjlZ0+XxFOKMVv/EDnS1jg8B6WQD6WkMWsBrgltqiCkpptndPVtG OmhS5SGo2RWn+E6/cV6PpSuRzqE9DjRpLINN+aGJmhHoPKzZBmhdx+Iw0WtJKpDw+N jCHS+kk29wNZB6KXnaQq3/5NPEpRGFpfeeVzlfz/Ch4eZLeuTkoNuvgNVTLpNixwks jhwPy/x+M3lLKAMR2CBw8blLJAwucF8J8Q1kccnRekDvGTU35a04jnltfvNz/q4NBN 4NBK0mW13Oq+w== Original-Received: by breton.holly.idiocy.org (Postfix, from userid 501) id EDA3D202CDF43C; Thu, 1 Jul 2021 20:56:51 +0100 (BST) Mail-Followup-To: Alan Third , Eli Zaretskii , contact@jimeh.me, 49271@debbugs.gnu.org Content-Disposition: inline In-Reply-To: <83y2apkgb6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209287 Archived-At: On Thu, Jul 01, 2021 at 10:03:09PM +0300, Eli Zaretskii wrote: > > Date: Thu, 1 Jul 2021 19:45:46 +0100 > > From: Alan Third > > Cc: contact@jimeh.me, 49271@debbugs.gnu.org > > > > > It should work, although I'd prefer writing such code the other way > > > around: first create an uninitialized Lisp string (with > > > make_uninit_multibyte_string or make_uninit_string), then copy the > > > bytes while making the conversions. The reason for this preference is > > > that you could then make sure the produced string has the same > > > multibyte-ness as the original, whereas the way you did it relies on > > > whatever build_string decides, which is not necessarily the same. > > > > Thanks. I think the attached is doing what you suggested. > > Yes. But I think you can simplify (and make it a tad faster) if you > just copy bytes in either case. Since a multibyte string is > represented by a superset of UTF-8, you are guaranteed that no > multibyte sequence will ever include '.'. So converting from > multibyte sequences to characters and back, as well as calls to > string_char_advance, can be avoided. I'm glad I asked about this because I had completely misunderstood how multibyte strings are represented. This makes a lot more sense. Thanks! -- Alan Third