From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: contact@jimeh.me, 49271@debbugs.gnu.org
Subject: bug#49271: 28.0.50: native-comp: Signing macOS self-contained .app bundle fails due to new *.eln location
Date: Thu, 01 Jul 2021 10:13:04 +0300 [thread overview]
Message-ID: <83v95uld6n.fsf@gnu.org> (raw)
In-Reply-To: <YNzAjsQYSAqZKdlN@breton.holly.idiocy.org> (message from Alan Third on Wed, 30 Jun 2021 20:05:50 +0100)
> Date: Wed, 30 Jun 2021 20:05:50 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, 49271@debbugs.gnu.org
>
> Eli, is this an acceptable way of modifying a lisp string, or is there
> a better way?
> [...]
> +#ifdef NS_SELF_CONTAINED
> + /* MacOS self contained app bundles do not like having dots in the
> + directory names under the Contents/Frameworks directory, so
> + convert them to underscores. */
> +
> + char *str = xstrdup (SSDATA(version));
> +
> + for (ptrdiff_t c = 0 ; c < SBYTES (version) ; c++)
> + if (*(str + c) == '.')
> + *(str + c) = '_';
> +
> + version = build_string (str);
> + xfree (str);
> +#endif
It should work, although I'd prefer writing such code the other way
around: first create an uninitialized Lisp string (with
make_uninit_multibyte_string or make_uninit_string), then copy the
bytes while making the conversions. The reason for this preference is
that you could then make sure the produced string has the same
multibyte-ness as the original, whereas the way you did it relies on
whatever build_string decides, which is not necessarily the same.
Thanks.
next prev parent reply other threads:[~2021-07-01 7:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 11:58 bug#49271: 28.0.50: native-comp: Signing macOS self-contained .app bundle fails due to new *.eln location Jim Myhrberg
2021-06-29 19:18 ` Alan Third
2021-06-30 10:04 ` Jim Myhrberg
2021-06-30 12:20 ` Eli Zaretskii
2021-06-30 12:39 ` Jim Myhrberg
2021-06-30 12:52 ` Alan Third
2021-06-30 13:10 ` Jim Myhrberg
2021-06-30 19:05 ` Alan Third
2021-07-01 7:13 ` Eli Zaretskii [this message]
2021-07-01 18:45 ` Alan Third
2021-07-01 19:03 ` Eli Zaretskii
2021-07-01 19:56 ` Alan Third
2021-07-01 14:53 ` Jim Myhrberg
2021-07-01 20:13 ` Alan Third
2021-07-01 20:43 ` Jim Myhrberg
2021-07-01 21:16 ` Alan Third
2021-06-30 12:42 ` Alan Third
2021-06-30 12:51 ` Jim Myhrberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v95uld6n.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=49271@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=contact@jimeh.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).