From: John Cummings <john@rootabega.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50630@debbugs.gnu.org
Subject: bug#50630: [PATCH] Add tests for insert-directory
Date: Sat, 25 Sep 2021 12:30:51 +0000 [thread overview]
Message-ID: <SgjN8uB24YdaAD9sLrdY5fijBiYolxEsLiSSg8ODI06VAySrVBimQVgFtSBMAcaJb9E_2zE-5D3HYmHAOfxLxH-qGCNDnk_plNNUFpc9akE=@rootabega.net> (raw)
In-Reply-To: <KCMu-RkC1K53e9eYlde2GN5zAgOGG2vN-nYT812hOxG3ZA1CvjN3OPuIFnk_xyxb3ITy71q4FqyfH2HCaxIEaC-HzJDQ2W5ciiiMP89FPAE=@rootabega.net>
John Cummings <john@rootabega.net> wrote:
> Eli Zaretskii eliz@gnu.org wrote:
> > > Date: Fri, 24 Sep 2021 19:58:25 +0000
> > > From: John Cummings john@rootabega.net
> > > Along those lines, I also attempted to skip the test when ls-lisp
> > > would be used during files-tests.el, which I predict might happen when
> > > building on Windows?
> > Why did you need to skip those tests? Can you elaborate?
> ls-lisp has its own implementation of insert-directory, which
[snipped long section about WHY I thought the test should be skipped]
Also, I now see how making files-tests.el responsible for
accommodating ls-lisp.el might be backwards. If skipping the tests is
still a good idea, I'll try to learn if there's a more conventional
way to do it, e.g. having files-tests.el look for more general signs
that the insert-directory implementation has been overridden, or
maybe having ls-lisp.el be responsible for asking that that test be
skipped.
next prev parent reply other threads:[~2021-09-25 12:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 23:00 bug#50630: 28.0.50; list-directory shows free space for current directory, not the specified one John Cummings
2021-09-17 7:07 ` Eli Zaretskii
2021-09-17 10:24 ` John Cummings
2021-09-17 10:36 ` Eli Zaretskii
2021-09-17 17:38 ` bug#50630: [External] : " Drew Adams
2021-09-17 18:04 ` Eli Zaretskii
2021-09-17 20:32 ` John Cummings
2021-09-18 5:56 ` Eli Zaretskii
2021-09-18 10:04 ` John Cummings
2021-09-21 10:57 ` bug#50630: Confirmation of instances in ls-lisp.el and tramp-sh.el John Cummings
2021-09-24 19:58 ` bug#50630: [PATCH] Add tests for insert-directory John Cummings
2021-09-25 1:47 ` Lars Ingebrigtsen
2021-09-25 10:45 ` John Cummings
2021-09-25 11:38 ` Michael Albinus
2021-09-25 12:13 ` John Cummings
2021-09-25 6:10 ` Eli Zaretskii
2021-09-25 11:38 ` John Cummings
2021-09-25 12:30 ` John Cummings [this message]
2021-09-25 13:06 ` Eli Zaretskii
2021-09-25 14:29 ` John Cummings
2021-09-25 14:55 ` Eli Zaretskii
2021-09-25 17:15 ` John Cummings
2021-09-25 17:26 ` Eli Zaretskii
2021-09-25 17:37 ` John Cummings
2021-09-25 17:44 ` Eli Zaretskii
2021-09-25 18:01 ` John Cummings
2021-09-25 18:44 ` Eli Zaretskii
2021-09-25 19:00 ` John Cummings
2021-09-25 19:07 ` Eli Zaretskii
2021-09-25 19:58 ` John Cummings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='SgjN8uB24YdaAD9sLrdY5fijBiYolxEsLiSSg8ODI06VAySrVBimQVgFtSBMAcaJb9E_2zE-5D3HYmHAOfxLxH-qGCNDnk_plNNUFpc9akE=@rootabega.net' \
--to=john@rootabega.net \
--cc=50630@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).