From: Eli Zaretskii <eliz@gnu.org>
To: John Cummings <john@rootabega.net>
Cc: 50630-done@debbugs.gnu.org
Subject: bug#50630: [External] : bug#50630: 28.0.50; list-directory shows free space for current directory, not the specified one
Date: Sat, 18 Sep 2021 08:56:45 +0300 [thread overview]
Message-ID: <83h7ei77fm.fsf@gnu.org> (raw)
In-Reply-To: <MP4CUgFbrvpsfs0X0c18GkeNBtq9_6J0b9OKsUa8SretoZFwYGkuk8Grj3o1FxUSE80Rb3NSE5Hn8szRLPHESm6rlsqgmnJwDp-9lo9OfYk=@rootabega.net> (message from John Cummings on Fri, 17 Sep 2021 20:32:53 +0000)
> Date: Fri, 17 Sep 2021 20:32:53 +0000
> From: John Cummings <john@rootabega.net>
> Cc: Drew Adams <drew.adams@oracle.com>, 50630-done@debbugs.gnu.org
>
> On Friday, September 17th, 2021 at 2:04 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
> > > From: Drew Adams drew.adams@oracle.com
> > > I believe the same change is needed in ls-lisp.el, for function `ls-lisp--insert-directory'.
> > >
> > > (let ((available (get-free-disk-space ".")))
> > >
> > > should be:
> > >
> > > (let ((available (get-free-disk-space file)))
> >
> > Why, do you see the wrong values being reported?
>
> The values look wrong to me here.
In my testing, they reflect the correct volume (because the call is in
the buffer whose default-directory is set to the directory we are
going to display), which is why I installed the changes. Please tell
how you test, starting from "emacs -Q", because I'd like to look at
this.
> Thanks for the heads up. I've got a working test for files.el and ls-lisp.el, and after I polish it, I'll also look into how to handle FILE vs ORIG-FILE
Thanks.
next prev parent reply other threads:[~2021-09-18 5:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 23:00 bug#50630: 28.0.50; list-directory shows free space for current directory, not the specified one John Cummings
2021-09-17 7:07 ` Eli Zaretskii
2021-09-17 10:24 ` John Cummings
2021-09-17 10:36 ` Eli Zaretskii
2021-09-17 17:38 ` bug#50630: [External] : " Drew Adams
2021-09-17 18:04 ` Eli Zaretskii
2021-09-17 20:32 ` John Cummings
2021-09-18 5:56 ` Eli Zaretskii [this message]
2021-09-18 10:04 ` John Cummings
2021-09-21 10:57 ` bug#50630: Confirmation of instances in ls-lisp.el and tramp-sh.el John Cummings
2021-09-24 19:58 ` bug#50630: [PATCH] Add tests for insert-directory John Cummings
2021-09-25 1:47 ` Lars Ingebrigtsen
2021-09-25 10:45 ` John Cummings
2021-09-25 11:38 ` Michael Albinus
2021-09-25 12:13 ` John Cummings
2021-09-25 6:10 ` Eli Zaretskii
2021-09-25 11:38 ` John Cummings
2021-09-25 12:30 ` John Cummings
2021-09-25 13:06 ` Eli Zaretskii
2021-09-25 14:29 ` John Cummings
2021-09-25 14:55 ` Eli Zaretskii
2021-09-25 17:15 ` John Cummings
2021-09-25 17:26 ` Eli Zaretskii
2021-09-25 17:37 ` John Cummings
2021-09-25 17:44 ` Eli Zaretskii
2021-09-25 18:01 ` John Cummings
2021-09-25 18:44 ` Eli Zaretskii
2021-09-25 19:00 ` John Cummings
2021-09-25 19:07 ` Eli Zaretskii
2021-09-25 19:58 ` John Cummings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7ei77fm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50630-done@debbugs.gnu.org \
--cc=john@rootabega.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).