From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Cummings Newsgroups: gmane.emacs.bugs Subject: bug#50630: [PATCH] Add tests for insert-directory Date: Sat, 25 Sep 2021 12:30:51 +0000 Message-ID: References: <83a6k1rxrc.fsf@gnu.org> Reply-To: John Cummings Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6877"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50630@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 14:35:00 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU6tQ-0001Y4-Cx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 14:35:00 +0200 Original-Received: from localhost ([::1]:40798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU6tP-0002WN-88 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 08:34:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU6pa-0000KS-M5 for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 08:31:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48838) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU6pa-0005Fe-Ei for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 08:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU6pZ-00031s-T9 for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 08:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Cummings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-submit@debbugs.gnu.org id=B50630.163257306011636 (code B ref 50630); Sat, 25 Sep 2021 12:31:01 +0000 Original-Received: (at 50630) by debbugs.gnu.org; 25 Sep 2021 12:31:00 +0000 Original-Received: from localhost ([127.0.0.1]:60384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU6pX-00031c-Rt for submit@debbugs.gnu.org; Sat, 25 Sep 2021 08:31:00 -0400 Original-Received: from mail1.protonmail.ch ([185.70.40.18]:43601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU6pW-00031O-7d for 50630@debbugs.gnu.org; Sat, 25 Sep 2021 08:30:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rootabega.net; s=protonmail; t=1632573051; bh=SG/f1b2iU0WatDRoPyI8XDD53ATddG9HI+7uubpSjKk=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=rjU1B9dztVc9zuQsAN/gL2Btt+iy3zoVI41sNAEhMiWJg1/p9izYG4GURx9NqNxTA LOCa3RWYUfkupUguDZh4CwsT7KcOIiyUF/L04rNJsdfKkE4Ws0R1lJ2CgJsb9C8kt9 shOeBH4Yc+vNPN4iObnjSEwn7+X9mWkzvOaFdjFm8TlOWC+8hKQuMvgxS3Ih8lz0GQ /ZlMDI2oTkGxxqXXnGU4vWHACTxdnZMIidTtfuvjOWmAIn9iqbxBDGJf7r+8H5wxSs NMdjU3F6b/rIrL0xJZiTUN9ssWfZvjSe6B3ZcNsHlQtB6T5Kp4CrVnk4vXaGnBG+mx o4fjw8lJvb6mg== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215437 Archived-At: John Cummings wrote: > Eli Zaretskii eliz@gnu.org wrote: > > > Date: Fri, 24 Sep 2021 19:58:25 +0000 > > > From: John Cummings john@rootabega.net > > > Along those lines, I also attempted to skip the test when ls-lisp > > > would be used during files-tests.el, which I predict might happen whe= n > > > building on Windows? > > Why did you need to skip those tests? Can you elaborate? > ls-lisp has its own implementation of insert-directory, which [snipped long section about WHY I thought the test should be skipped] Also, I now see how making files-tests.el responsible for accommodating ls-lisp.el might be backwards. If skipping the tests is still a good idea, I'll try to learn if there's a more conventional way to do it, e.g. having files-tests.el look for more general signs that the insert-directory implementation has been overridden, or maybe having ls-lisp.el be responsible for asking that that test be skipped.