bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows

bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows

[Wilson Pete]

The patch for bug #25082 appears to have broken quoted paths being passed to emacsclientw on Windows.

w32_execvp doesn’t handle this because it doesn’t quote the path argument to execvp (ultimately to CreateProcess?).

So the patch prevents any possibility of passing a path with spaces as the alternate editor on Windows.

It would have been nice (perhaps) if this had been made a new different command line switch.

Pete Wilson


The information transmitted via this e-mail is intended only for the person or entity to which it is addressed and may contain confidential and/or proprietary information. Any use, review, retransmission, dissemination or other use of, or pursuing of any action in reliance upon this information by persons or entities other than the intended recipient is strictly prohibited. If you are the recipient of this e-mail transmission in error, please reply to the sender and delete the material from any computer. Thank you.

bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows

[Eli Zaretskii]

> From: Wilson Pete <Pete.Wilson@LPNT.net>
> Date: Thu, 3 Oct 2019 17:40:28 +0000
> 
> The patch for bug #25082 appears to have broken quoted paths being passed to emacsclientw on Windows.
> 
> w32_execvp doesn’t handle this because it doesn’t quote the path argument to execvp (ultimately to CreateProcess?).
> 
> So the patch prevents any possibility of passing a path with spaces as the alternate editor on Windows.

Could you please show a (non-)working example where this problem can
be seen?

Thanks.

bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows

[Wilson Pete]

The following command used to work before the path was applied:

[C:\] "c:\Program Files\emacs\bin\emacsclient.exe"  -a "c:\Program Files\emacs\bin\runemacs.exe" n:\wilsonp\emacs.el
c:\Program Files\emacs\bin\emacsclient.exe: error executing alternate editor "c:\Program Files\emacs\bin\runemacs.exe"

PETE M. WILSON
SYSTEMS MANAGER, MANAGEMENT INFORMATION SYSTEMS
Sovah Health – Danville

The information transmitted via this e-mail is intended only for the person or entity to which it is addressed and may contain confidential and/or proprietary information. Any use, review, retransmission, dissemination or other use of, or pursuing of any action in reliance upon this information by persons or entities other than the intended recipient is strictly prohibited. If you are the recipient of this e-mail transmission in error, please reply to the sender and delete the material from any computer. Thank you.

bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows

[Eli Zaretskii]

> From: Wilson Pete <Pete.Wilson@LPNT.net>
> CC: "37608@debbugs.gnu.org" <37608@debbugs.gnu.org>
> Date: Thu, 3 Oct 2019 19:49:02 +0000
> 
> The following command used to work before the path was applied:
> 
> [C:\] "c:\Program Files\emacs\bin\emacsclient.exe"  -a "c:\Program Files\emacs\bin\runemacs.exe" n:\wilsonp\emacs.el
> c:\Program Files\emacs\bin\emacsclient.exe: error executing alternate editor "c:\Program Files\emacs\bin\runemacs.exe"

Thanks, I will look into this when I have time, if no one beats me to
it.