From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37608: Patch for support in emacsclient for command-lline options in ALTERNATE_EDITOR breaks quoted paths on Windows Date: Thu, 03 Oct 2019 21:37:35 +0300 Message-ID: <83d0fd7k0g.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="89808"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37608@debbugs.gnu.org To: Wilson Pete Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 20:39:35 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG60k-000NFg-KZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 20:39:34 +0200 Original-Received: from localhost ([::1]:39328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG60i-0008H1-TU for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 14:39:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43936) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iG60L-0008FU-FZ for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:39:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iG60J-0000fl-D4 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:39:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60565) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iG60F-0000ba-Tz for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:39:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iG60F-0007lq-Q7 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 14:39:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 18:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37608 X-GNU-PR-Package: emacs Original-Received: via spool by 37608-submit@debbugs.gnu.org id=B37608.157012788529778 (code B ref 37608); Thu, 03 Oct 2019 18:39:03 +0000 Original-Received: (at 37608) by debbugs.gnu.org; 3 Oct 2019 18:38:05 +0000 Original-Received: from localhost ([127.0.0.1]:41149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5zH-0007kC-91 for submit@debbugs.gnu.org; Thu, 03 Oct 2019 14:38:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG5zD-0007jg-Jk for 37608@debbugs.gnu.org; Thu, 03 Oct 2019 14:37:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iG5z8-0007VT-5H; Thu, 03 Oct 2019 14:37:54 -0400 Original-Received: from [176.228.60.248] (port=3845 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iG5z6-0003J3-RC; Thu, 03 Oct 2019 14:37:53 -0400 In-reply-to: (message from Wilson Pete on Thu, 3 Oct 2019 17:40:28 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168273 Archived-At: > From: Wilson Pete > Date: Thu, 3 Oct 2019 17:40:28 +0000 > > The patch for bug #25082 appears to have broken quoted paths being passed to emacsclientw on Windows. > > w32_execvp doesn’t handle this because it doesn’t quote the path argument to execvp (ultimately to CreateProcess?). > > So the patch prevents any possibility of passing a path with spaces as the alternate editor on Windows. Could you please show a (non-)working example where this problem can be seen? Thanks.