* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
@ 2023-03-10 14:54 Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 15:43 ` Drew Adams
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 14:54 UTC (permalink / raw)
To: 62096
Hi,
I've found out that 'dired-goto-file' does not work with file name with
spaces in them. It is only in buffers generated by 'find-dired' (it
works in a "normal" dired buffer).
How to reproduce:
--8<---------------cut here---------------start------------->8---
emacs -Q --eval "(find-dired \"~\" \"-type f -name \\\"*.jpg\\\"\")"
j a-file-name-without-space.jpg ;; it jumps to the file
j vacation 2022/we needed space.jpg ;; it doesn't
--8<---------------cut here---------------end--------------->8---
In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version
1.17.8) of 2023-03-09 built on computer
Repository revision: 26740f30469c2b13765f986fa65eca8a3a851ba2
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
System Description: OpenBSD computer 7.2 GENERIC.MP#1052 amd64
Configured using:
'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin
--with-x-toolkit=no --without-sound --without-compress-install
CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib'
Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG
SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB
Important settings:
value of $LC_ALL: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Dired by name
Minor modes in effect:
gnus-dired-mode: t
display-time-mode: t
display-battery-mode: t
server-mode: t
shell-dirtrack-mode: t
repeat-mode: t
desktop-save-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
buffer-read-only: t
line-number-mode: t
indent-tabs-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
/home/manuel/.emacs.d/elpa/ef-themes-0.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs
/home/manuel/.emacs.d/elpa/transient-0.3.7/transient hides /home/manuel/emacs/share/emacs/30.0.50/lisp/transient
Features:
(shadow shortdoc pulse emacsbug smerge-mode diff flow-fill sort
gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize
uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic
mm-archive url-http url-gw url-cache url-auth qp utf-7 imap rfc2104
nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr
gnus-score score-mode nnvirtual nntp gnus-cache nnrss org-indent
org-element org-persist org-id org-refile avl-tree oc-basic ol-eww
ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view
jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi
org-link-doi reveal idlwave idlwave-help idlw-help conf-mode
emacs-news-mode view vc-hg pascal vc-dir ewoc sh-script executable vc
scheme semantic/bovine/grammar semantic/wisent/grammar semantic/bovine
semantic/grammar help-fns radix-tree semantic/idle semantic/analyze
semantic/sort semantic/scope semantic/analyze/fcn semantic/db
semantic/grammar-wy semantic/format semantic/tag-ls semantic/find
semantic/ctxt semantic/wisent semantic/wisent/wisent semantic/util-modes
semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local
cedet css-mode treesit smie sgml-mode facemenu imenu eww xdg url-queue
mm-url mule-util autorevert filenotify vc-git diff-mode vc-dispatcher
vc-svn bug-reference paredit edmacro gnus-dired time battery exwm-randr
xcb-randr exwm-config ido exwm exwm-input xcb-keysyms xcb-xkb
exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout
exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types
xcb-debug kmacro server modus-operandi-theme modus-themes ytdious mingus
libmpdee reporter edebug debug backtrace transmission color calc-bin
calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-message
ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls
dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group
gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7
nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny
rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils
mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util
mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt
cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone org
ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint
org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp
ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys
oc org-loaddefs find-func org-version org-compat org-macs
visual-basic-mode cl web-mode derived disp-table erlang-start
smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp
tramp rx tramp-loaddefs trampver tramp-integration cus-edit cus-load
wid-edit files-x tramp-compat shell pcomplete parse-time iso8601
time-date ls-lisp format-spec slime-fancy slime-indentation
slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu
slime-package-fu slime-references slime-compiler-notes-tree advice
slime-scratch slime-presentations bridge slime-macrostep macrostep
slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl slime-parse slime apropos compile text-property-search etags
fileloop generator xref project arc-mode archive-mode noutline outline
icons pp comint ansi-osc ansi-color ring hyperspec thingatpt
slime-autoloads appt diary-lib diary-loaddefs cal-menu calendar
cal-loaddefs dired-aux dired-x dired dired-loaddefs notifications dbus
xml repeat easy-mmode desktop frameset osm-autoloads rust-mode-autoloads
ebdb-autoloads compat-autoloads magit-autoloads debbugs-autoloads
git-commit-autoloads magit-section-autoloads ef-themes-autoloads
with-editor-autoloads paredit-autoloads dash-autoloads ytdious-autoloads
transmission-autoloads transient-autoloads exwm-autoloads
hyperbole-autoloads detached-autoloads info package browse-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind kqueue lcms2 dynamic-setting system-font-setting
font-render-setting cairo xinput2 x multi-tty make-network-process
emacs)
Memory information:
((conses 16 981314 691303)
(symbols 48 59840 4)
(strings 32 290841 40053)
(string-bytes 1 9016789)
(vectors 16 178945)
(vector-slots 8 3133349 75543)
(floats 8 631 428)
(intervals 56 20994 192)
(buffers 984 130))
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 14:54 bug#62096: 30.0.50; find-dired, dired-goto-file and spaces Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 15:43 ` Drew Adams
2023-03-10 15:59 ` Stephen Berman
0 siblings, 1 reply; 52+ messages in thread
From: Drew Adams @ 2023-03-10 15:43 UTC (permalink / raw)
To: Manuel Giraud, 62096@debbugs.gnu.org
> I've found out that 'dired-goto-file' does not work with file name with
> spaces in them. It is only in buffers generated by 'find-dired' (it
> works in a "normal" dired buffer).
>
> How to reproduce:
>
> --8<---------------cut here---------------start------------->8---
> emacs -Q --eval "(find-dired \"~\" \"-type f -name \\\"*.jpg\\\"\")"
>
> j a-file-name-without-space.jpg ;; it jumps to the file
> j vacation 2022/we needed space.jpg ;; it doesn't
> --8<---------------cut here---------------end--------------->8---
>
> In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version
Good catch. I can confirm seeing the bug (on
MS Windows) also in 28.2 and older versions.
The problem appears to be in `dired-get-filename'.
FWIW, I also see it in my (Dired+) code, except
that in my code I see it only for a file name
that starts with a space, not also for a name
that just has an embedded space. E.g, I see the
problem for " space-prefixed-filename" but not
for file "has embedded space".
Not sure what the right fix would be.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 15:43 ` Drew Adams
@ 2023-03-10 15:59 ` Stephen Berman
2023-03-10 17:10 ` Drew Adams
2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 52+ messages in thread
From: Stephen Berman @ 2023-03-10 15:59 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096@debbugs.gnu.org, Manuel Giraud
On Fri, 10 Mar 2023 15:43:57 +0000 Drew Adams <drew.adams@oracle.com> wrote:
>> I've found out that 'dired-goto-file' does not work with file name with
>> spaces in them. It is only in buffers generated by 'find-dired' (it
>> works in a "normal" dired buffer).
>>
>> How to reproduce:
>>
>> --8<---------------cut here---------------start------------->8---
>> emacs -Q --eval "(find-dired \"~\" \"-type f -name \\\"*.jpg\\\"\")"
>>
>> j a-file-name-without-space.jpg ;; it jumps to the file
>> j vacation 2022/we needed space.jpg ;; it doesn't
>> --8<---------------cut here---------------end--------------->8---
>>
>> In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version
>
> Good catch. I can confirm seeing the bug (on
> MS Windows) also in 28.2 and older versions.
I don't see this bug on Emacs 26-30 built on GNU/Linux, i.e. typing `j'
in the find-dired output buffer and completing a file name with spaces
correctly jumps to the line with that file.
Steve Berman
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 15:59 ` Stephen Berman
@ 2023-03-10 17:10 ` Drew Adams
2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 0 replies; 52+ messages in thread
From: Drew Adams @ 2023-03-10 17:10 UTC (permalink / raw)
To: Stephen Berman; +Cc: 62096@debbugs.gnu.org, Manuel Giraud
> > Good catch. I can confirm seeing the bug (on
> > MS Windows) also in 28.2 and older versions.
>
> I don't see this bug on Emacs 26-30 built on GNU/Linux, i.e. typing `j'
> in the find-dired output buffer and completing a file name with spaces
> correctly jumps to the line with that file.
Interesting. Perhaps it's a platform difference.
I definitely see it with `emacs -Q'.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 15:59 ` Stephen Berman
2023-03-10 17:10 ` Drew Adams
@ 2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
` (2 more replies)
1 sibling, 3 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 18:07 UTC (permalink / raw)
To: Stephen Berman; +Cc: 62096@debbugs.gnu.org, Drew Adams
Stephen Berman <stephen.berman@gmx.net> writes:
[...]
>> Good catch. I can confirm seeing the bug (on
>> MS Windows) also in 28.2 and older versions.
>
> I don't see this bug on Emacs 26-30 built on GNU/Linux, i.e. typing `j'
> in the find-dired output buffer and completing a file name with spaces
> correctly jumps to the line with that file.
Thanks both for your feedback. It could be platform dependent: it is a
edge case and I think most Emacs users are on GNU/Linux.
I've also tried completing the file name but with the same negative
result. I'm searching...
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 11:55 ` Eli Zaretskii
2023-03-10 19:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:48 ` Drew Adams
2 siblings, 2 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 18:37 UTC (permalink / raw)
To: Stephen Berman; +Cc: 62096@debbugs.gnu.org, Drew Adams
Ok, so commenting the string-replace at dired.el:3529 in
'dired-goto-file-1' (ie. not replacing " " with "\\ ") does the trick
for me...
That being said those are here for a reason. It might be a difference
between OpenBSD's find and the GNU one (I don't know for Windows).
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 19:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:55 ` Drew Adams
2023-03-11 11:58 ` Eli Zaretskii
2023-03-10 19:48 ` Drew Adams
2 siblings, 2 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 19:05 UTC (permalink / raw)
To: Stephen Berman; +Cc: 62096@debbugs.gnu.org, Drew Adams
I almost got it. It comes from the test on the switches used to build
the dired buffer.
For a "standard" dired build with ls, on OpenBSD, I just have "-al" as
switches: no "b" so it doesn't trigger the string-replace.
For a find-dired buffer, on OpenBSD, I have "-gilsb" as switches: there
is a "b" that triggers the string-replace (which is not needed here).
I think that the fix should be "test the b switch only for ls built
dired". I don't know if it will fix Windows.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 19:48 ` Drew Adams
2 siblings, 0 replies; 52+ messages in thread
From: Drew Adams @ 2023-03-10 19:48 UTC (permalink / raw)
To: Manuel Giraud, Stephen Berman; +Cc: 62096@debbugs.gnu.org
> Thanks both for your feedback. It could be platform dependent: it is a
> edge case and I think most Emacs users are on GNU/Linux.
That may be, but I think that MS Windows users have
been using file names with SPACE chars for a long
time, and there are many, any such file names.
I'm guessing there's more use of such names on
Windows. I don't think it's really just a corner
case on Windows.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 19:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 19:55 ` Drew Adams
2023-03-10 20:42 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 11:58 ` Eli Zaretskii
1 sibling, 1 reply; 52+ messages in thread
From: Drew Adams @ 2023-03-10 19:55 UTC (permalink / raw)
To: Manuel Giraud, Stephen Berman; +Cc: 62096@debbugs.gnu.org
> I almost got it. It comes from the test on the switches used to build
> the dired buffer.
>
> For a "standard" dired build with ls, on OpenBSD, I just have "-al" as
> switches: no "b" so it doesn't trigger the string-replace.
>
> For a find-dired buffer, on OpenBSD, I have "-gilsb" as switches: there
> is a "b" that triggers the string-replace (which is not needed here).
>
> I think that the fix should be "test the b switch only for ls built
> dired". I don't know if it will fix Windows.
In my tests with `emacs -Q`, `dired-listing-switches' is
just "-al", so I'm guessing that going down this road
isn't the right approach (isn't sufficient).
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 19:55 ` Drew Adams
@ 2023-03-10 20:42 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:24 ` Drew Adams
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 20:42 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096@debbugs.gnu.org, Stephen Berman
Drew Adams <drew.adams@oracle.com> writes:
[...]
> In my tests with `emacs -Q`, `dired-listing-switches' is
> just "-al", so I'm guessing that going down this road
> isn't the right approach (isn't sufficient).
Ok. And what do you have as 'find-ls-option-default-ls' and
'system-type'?
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
` (3 more replies)
2023-03-11 11:55 ` Eli Zaretskii
1 sibling, 4 replies; 52+ messages in thread
From: Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 20:48 UTC (permalink / raw)
To: 62096; +Cc: stephen.berman, drew.adams, manuel
Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> Ok, so commenting the string-replace at dired.el:3529 in
> 'dired-goto-file-1' (ie. not replacing " " with "\\ ") does the trick
> for me...
>
> That being said those are here for a reason. It might be a difference
> between OpenBSD's find and the GNU one (I don't know for Windows).
This bug also affects macOS. After reading the code I'd say that, even
on GNU/Linux, there are probably other corner cases where
dired-goto-file would fail:
;; FIXME: to fix this for embedded control characters etc, we
;; should escape everything that `ls -b' does.
(setq str (string-replace " " "\\ " str)
str (string-replace "\t" "\\t" str)
str (string-replace "\n" "\\n" str))
For example, on GNU/Linux, ls -b outputs:
vacation\ 2022
while on macOS it outputs:
vacation 2022
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 21:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 0:14 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:31 ` Drew Adams
` (2 subsequent siblings)
3 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 21:04 UTC (permalink / raw)
To: Daniel Martín; +Cc: 62096, stephen.berman, drew.adams
Daniel Martín <mardani29@yahoo.es> writes:
[...]
> This bug also affects macOS. After reading the code I'd say that, even
> on GNU/Linux, there are probably other corner cases where
> dired-goto-file would fail:
Thanks for the test. I have some questions:
- Have you seen this bug even on a non 'find-dired' buffer?
- Same question as Drew: What are your value of 'system-type' and
'find-ls-option-default-ls'
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 20:42 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 21:24 ` Drew Adams
2023-03-10 21:32 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Drew Adams @ 2023-03-10 21:24 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096@debbugs.gnu.org, Stephen Berman
> > In my tests with `emacs -Q`, `dired-listing-switches' is
> > just "-al", so I'm guessing that going down this road
> > isn't the right approach (isn't sufficient).
>
> Ok. And what do you have as 'find-ls-option-default-ls' and
> 'system-type'?
`system-type': windows-nt
`find-ls-option-default-ls': In 28.2, ("-ls" . "-dilsb").
In 26.3 there's no such var.
But I should say that I cheated. For `emacs -Q' I didn't
bother to try to set up Cygwin etc. and actually use
`find-name-dired'.
I just copied the buffer text from my use of `find-name-dired'
in my own setup into a virgin buffer, put that in `dired-mode',
and copied the value of dired-subdir-alist from the find output
buffer in my setup:
(setq dired-subdir-alist '(("path/to/dir/" . 1)))
So I can't make a solid claim about this.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 21:31 ` Drew Adams
2023-03-10 21:43 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 12:00 ` Eli Zaretskii
2023-03-12 10:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
3 siblings, 1 reply; 52+ messages in thread
From: Drew Adams @ 2023-03-10 21:31 UTC (permalink / raw)
To: mardani29, 62096; +Cc: stephen.berman, manuel
I'll just say that whatever changes are made for this bug fix, whoever makes them should be VERY sure.
There are _lots_ of cases where `dired-goto-file(-1)' is used, LOTS. And it's not just about different platforms. You're thinking about fiddling with a very basic function here, and the contexts in which it's used are various.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 21:24 ` Drew Adams
@ 2023-03-10 21:32 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:45 ` Drew Adams
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 21:32 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096@debbugs.gnu.org, Stephen Berman
Drew Adams <drew.adams@oracle.com> writes:
>> > In my tests with `emacs -Q`, `dired-listing-switches' is
>> > just "-al", so I'm guessing that going down this road
>> > isn't the right approach (isn't sufficient).
>>
>> Ok. And what do you have as 'find-ls-option-default-ls' and
>> 'system-type'?
>
> `system-type': windows-nt
>
> `find-ls-option-default-ls': In 28.2, ("-ls" . "-dilsb").
> In 26.3 there's no such var.
Ok.
> But I should say that I cheated. For `emacs -Q' I didn't
> bother to try to set up Cygwin etc. and actually use
> `find-name-dired'.
Yes but 'find-name-dired' uses 'find-dired' internally. Is your value
of 'find-program' set to "find"? And if so, do you know what "find" it
is?
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 21:31 ` Drew Adams
@ 2023-03-10 21:43 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 21:43 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096, stephen.berman, mardani29
Drew Adams <drew.adams@oracle.com> writes:
> I'll just say that whatever changes are made for this bug fix, whoever
> makes them should be VERY sure.
Ok. I'm just searching and I'm not VERY sure.
> There are _lots_ of cases where `dired-goto-file(-1)' is used, LOTS.
> And it's not just about different platforms. You're thinking about
> fiddling with a very basic function here, and the contexts in which
> it's used are various.
I know I've found it while using 'image-dired-track-original-file'
feature.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 21:32 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 21:45 ` Drew Adams
2023-03-10 22:03 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Drew Adams @ 2023-03-10 21:45 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096@debbugs.gnu.org, Stephen Berman
> Yes but 'find-name-dired' uses 'find-dired' internally. Is your value
> of 'find-program' set to "find"?
Yes.
> And if so, do you know what "find" it is?
Some old Cygwin distribution from 2017.
`C-h v cygwin-mount' tells me "1.4.8".
Again, not saying anything I reported
should be considered definitive.
HTH.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 21:45 ` Drew Adams
@ 2023-03-10 22:03 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 22:20 ` Drew Adams
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-10 22:03 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096@debbugs.gnu.org, Stephen Berman
Drew Adams <drew.adams@oracle.com> writes:
> Some old Cygwin distribution from 2017.
> `C-h v cygwin-mount' tells me "1.4.8".
Thanks. If it works, could you send me (off-list if you prefer) the
content of your `M-x man find'?
> Again, not saying anything I reported
> should be considered definitive.
Duly noted.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 22:03 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-10 22:20 ` Drew Adams
0 siblings, 0 replies; 52+ messages in thread
From: Drew Adams @ 2023-03-10 22:20 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096@debbugs.gnu.org, Stephen Berman
> > Some old Cygwin distribution from 2017.
> > `C-h v cygwin-mount' tells me "1.4.8".
>
> Thanks. If it works, could you send me (off-list if you prefer) the
> content of your `M-x man find'?
FIND(1) General Commands Manual FIND(1)
NAME
find - search for files in a directory hierarchy
SYNOPSIS
find [-H] [-L] [-P] [-D debugopts] [-Olevel] [starting-point...]
[expression]
DESCRIPTION
This manual page documents the GNU version of find. GNU find searches
the directory tree rooted at each given starting-point by evaluating
the given expression from left to right, according to the rules of
precedence (see section OPERATORS), until the outcome is known (the
left hand side is false for and operations, true for or), at which
point find moves on to the next file name. If no starting-point is
specified, `.' is assumed.
If you are using find in an environment where security is important
(for example if you are using it to search directories that are
writable by other users), you should read the "Security Considerations"
chapter of the findutils documentation, which is called Finding Files
and comes with findutils. That document also includes a lot more
detail and discussion than this manual page, so you may find it a more
useful source of information.
OPTIONS
The -H, -L and -P options control the treatment of symbolic links.
Command-line arguments following these are taken to be names of files
or directories to be examined, up to the first argument that begins
with `-', or the argument `(' or `!'. That argument and any following
arguments are taken to be the expression describing what is to be
searched for. If no paths are given, the current directory is used.
If no expression is given, the expression -print is used (but you
should probably consider using -print0 instead, anyway).
This manual page talks about `options' within the expression list.
These options control the behaviour of find but are specified immedi-
ately after the last path name. The five `real' options -H, -L, -P, -D
and -O must appear before the first path name, if at all. A double
dash -- can also be used to signal that any remaining arguments are not
options (though ensuring that all start points begin with either `./'
or `/' is generally safer if you use wildcards in the list of start
points).
-P Never follow symbolic links. This is the default behaviour.
When find examines or prints information a file, and the file is
a symbolic link, the information used shall be taken from the
properties of the symbolic link itself.
-L Follow symbolic links. When find examines or prints information
about files, the information used shall be taken from the prop-
erties of the file to which the link points, not from the link
itself (unless it is a broken symbolic link or find is unable to
examine the file to which the link points). Use of this option
implies -noleaf. If you later use the -P option, -noleaf will
still be in effect. If -L is in effect and find discovers a
symbolic link to a subdirectory during its search, the subdirec-
tory pointed to by the symbolic link will be searched.
When the -L option is in effect, the -type predicate will always
match against the type of the file that a symbolic link points
to rather than the link itself (unless the symbolic link is bro-
ken). Actions that can cause symbolic links to become broken
while find is executing (for example -delete) can give rise to
confusing behaviour. Using -L causes the -lname and -ilname
predicates always to return false.
-H Do not follow symbolic links, except while processing the com-
mand line arguments. When find examines or prints information
about files, the information used shall be taken from the prop-
erties of the symbolic link itself. The only exception to this
behaviour is when a file specified on the command line is a sym-
bolic link, and the link can be resolved. For that situation,
the information used is taken from whatever the link points to
(that is, the link is followed). The information about the link
itself is used as a fallback if the file pointed to by the sym-
bolic link cannot be examined. If -H is in effect and one of
the paths specified on the command line is a symbolic link to a
directory, the contents of that directory will be examined
(though of course -maxdepth 0 would prevent this).
If more than one of -H, -L and -P is specified, each overrides the oth-
ers; the last one appearing on the command line takes effect. Since it
is the default, the -P option should be considered to be in effect
unless either -H or -L is specified.
GNU find frequently stats files during the processing of the command
line itself, before any searching has begun. These options also affect
how those arguments are processed. Specifically, there are a number of
tests that compare files listed on the command line against a file we
are currently considering. In each case, the file specified on the
command line will have been examined and some of its properties will
have been saved. If the named file is in fact a symbolic link, and the
-P option is in effect (or if neither -H nor -L were specified), the
information used for the comparison will be taken from the properties
of the symbolic link. Otherwise, it will be taken from the properties
of the file the link points to. If find cannot follow the link (for
example because it has insufficient privileges or the link points to a
nonexistent file) the properties of the link itself will be used.
When the -H or -L options are in effect, any symbolic links listed as
the argument of -newer will be dereferenced, and the timestamp will be
taken from the file to which the symbolic link points. The same con-
sideration applies to -newerXY, -anewer and -cnewer.
The -follow option has a similar effect to -L, though it takes effect
at the point where it appears (that is, if -L is not used but -follow
is, any symbolic links appearing after -follow on the command line will
be dereferenced, and those before it will not).
-D debugoptions
Print diagnostic information; this can be helpful to diagnose
problems with why find is not doing what you want. The list of
debug options should be comma separated. Compatibility of the
debug options is not guaranteed between releases of findutils.
For a complete list of valid debug options, see the output of
find -D help. Valid debug options include
help Explain the debugging options
tree Show the expression tree in its original and optimised
form.
stat Print messages as files are examined with the stat and
lstat system calls. The find program tries to minimise
such calls.
opt Prints diagnostic information relating to the optimisa-
tion of the expression tree; see the -O option.
rates Prints a summary indicating how often each predicate suc-
ceeded or failed.
-Olevel
Enables query optimisation. The find program reorders tests to
speed up execution while preserving the overall effect; that is,
predicates with side effects are not reordered relative to each
other. The optimisations performed at each optimisation level
are as follows.
0 Equivalent to optimisation level 1.
1 This is the default optimisation level and corresponds to
the traditional behaviour. Expressions are reordered so
that tests based only on the names of files (for example
-name and -regex) are performed first.
2 Any -type or -xtype tests are performed after any tests
based only on the names of files, but before any tests
that require information from the inode. On many modern
versions of Unix, file types are returned by readdir()
and so these predicates are faster to evaluate than pred-
icates which need to stat the file first. If you use the
-fstype FOO predicate and specify a filesystem type FOO
which is not known (that is, present in `/etc/mtab') at
the time find starts, that predicate is equivalent to
-false.
3 At this optimisation level, the full cost-based query
optimiser is enabled. The order of tests is modified so
that cheap (i.e. fast) tests are performed first and more
expensive ones are performed later, if necessary. Within
each cost band, predicates are evaluated earlier or later
according to whether they are likely to succeed or not.
For -o, predicates which are likely to succeed are evalu-
ated earlier, and for -a, predicates which are likely to
fail are evaluated earlier.
The cost-based optimiser has a fixed idea of how likely any
given test is to succeed. In some cases the probability takes
account of the specific nature of the test (for example, -type f
is assumed to be more likely to succeed than -type c). The
cost-based optimiser is currently being evaluated. If it does
not actually improve the performance of find, it will be removed
again. Conversely, optimisations that prove to be reliable,
robust and effective may be enabled at lower optimisation levels
over time. However, the default behaviour (i.e. optimisation
level 1) will not be changed in the 4.3.x release series. The
findutils test suite runs all the tests on find at each optimi-
sation level and ensures that the result is the same.
EXPRESSION
The part of the command line after the list of starting points is the
expression. This is a kind of query specification describing how we
match files and what we do with the files that were matched. An
expression is composed of a sequence of things:
Tests Tests return a true or false value, usually on the basis of some
property of a file we are considering. The -empty test for
example is true only when the current file is empty.
Actions
Actions have side effects (such as printing something on the
standard output) and return either true or false, usually based
on whether or not they are successful. The -print action for
example prints the name of the current file on the standard out-
put.
Global options
Global options affect the operation of tests and actions speci-
fied on any part of the command line. Global options always
return true. The -depth option for example makes find traverse
the file system in a depth-first order.
Positional options
Positional optiona affect only tests or actions which follow
them. Positional options always return true. The -regextype
option for example is positional, specifying the regular expres-
sion dialect for regulat expressions occurring later on the com-
mand line.
Operators
Operators join together the other items within the expression.
They include for example -o (meaning logical OR) and -a (meaning
logical AND). Where an operator is missing, -a is assumed.
If the whole expression contains no actions other than -prune or
-print, -print is performed on all files for which the whole expression
is true.
The -delete action also acts like an option (since it implies -depth).
POSITIONAL OPTIONS
Positional options always return true. They affect only tests occur-
ring later on the command line.
-daystart
Measure times (for -amin, -atime, -cmin, -ctime, -mmin, and
-mtime) from the beginning of today rather than from 24 hours
ago. This option only affects tests which appear later on the
command line.
-follow
Deprecated; use the -L option instead. Dereference symbolic
links. Implies -noleaf. The -follow option affects only those
tests which appear after it on the command line. Unless the -H
or -L option has been specified, the position of the -follow
option changes the behaviour of the -newer predicate; any files
listed as the argument of -newer will be dereferenced if they
are symbolic links. The same consideration applies to -newerXY,
-anewer and -cnewer. Similarly, the -type predicate will always
match against the type of the file that a symbolic link points
to rather than the link itself. Using -follow causes the -lname
and -ilname predicates always to return false.
-regextype type
Changes the regular expression syntax understood by -regex and
-iregex tests which occur later on the command line. To see
which regular expression types are known, use -regextype help.
The Texinfo documentation (see SEE ALSO) explains the meaning of
and differences between the various types of regular expression.
-warn, -nowarn
Turn warning messages on or off. These warnings apply only to
the command line usage, not to any conditions that find might
encounter when it searches directories. The default behaviour
corresponds to -warn if standard input is a tty, and to -nowarn
otherwise. If a warning message relating to command-line usage
is produced, the exit status of find is not affected. If the
POSIXLY_CORRECT environment variable is set, and -warn is also
used, it is not specified which, if any, warnings will be
active.
GLOBAL OPTIONS
Global options always return true. Global options take effect even for
tests which occurr earlier on the command line. To prevent confusion,
global options should specified on the command-line after the list of
start points, just before the first test, positional option or action.
If you specify a global option in some other place, find will issue a
warning message explaining that this can be confusing.
The global options occur after the list of start points, and so are not
the same kind of option as -L, for example.
-d A synonym for -depth, for compatibility with FreeBSD, NetBSD,
MacOS X and OpenBSD.
-depth Process each directory's contents before the directory itself.
The -delete action also implies -depth.
-help, --help
Print a summary of the command-line usage of find and exit.
-ignore_readdir_race
Normally, find will emit an error message when it fails to stat
a file. If you give this option and a file is deleted between
the time find reads the name of the file from the directory and
the time it tries to stat the file, no error message will be
issued. This also applies to files or directories whose names
are given on the command line. This option takes effect at the
time the command line is read, which means that you cannot
search one part of the filesystem with this option on and part
of it with this option off (if you need to do that, you will
need to issue two find commands instead, one with the option and
one without it).
-maxdepth levels
Descend at most levels (a non-negative integer) levels of direc-
tories below the starting-points. -maxdepth 0
means only apply the tests and actions to the starting-points
themselves.
-mindepth levels
Do not apply any tests or actions at levels less than levels (a
non-negative integer). -mindepth 1 means process all files
except the starting-points.
-mount Don't descend directories on other filesystems. An alternate
name for -xdev, for compatibility with some other versions of
find.
-noignore_readdir_race
Turns off the effect of -ignore_readdir_race.
-noleaf
Do not optimize by assuming that directories contain 2 fewer
subdirectories than their hard link count. This option is
needed when searching filesystems that do not follow the Unix
directory-link convention, such as CD-ROM or MS-DOS filesystems
or AFS volume mount points. Each directory on a normal Unix
filesystem has at least 2 hard links: its name and its `.'
entry. Additionally, its subdirectories (if any) each have a
`..' entry linked to that directory. When find is examining a
directory, after it has statted 2 fewer subdirectories than the
directory's link count, it knows that the rest of the entries in
the directory are non-directories (`leaf' files in the directory
tree). If only the files' names need to be examined, there is
no need to stat them; this gives a significant increase in
search speed.
-version, --version
Print the find version number and exit.
-xdev Don't descend directories on other filesystems.
TESTS
Some tests, for example -newerXY and -samefile, allow comparison
between the file currently being examined and some reference file spec-
ified on the command line. When these tests are used, the interpreta-
tion of the reference file is determined by the options -H, -L and -P
and any previous -follow, but the reference file is only examined once,
at the time the command line is parsed. If the reference file cannot
be examined (for example, the stat(2) system call fails for it), an
error message is issued, and find exits with a nonzero status.
Numeric arguments can be specified as
+n for greater than n,
-n for less than n,
n for exactly n.
-amin n
File was last accessed n minutes ago.
-anewer file
File was last accessed more recently than file was modified. If
file is a symbolic link and the -H option or the -L option is in
effect, the access time of the file it points to is always used.
-atime n
File was last accessed n*24 hours ago. When find figures out
how many 24-hour periods ago the file was last accessed, any
fractional part is ignored, so to match -atime +1, a file has to
have been accessed at least two days ago.
-cmin n
File's status was last changed n minutes ago.
-cnewer file
File's status was last changed more recently than file was modi-
fied. If file is a symbolic link and the -H option or the -L
option is in effect, the status-change time of the file it
points to is always used.
-ctime n
File's status was last changed n*24 hours ago. See the comments
for -atime to understand how rounding affects the interpretation
of file status change times.
-empty File is empty and is either a regular file or a directory.
-executable
Matches files which are executable and directories which are
searchable (in a file name resolution sense). This takes into
account access control lists and other permissions artefacts
which the -perm test ignores. This test makes use of the
access(2) system call, and so can be fooled by NFS servers which
do UID mapping (or root-squashing), since many systems implement
access(2) in the client's kernel and so cannot make use of the
UID mapping information held on the server. Because this test
is based only on the result of the access(2) system call, there
is no guarantee that a file for which this test succeeds can
actually be executed.
-false Always false.
-fstype type
File is on a filesystem of type type. The valid filesystem
types vary among different versions of Unix; an incomplete list
of filesystem types that are accepted on some version of Unix or
another is: ufs, 4.2, 4.3, nfs, tmp, mfs, S51K, S52K. You can
use -printf with the %F directive to see the types of your
filesystems.
-gid n File's numeric group ID is n.
-group gname
File belongs to group gname (numeric group ID allowed).
-ilname pattern
Like -lname, but the match is case insensitive. If the -L
option or the -follow option is in effect, this test returns
false unless the symbolic link is broken.
-iname pattern
Like -name, but the match is case insensitive. For example, the
patterns `fo*' and `F??' match the file names `Foo', `FOO',
`foo', `fOo', etc. The pattern `*foo*` will also match a file
called '.foobar'.
-inum n
File has inode number n. It is normally easier to use the
-samefile test instead.
-ipath pattern
Like -path. but the match is case insensitive.
-iregex pattern
Like -regex, but the match is case insensitive.
-iwholename pattern
See -ipath. This alternative is less portable than -ipath.
-links n
File has n links.
-lname pattern
File is a symbolic link whose contents match shell pattern pat-
tern. The metacharacters do not treat `/' or `.' specially. If
the -L option or the -follow option is in effect, this test
returns false unless the symbolic link is broken.
-mmin n
File's data was last modified n minutes ago.
-mtime n
File's data was last modified n*24 hours ago. See the comments
for -atime to understand how rounding affects the interpretation
of file modification times.
-name pattern
Base of file name (the path with the leading directories
removed) matches shell pattern pattern. Because the leading
directories are removed, the file names considered for a match
with -name will never include a slash, so `-name a/b' will never
match anything (you probably need to use -path instead). A
warning is issued if you try to do this, unless the environment
variable POSIXLY_CORRECT is set. The metacharacters (`*', `?',
and `[]') match a `.' at the start of the base name (this is a
change in findutils-4.2.2; see section STANDARDS CONFORMANCE
below). To ignore a directory and the files under it, use
-prune; see an example in the description of -path. Braces are
not recognised as being special, despite the fact that some
shells including Bash imbue braces with a special meaning in
shell patterns. The filename matching is performed with the use
of the fnmatch(3) library function. Don't forget to enclose
the pattern in quotes in order to protect it from expansion by
the shell.
-newer file
File was modified more recently than file. If file is a sym-
bolic link and the -H option or the -L option is in effect, the
modification time of the file it points to is always used.
-newerXY reference
Succeeds if timestamp X of the file being considered is newer
than timestamp Y of the file reference. The letters X and Y
can be any of the following letters:
a The access time of the file reference
B The birth time of the file reference
c The inode status change time of reference
m The modification time of the file reference
t reference is interpreted directly as a time
Some combinations are invalid; for example, it is invalid for X
to be t. Some combinations are not implemented on all systems;
for example B is not supported on all systems. If an invalid or
unsupported combination of XY is specified, a fatal error
results. Time specifications are interpreted as for the argu-
ment to the -d option of GNU date. If you try to use the birth
time of a reference file, and the birth time cannot be deter-
mined, a fatal error message results. If you specify a test
which refers to the birth time of files being examined, this
test will fail for any files where the birth time is unknown.
-nogroup
No group corresponds to file's numeric group ID.
-nouser
No user corresponds to file's numeric user ID.
-path pattern
File name matches shell pattern pattern. The metacharacters do
not treat `/' or `.' specially; so, for example,
find . -path "./sr*sc"
will print an entry for a directory called `./src/misc' (if one
exists). To ignore a whole directory tree, use -prune rather
than checking every file in the tree. For example, to skip the
directory `src/emacs' and all files and directories under it,
and print the names of the other files found, do something like
this:
find . -path ./src/emacs -prune -o -print
Note that the pattern match test applies to the whole file name,
starting from one of the start points named on the command line.
It would only make sense to use an absolute path name here if
the relevant start point is also an absolute path. This means
that this command will never match anything:
find bar -path /foo/bar/myfile -print
Find compares the -path argument with the concatenation of a
directory name and the base name of the file it's examining.
Since the concatenation will never end with a slash, -path argu-
ments ending in a slash will match nothing (except perhaps a
start point specified on the command line). The predicate -path
is also supported by HP-UX find and will be in a forthcoming
version of the POSIX standard.
-perm mode
File's permission bits are exactly mode (octal or symbolic).
Since an exact match is required, if you want to use this form
for symbolic modes, you may have to specify a rather complex
mode string. For example `-perm g=w' will only match files
which have mode 0020 (that is, ones for which group write per-
mission is the only permission set). It is more likely that you
will want to use the `/' or `-' forms, for example `-perm -g=w',
which matches any file with group write permission. See the
EXAMPLES section for some illustrative examples.
-perm -mode
All of the permission bits mode are set for the file. Symbolic
modes are accepted in this form, and this is usually the way in
which you would want to use them. You must specify `u', `g' or
`o' if you use a symbolic mode. See the EXAMPLES section for
some illustrative examples.
-perm /mode
Any of the permission bits mode are set for the file. Symbolic
modes are accepted in this form. You must specify `u', `g' or
`o' if you use a symbolic mode. See the EXAMPLES section for
some illustrative examples. If no permission bits in mode are
set, this test matches any file (the idea here is to be consis-
tent with the behaviour of -perm -000).
-perm +mode
This is no longer supported (and has been deprecated since
2005). Use -perm /mode instead.
-readable
Matches files which are readable. This takes into account
access control lists and other permissions artefacts which the
-perm test ignores. This test makes use of the access(2) system
call, and so can be fooled by NFS servers which do UID mapping
(or root-squashing), since many systems implement access(2) in
the client's kernel and so cannot make use of the UID mapping
information held on the server.
-regex pattern
File name matches regular expression pattern. This is a match
on the whole path, not a search. For example, to match a file
named `./fubar3', you can use the regular expression `.*bar.' or
`.*b.*3', but not `f.*r3'. The regular expressions understood
by find are by default Emacs Regular Expressions, but this can
be changed with the -regextype option.
-samefile name
File refers to the same inode as name. When -L is in effect,
this can include symbolic links.
-size n[cwbkMG]
File uses n units of space, rounding up. The following suffixes
can be used:
`b' for 512-byte blocks (this is the default if no suffix is
used)
`c' for bytes
`w' for two-byte words
`k' for Kilobytes (units of 1024 bytes)
`M' for Megabytes (units of 1048576 bytes)
`G' for Gigabytes (units of 1073741824 bytes)
The size does not count indirect blocks, but it does count
blocks in sparse files that are not actually allocated. Bear in
mind that the `%k' and `%b' format specifiers of -printf handle
sparse files differently. The `b' suffix always denotes
512-byte blocks and never 1 Kilobyte blocks, which is different
to the behaviour of -ls. The + and - prefixes signify greater
than and less than, as usual, but bear in mind that the size is
rounded up to the next unit (so a 1-byte file is not matched by
-size -1M).
-true Always true.
-type c
File is of type c:
b block (buffered) special
c character (unbuffered) special
d directory
p named pipe (FIFO)
f regular file
l symbolic link; this is never true if the -L option or the
-follow option is in effect, unless the symbolic link is
broken. If you want to search for symbolic links when -L
is in effect, use -xtype.
s socket
D door (Solaris)
-uid n File's numeric user ID is n.
-used n
File was last accessed n days after its status was last changed.
-user uname
File is owned by user uname (numeric user ID allowed).
-wholename pattern
See -path. This alternative is less portable than -path.
-writable
Matches files which are writable. This takes into account
access control lists and other permissions artefacts which the
-perm test ignores. This test makes use of the access(2) system
call, and so can be fooled by NFS servers which do UID mapping
(or root-squashing), since many systems implement access(2) in
the client's kernel and so cannot make use of the UID mapping
information held on the server.
-xtype c
The same as -type unless the file is a symbolic link. For sym-
bolic links: if the -H or -P option was specified, true if the
file is a link to a file of type c; if the -L option has been
given, true if c is `l'. In other words, for symbolic links,
-xtype checks the type of the file that -type does not check.
-context pattern
(SELinux only) Security context of the file matches glob pat-
tern.
ACTIONS
-delete
Delete files; true if removal succeeded. If the removal failed,
an error message is issued. If -delete fails, find's exit sta-
tus will be nonzero (when it eventually exits). Use of -delete
automatically turns on the `-depth' option.
Warnings: Don't forget that the find command line is evaluated
as an expression, so putting -delete first will make find try to
delete everything below the starting points you specified. When
testing a find command line that you later intend to use with
-delete, you should explicitly specify -depth in order to avoid
later surprises. Because -delete implies -depth, you cannot
usefully use -prune and -delete together.
-exec command ;
Execute command; true if 0 status is returned. All following
arguments to find are taken to be arguments to the command until
an argument consisting of `;' is encountered. The string `{}'
is replaced by the current file name being processed everywhere
it occurs in the arguments to the command, not just in arguments
where it is alone, as in some versions of find. Both of these
constructions might need to be escaped (with a `\') or quoted to
protect them from expansion by the shell. See the EXAMPLES sec-
tion for examples of the use of the -exec option. The specified
command is run once for each matched file. The command is exe-
cuted in the starting directory. There are unavoidable secu-
rity problems surrounding use of the -exec action; you should
use the -execdir option instead.
-exec command {} +
This variant of the -exec action runs the specified command on
the selected files, but the command line is built by appending
each selected file name at the end; the total number of invoca-
tions of the command will be much less than the number of
matched files. The command line is built in much the same way
that xargs builds its command lines. Only one instance of `{}'
is allowed within the command. The command is executed in the
starting directory. If find encounters an error, this can some-
times cause an immediate exit, so some pending commands may not
be run at all. This variant of -exec always returns true.
-execdir command ;
-execdir command {} +
Like -exec, but the specified command is run from the subdirec-
tory containing the matched file, which is not normally the
directory in which you started find. This a much more secure
method for invoking commands, as it avoids race conditions dur-
ing resolution of the paths to the matched files. As with the
-exec action, the `+' form of -execdir will build a command line
to process more than one matched file, but any given invocation
of command will only list files that exist in the same subdirec-
tory. If you use this option, you must ensure that your $PATH
environment variable does not reference `.'; otherwise, an
attacker can run any commands they like by leaving an appropri-
ately-named file in a directory in which you will run -execdir.
The same applies to having entries in $PATH which are empty or
which are not absolute directory names. If find encounters an
error, this can sometimes cause an immediate exit, so some pend-
ing commands may not be run at all. The result of the action
depends on whether the + or the ; variant is being used;
-execdir command {} + always returns true, while -execdir com-
mand {} ; returns true only if command returns 0.
-fls file
True; like -ls but write to file like -fprint. The output file
is always created, even if the predicate is never matched. See
the UNUSUAL FILENAMES section for information about how unusual
characters in filenames are handled.
-fprint file
True; print the full file name into file file. If file does not
exist when find is run, it is created; if it does exist, it is
truncated. The file names `/dev/stdout' and `/dev/stderr' are
handled specially; they refer to the standard output and stan-
dard error output, respectively. The output file is always cre-
ated, even if the predicate is never matched. See the UNUSUAL
FILENAMES section for information about how unusual characters
in filenames are handled.
-fprint0 file
True; like -print0 but write to file like -fprint. The output
file is always created, even if the predicate is never matched.
See the UNUSUAL FILENAMES section for information about how
unusual characters in filenames are handled.
-fprintf file format
True; like -printf but write to file like -fprint. The output
file is always created, even if the predicate is never matched.
See the UNUSUAL FILENAMES section for information about how
unusual characters in filenames are handled.
-ls True; list current file in ls -dils format on standard output.
The block counts are of 1K blocks, unless the environment vari-
able POSIXLY_CORRECT is set, in which case 512-byte blocks are
used. See the UNUSUAL FILENAMES section for information about
how unusual characters in filenames are handled.
-ok command ;
Like -exec but ask the user first. If the user agrees, run the
command. Otherwise just return false. If the command is run,
its standard input is redirected from /dev/null.
The response to the prompt is matched against a pair of regular
expressions to determine if it is an affirmative or negative
response. This regular expression is obtained from the system
if the `POSIXLY_CORRECT' environment variable is set, or other-
wise from find's message translations. If the system has no
suitable definition, find's own definition will be used. In
either case, the interpretation of the regular expression itself
will be affected by the environment variables 'LC_CTYPE' (char-
acter classes) and 'LC_COLLATE' (character ranges and equiva-
lence classes).
-okdir command ;
Like -execdir but ask the user first in the same way as for -ok.
If the user does not agree, just return false. If the command
is run, its standard input is redirected from /dev/null.
-print True; print the full file name on the standard output, followed
by a newline. If you are piping the output of find into
another program and there is the faintest possibility that the
files which you are searching for might contain a newline, then
you should seriously consider using the -print0 option instead
of -print. See the UNUSUAL FILENAMES section for information
about how unusual characters in filenames are handled.
-print0
True; print the full file name on the standard output, followed
by a null character (instead of the newline character that
-print uses). This allows file names that contain newlines or
other types of white space to be correctly interpreted by pro-
grams that process the find output. This option corresponds to
the -0 option of xargs.
-printf format
True; print format on the standard output, interpreting `\'
escapes and `%' directives. Field widths and precisions can be
specified as with the `printf' C function. Please note that
many of the fields are printed as %s rather than %d, and this
may mean that flags don't work as you might expect. This also
means that the `-' flag does work (it forces fields to be left-
aligned). Unlike -print, -printf does not add a newline at the
end of the string. The escapes and directives are:
\a Alarm bell.
\b Backspace.
\c Stop printing from this format immediately and flush the
output.
\f Form feed.
\n Newline.
\r Carriage return.
\t Horizontal tab.
\v Vertical tab.
\0 ASCII NUL.
\\ A literal backslash (`\').
\NNN The character whose ASCII code is NNN (octal).
A `\' character followed by any other character is treated as an
ordinary character, so they both are printed.
%% A literal percent sign.
%a File's last access time in the format returned by the C
`ctime' function.
%Ak File's last access time in the format specified by k,
which is either `@' or a directive for the C `strftime'
function. The possible values for k are listed below;
some of them might not be available on all systems, due
to differences in `strftime' between systems.
@ seconds since Jan. 1, 1970, 00:00 GMT, with frac-
tional part.
Time fields:
H hour (00..23)
I hour (01..12)
k hour ( 0..23)
l hour ( 1..12)
M minute (00..59)
p locale's AM or PM
r time, 12-hour (hh:mm:ss [AP]M)
S Second (00.00 .. 61.00). There is a fractional
part.
T time, 24-hour (hh:mm:ss)
+ Date and time, separated by `+', for example
`2004-04-28+22:22:05.0'. This is a GNU extension.
The time is given in the current timezone (which
may be affected by setting the TZ environment
variable). The seconds field includes a frac-
tional part.
X locale's time representation (H:M:S)
Z time zone (e.g., EDT), or nothing if no time zone
is determinable
Date fields:
a locale's abbreviated weekday name (Sun..Sat)
A locale's full weekday name, variable length (Sun-
day..Saturday)
b locale's abbreviated month name (Jan..Dec)
B locale's full month name, variable length (Janu-
ary..December)
c locale's date and time (Sat Nov 04 12:02:33 EST
1989). The format is the same as for ctime(3) and
so to preserve compatibility with that format,
there is no fractional part in the seconds field.
d day of month (01..31)
D date (mm/dd/yy)
h same as b
j day of year (001..366)
m month (01..12)
U week number of year with Sunday as first day of
week (00..53)
w day of week (0..6)
W week number of year with Monday as first day of
week (00..53)
x locale's date representation (mm/dd/yy)
y last two digits of year (00..99)
Y year (1970...)
%b The amount of disk space used for this file in 512-byte
blocks. Since disk space is allocated in multiples of
the filesystem block size this is usually greater than
%s/512, but it can also be smaller if the file is a
sparse file.
%c File's last status change time in the format returned by
the C `ctime' function.
%Ck File's last status change time in the format specified by
k, which is the same as for %A.
%d File's depth in the directory tree; 0 means the file is a
starting-point.
%D The device number on which the file exists (the st_dev
field of struct stat), in decimal.
%f File's name with any leading directories removed (only
the last element).
%F Type of the filesystem the file is on; this value can be
used for -fstype.
%g File's group name, or numeric group ID if the group has
no name.
%G File's numeric group ID.
%h Leading directories of file's name (all but the last ele-
ment). If the file name contains no slashes (since it is
in the current directory) the %h specifier expands to
".".
%H Starting-point under which file was found.
%i File's inode number (in decimal).
%k The amount of disk space used for this file in 1K blocks.
Since disk space is allocated in multiples of the
filesystem block size this is usually greater than
%s/1024, but it can also be smaller if the file is a
sparse file.
%l Object of symbolic link (empty string if file is not a
symbolic link).
%m File's permission bits (in octal). This option uses the
`traditional' numbers which most Unix implementations
use, but if your particular implementation uses an
unusual ordering of octal permissions bits, you will see
a difference between the actual value of the file's mode
and the output of %m. Normally you will want to have a
leading zero on this number, and to do this, you should
use the # flag (as in, for example, `%#m').
%M File's permissions (in symbolic form, as for ls). This
directive is supported in findutils 4.2.5 and later.
%n Number of hard links to file.
%p File's name.
%P File's name with the name of the starting-point under
which it was found removed.
%s File's size in bytes.
%S File's sparseness. This is calculated as (BLOCK-
SIZE*st_blocks / st_size). The exact value you will get
for an ordinary file of a certain length is system-depen-
dent. However, normally sparse files will have values
less than 1.0, and files which use indirect blocks may
have a value which is greater than 1.0. The value used
for BLOCKSIZE is system-dependent, but is usually 512
bytes. If the file size is zero, the value printed is
undefined. On systems which lack support for st_blocks,
a file's sparseness is assumed to be 1.0.
%t File's last modification time in the format returned by
the C `ctime' function.
%Tk File's last modification time in the format specified by
k, which is the same as for %A.
%u File's user name, or numeric user ID if the user has no
name.
%U File's numeric user ID.
%y File's type (like in ls -l), U=unknown type (shouldn't
happen)
%Y File's type (like %y), plus follow symlinks: L=loop,
N=nonexistent
%Z (SELinux only) file's security context.
%{ %[ %(
Reserved for future use.
A `%' character followed by any other character is discarded,
but the other character is printed (don't rely on this, as fur-
ther format characters may be introduced). A `%' at the end of
the format argument causes undefined behaviour since there is no
following character. In some locales, it may hide your door
keys, while in others it may remove the final page from the
novel you are reading.
The %m and %d directives support the # , 0 and + flags, but the
other directives do not, even if they print numbers. Numeric
directives that do not support these flags include G, U, b, D, k
and n. The `-' format flag is supported and changes the align-
ment of a field from right-justified (which is the default) to
left-justified.
See the UNUSUAL FILENAMES section for information about how
unusual characters in filenames are handled.
-prune True; if the file is a directory, do not descend into it. If
-depth is given, false; no effect. Because -delete implies
-depth, you cannot usefully use -prune and -delete together.
-quit Exit immediately. No child processes will be left running, but
no more paths specified on the command line will be processed.
For example, find /tmp/foo /tmp/bar -print -quit will print only
/tmp/foo. Any command lines which have been built up with
-execdir ... {} + will be invoked before find exits. The exit
status may or may not be zero, depending on whether an error has
already occurred.
OPERATORS
Listed in order of decreasing precedence:
( expr )
Force precedence. Since parentheses are special to the shell,
you will normally need to quote them. Many of the examples in
this manual page use backslashes for this purpose: `\(...\)'
instead of `(...)'.
! expr True if expr is false. This character will also usually need
protection from interpretation by the shell.
-not expr
Same as ! expr, but not POSIX compliant.
expr1 expr2
Two expressions in a row are taken to be joined with an implied
"and"; expr2 is not evaluated if expr1 is false.
expr1 -a expr2
Same as expr1 expr2.
expr1 -and expr2
Same as expr1 expr2, but not POSIX compliant.
expr1 -o expr2
Or; expr2 is not evaluated if expr1 is true.
expr1 -or expr2
Same as expr1 -o expr2, but not POSIX compliant.
expr1 , expr2
List; both expr1 and expr2 are always evaluated. The value of
expr1 is discarded; the value of the list is the value of expr2.
The comma operator can be useful for searching for several dif-
ferent types of thing, but traversing the filesystem hierarchy
only once. The -fprintf action can be used to list the various
matched items into several different output files.
UNUSUAL FILENAMES
Many of the actions of find result in the printing of data which is
under the control of other users. This includes file names, sizes,
modification times and so forth. File names are a potential problem
since they can contain any character except `\0' and `/'. Unusual
characters in file names can do unexpected and often undesirable things
to your terminal (for example, changing the settings of your function
keys on some terminals). Unusual characters are handled differently by
various actions, as described below.
-print0, -fprint0
Always print the exact filename, unchanged, even if the output
is going to a terminal.
-ls, -fls
Unusual characters are always escaped. White space, backslash,
and double quote characters are printed using C-style escaping
(for example `\f', `\"'). Other unusual characters are printed
using an octal escape. Other printable characters (for -ls and
-fls these are the characters between octal 041 and 0176) are
printed as-is.
-printf, -fprintf
If the output is not going to a terminal, it is printed as-is.
Otherwise, the result depends on which directive is in use. The
directives %D, %F, %g, %G, %H, %Y, and %y expand to values which
are not under control of files' owners, and so are printed as-
is. The directives %a, %b, %c, %d, %i, %k, %m, %M, %n, %s, %t,
%u and %U have values which are under the control of files' own-
ers but which cannot be used to send arbitrary data to the ter-
minal, and so these are printed as-is. The directives %f, %h,
%l, %p and %P are quoted. This quoting is performed in the same
way as for GNU ls. This is not the same quoting mechanism as
the one used for -ls and -fls. If you are able to decide what
format to use for the output of find then it is normally better
to use `\0' as a terminator than to use newline, as file names
can contain white space and newline characters. The setting of
the `LC_CTYPE' environment variable is used to determine which
characters need to be quoted.
-print, -fprint
Quoting is handled in the same way as for -printf and -fprintf.
If you are using find in a script or in a situation where the
matched files might have arbitrary names, you should consider
using -print0 instead of -print.
The -ok and -okdir actions print the current filename as-is. This may
change in a future release.
STANDARDS CONFORMANCE
For closest compliance to the POSIX standard, you should set the
POSIXLY_CORRECT environment variable. The following options are speci-
fied in the POSIX standard (IEEE Std 1003.1, 2003 Edition):
-H This option is supported.
-L This option is supported.
-name This option is supported, but POSIX conformance depends on the
POSIX conformance of the system's fnmatch(3) library function.
As of findutils-4.2.2, shell metacharacters (`*', `?' or `[]'
for example) will match a leading `.', because IEEE PASC inter-
pretation 126 requires this. This is a change from previous
versions of findutils.
-type Supported. POSIX specifies `b', `c', `d', `l', `p', `f' and
`s'. GNU find also supports `D', representing a Door, where the
OS provides these.
-ok Supported. Interpretation of the response is according to the
"yes" and "no" patterns selected by setting the `LC_MESSAGES'
environment variable. When the `POSIXLY_CORRECT' environment
variable is set, these patterns are taken system's definition of
a positive (yes) or negative (no) response. See the system's
documentation for nl_langinfo(3), in particular YESEXPR and
NOEXPR. When `POSIXLY_CORRECT' is not set, the patterns are
instead taken from find's own message catalogue.
-newer Supported. If the file specified is a symbolic link, it is
always dereferenced. This is a change from previous behaviour,
which used to take the relevant time from the symbolic link; see
the HISTORY section below.
-perm Supported. If the POSIXLY_CORRECT environment variable is not
set, some mode arguments (for example +a+x) which are not valid
in POSIX are supported for backward-compatibility.
Other predicates
The predicates -atime, -ctime, -depth, -group, -links, -mtime,
-nogroup, -nouser, -print, -prune, -size, -user and -xdev
`-atime', `-ctime', `-depth', `-group', `-links', `-mtime',
`-nogroup', `-nouser', `-perm', `-print', `-prune', `-size',
`-user' and `-xdev', are all supported.
The POSIX standard specifies parentheses `(', `)', negation `!' and the
`and' and `or' operators ( -a, -o).
All other options, predicates, expressions and so forth are extensions
beyond the POSIX standard. Many of these extensions are not unique to
GNU find, however.
The POSIX standard requires that find detects loops:
The find utility shall detect infinite loops; that is, entering
a previously visited directory that is an ancestor of the last
file encountered. When it detects an infinite loop, find shall
write a diagnostic message to standard error and shall either
recover its position in the hierarchy or terminate.
GNU find complies with these requirements. The link count of directo-
ries which contain entries which are hard links to an ancestor will
often be lower than they otherwise should be. This can mean that GNU
find will sometimes optimise away the visiting of a subdirectory which
is actually a link to an ancestor. Since find does not actually enter
such a subdirectory, it is allowed to avoid emitting a diagnostic mes-
sage. Although this behaviour may be somewhat confusing, it is
unlikely that anybody actually depends on this behaviour. If the leaf
optimisation has been turned off with -noleaf, the directory entry will
always be examined and the diagnostic message will be issued where it
is appropriate. Symbolic links cannot be used to create filesystem
cycles as such, but if the -L option or the -follow option is in use, a
diagnostic message is issued when find encounters a loop of symbolic
links. As with loops containing hard links, the leaf optimisation will
often mean that find knows that it doesn't need to call stat() or
chdir() on the symbolic link, so this diagnostic is frequently not nec-
essary.
The -d option is supported for compatibility with various BSD systems,
but you should use the POSIX-compliant option -depth instead.
The POSIXLY_CORRECT environment variable does not affect the behaviour
of the -regex or -iregex tests because those tests aren't specified in
the POSIX standard.
ENVIRONMENT VARIABLES
LANG Provides a default value for the internationalization variables
that are unset or null.
LC_ALL If set to a non-empty string value, override the values of all
the other internationalization variables.
LC_COLLATE
The POSIX standard specifies that this variable affects the pat-
tern matching to be used for the -name option. GNU find uses
the fnmatch(3) library function, and so support for `LC_COLLATE'
depends on the system library. This variable also affects the
interpretation of the response to -ok; while the `LC_MESSAGES'
variable selects the actual pattern used to interpret the
response to -ok, the interpretation of any bracket expressions
in the pattern will be affected by `LC_COLLATE'.
LC_CTYPE
This variable affects the treatment of character classes used in
regular expressions and also with the -name test, if the sys-
tem's fnmatch(3) library function supports this. This variable
also affects the interpretation of any character classes in the
regular expressions used to interpret the response to the prompt
issued by -ok. The `LC_CTYPE' environment variable will also
affect which characters are considered to be unprintable when
filenames are printed; see the section UNUSUAL FILENAMES.
LC_MESSAGES
Determines the locale to be used for internationalised messages.
If the `POSIXLY_CORRECT' environment variable is set, this also
determines the interpretation of the response to the prompt made
by the -ok action.
NLSPATH
Determines the location of the internationalisation message cat-
alogues.
PATH Affects the directories which are searched to find the executa-
bles invoked by -exec, -execdir, -ok and -okdir.
POSIXLY_CORRECT
Determines the block size used by -ls and -fls. If POSIXLY_COR-
RECT is set, blocks are units of 512 bytes. Otherwise they are
units of 1024 bytes.
Setting this variable also turns off warning messages (that is,
implies -nowarn) by default, because POSIX requires that apart
from the output for -ok, all messages printed on stderr are
diagnostics and must result in a non-zero exit status.
When POSIXLY_CORRECT is not set, -perm +zzz is treated just like
-perm /zzz if +zzz is not a valid symbolic mode. When
POSIXLY_CORRECT is set, such constructs are treated as an error.
When POSIXLY_CORRECT is set, the response to the prompt made by
the -ok action is interpreted according to the system's message
catalogue, as opposed to according to find's own message trans-
lations.
TZ Affects the time zone used for some of the time-related format
directives of -printf and -fprintf.
EXAMPLES
find /tmp -name core -type f -print | xargs /bin/rm -f
Find files named core in or below the directory /tmp and delete them.
Note that this will work incorrectly if there are any filenames con-
taining newlines, single or double quotes, or spaces.
find /tmp -name core -type f -print0 | xargs -0 /bin/rm -f
Find files named core in or below the directory /tmp and delete them,
processing filenames in such a way that file or directory names con-
taining single or double quotes, spaces or newlines are correctly han-
dled. The -name test comes before the -type test in order to avoid
having to call stat(2) on every file.
find . -type f -exec file '{}' \;
Runs `file' on every file in or below the current directory. Notice
that the braces are enclosed in single quote marks to protect them from
interpretation as shell script punctuation. The semicolon is similarly
protected by the use of a backslash, though single quotes could have
been used in that case also.
find / \( -perm -4000 -fprintf /root/suid.txt '%#m %u %p\n' \) , \
\( -size +100M -fprintf /root/big.txt '%-10s %p\n' \)
Traverse the filesystem just once, listing setuid files and directories
into /root/suid.txt and large files into /root/big.txt.
find $HOME -mtime 0
Search for files in your home directory which have been modified in the
last twenty-four hours. This command works this way because the time
since each file was last modified is divided by 24 hours and any
remainder is discarded. That means that to match -mtime 0, a file will
have to have a modification in the past which is less than 24 hours
ago.
find /sbin /usr/sbin -executable \! -readable -print
Search for files which are executable but not readable.
find . -perm 664
Search for files which have read and write permission for their owner,
and group, but which other users can read but not write to. Files
which meet these criteria but have other permissions bits set (for
example if someone can execute the file) will not be matched.
find . -perm -664
Search for files which have read and write permission for their owner
and group, and which other users can read, without regard to the pres-
ence of any extra permission bits (for example the executable bit).
This will match a file which has mode 0777, for example.
find . -perm /222
Search for files which are writable by somebody (their owner, or their
group, or anybody else).
find . -perm /220
find . -perm /u+w,g+w
find . -perm /u=w,g=w
All three of these commands do the same thing, but the first one uses
the octal representation of the file mode, and the other two use the
symbolic form. These commands all search for files which are writable
by either their owner or their group. The files don't have to be
writable by both the owner and group to be matched; either will do.
find . -perm -220
find . -perm -g+w,u+w
Both these commands do the same thing; search for files which are
writable by both their owner and their group.
find . -perm -444 -perm /222 ! -perm /111
find . -perm -a+r -perm /a+w ! -perm /a+x
These two commands both search for files that are readable for every-
body ( -perm -444 or -perm -a+r), have at least one write bit set (
-perm /222 or -perm /a+w) but are not executable for anybody ( ! -perm
/111 and ! -perm /a+x respectively).
cd /source-dir
find . -name .snapshot -prune -o \( \! -name *~ -print0 \)|
cpio -pmd0 /dest-dir
This command copies the contents of /source-dir to /dest-dir, but omits
files and directories named .snapshot (and anything in them). It also
omits files or directories whose name ends in ~, but not their con-
tents. The construct -prune -o \( ... -print0 \) is quite common. The
idea here is that the expression before -prune matches things which are
to be pruned. However, the -prune action itself returns true, so the
following -o ensures that the right hand side is evaluated only for
those directories which didn't get pruned (the contents of the pruned
directories are not even visited, so their contents are irrelevant).
The expression on the right hand side of the -o is in parentheses only
for clarity. It emphasises that the -print0 action takes place only
for things that didn't have -prune applied to them. Because the
default `and' condition between tests binds more tightly than -o, this
is the default anyway, but the parentheses help to show what is going
on.
find repo/ -exec test -d {}/.svn \; -or \
-exec test -d {}/.git \; -or -exec test -d {}/CVS \; \
-print -prune
Given the following directory of projects and their associated SCM
administrative directories, perform an efficient search for the
projects' roots:
repo/project1/CVS
repo/gnu/project2/.svn
repo/gnu/project3/.svn
repo/gnu/project3/src/.svn
repo/project4/.git
In this example, -prune prevents unnecessary descent into directories
that have already been discovered (for example we do not search
project3/src because we already found project3/.svn), but ensures sib-
ling directories (project2 and project3) are found.
EXIT STATUS
find exits with status 0 if all files are processed successfully,
greater than 0 if errors occur. This is deliberately a very broad
description, but if the return value is non-zero, you should not rely
on the correctness of the results of find.
When some error occurs, find may stop immediately, without completing
all the actions specified. For example, some starting points may not
have been examined or some pending program invocations for -exec ... {}
+ or -execdir ... {} + may not have been performed.
SEE ALSO
locate(1), locatedb(5), updatedb(1), xargs(1), chmod(1), fnmatch(3),
regex(7), stat(2), lstat(2), ls(1), printf(3), strftime(3), ctime(3)
The full documentation for find is maintained as a Texinfo manual. If
the info and find programs are properly installed at your site, the
command info find should give you access to the complete manual.
HISTORY
As of findutils-4.2.2, shell metacharacters (`*', `?' or `[]' for exam-
ple) used in filename patterns will match a leading `.', because IEEE
POSIX interpretation 126 requires this.
As of findutils-4.3.3, -perm /000 now matches all files instead of
none.
Nanosecond-resolution timestamps were implemented in findutils-4.3.3.
As of findutils-4.3.11, the -delete action sets find's exit status to a
nonzero value when it fails. However, find will not exit immediately.
Previously, find's exit status was unaffected by the failure of
-delete.
Feature Added in Also occurs in
-newerXY 4.3.3 BSD
-D 4.3.1
-O 4.3.1
-readable 4.3.0
-writable 4.3.0
-executable 4.3.0
-regextype 4.2.24
-exec ... + 4.2.12 POSIX
-execdir 4.2.12 BSD
-okdir 4.2.12
-samefile 4.2.11
-H 4.2.5 POSIX
-L 4.2.5 POSIX
-P 4.2.5 BSD
-delete 4.2.3
-quit 4.2.3
-d 4.2.3 BSD
-wholename 4.2.0
-iwholename 4.2.0
-ignore_readdir_race 4.2.0
-fls 4.0
-ilname 3.8
-iname 3.8
-ipath 3.8
-iregex 3.8
The syntax -perm +MODE was removed in findutils-4.5.12, in favour of
-perm /MODE. The +MODE syntax had been deprecated since findu-
tils-4.2.21 which was released in 2005.
NON-BUGS
$ find . -name *.c -print
find: paths must precede expression
Usage: find [-H] [-L] [-P] [-Olevel] [-D help|tree|search|stat|rates|opt|exec] [path...] [expression]
This happens because *.c has been expanded by the shell resulting in
find actually receiving a command line like this:
find . -name bigram.c code.c frcode.c locate.c -print
That command is of course not going to work. Instead of doing things
this way, you should enclose the pattern in quotes or escape the wild-
card:
$ find . -name '*.c' -print
$ find . -name \*.c -print
BUGS
There are security problems inherent in the behaviour that the POSIX
standard specifies for find, which therefore cannot be fixed. For
example, the -exec action is inherently insecure, and -execdir should
be used instead. Please see Finding Files for more information.
The environment variable LC_COLLATE has no effect on the -ok action.
The best way to report a bug is to use the form at http://savan-
nah.gnu.org/bugs/?group=findutils. The reason for this is that you
will then be able to track progress in fixing the problem. Other com-
ments about find(1) and about the findutils package in general can be
sent to the bug-findutils mailing list. To join the list, send email
to bug-findutils-request@gnu.org.
FIND(1)
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 21:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-11 0:14 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 0:14 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams
Manuel Giraud <manuel@ledu-giraud.fr> writes:
> Daniel Martín <mardani29@yahoo.es> writes:
>
> [...]
>
>> This bug also affects macOS. After reading the code I'd say that, even
>> on GNU/Linux, there are probably other corner cases where
>> dired-goto-file would fail:
>
> Thanks for the test. I have some questions:
>
> - Have you seen this bug even on a non 'find-dired' buffer?
>
I haven't noticed this problem in regular Dired buffers, only in
find-dired buffers.
> - Same question as Drew: What are your value of 'system-type' and
> 'find-ls-option-default-ls'
system-type
=> darwin
find-ls-option-default-ls
=> ("-ls" . "-dilsb")
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-11 11:55 ` Eli Zaretskii
2023-03-11 14:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-11 11:55 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams
> Cc: "62096@debbugs.gnu.org" <62096@debbugs.gnu.org>,
> Drew Adams <drew.adams@oracle.com>
> Date: Fri, 10 Mar 2023 19:37:44 +0100
> From: Manuel Giraud via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Ok, so commenting the string-replace at dired.el:3529 in
> 'dired-goto-file-1' (ie. not replacing " " with "\\ ") does the trick
> for me...
>
> That being said those are here for a reason. It might be a difference
> between OpenBSD's find and the GNU one (I don't know for Windows).
This bug doesn't happen on Windows, so please don't remove the
replacement unconditionally. There's some other factor at work here.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 19:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:55 ` Drew Adams
@ 2023-03-11 11:58 ` Eli Zaretskii
1 sibling, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-11 11:58 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams
> Cc: "62096@debbugs.gnu.org" <62096@debbugs.gnu.org>,
> Drew Adams <drew.adams@oracle.com>
> Date: Fri, 10 Mar 2023 20:05:04 +0100
> From: Manuel Giraud via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I almost got it. It comes from the test on the switches used to build
> the dired buffer.
>
> For a "standard" dired build with ls, on OpenBSD, I just have "-al" as
> switches: no "b" so it doesn't trigger the string-replace.
>
> For a find-dired buffer, on OpenBSD, I have "-gilsb" as switches: there
> is a "b" that triggers the string-replace (which is not needed here).
>
> I think that the fix should be "test the b switch only for ls built
> dired". I don't know if it will fix Windows.
Sorry, I don't understand: this bug report started with running
find-dired, but now you are talking about something different AFAIU?
On MS-Windows, Emacs doesn't use ls, it uses ls-lisp.el, and that
emulation doesn't support the -b switch of ls. Not sure what this
means, since I don't yet understand what are you describing and how is
the -b switch relevant.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:31 ` Drew Adams
@ 2023-03-11 12:00 ` Eli Zaretskii
2023-03-12 10:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
3 siblings, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-11 12:00 UTC (permalink / raw)
To: Daniel Martín; +Cc: 62096, stephen.berman, manuel, drew.adams
> Cc: stephen.berman@gmx.net, drew.adams@oracle.com, manuel@ledu-giraud.fr
> Date: Fri, 10 Mar 2023 21:48:04 +0100
> From: Daniel Martín via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
> > Ok, so commenting the string-replace at dired.el:3529 in
> > 'dired-goto-file-1' (ie. not replacing " " with "\\ ") does the trick
> > for me...
> >
> > That being said those are here for a reason. It might be a difference
> > between OpenBSD's find and the GNU one (I don't know for Windows).
>
> This bug also affects macOS. After reading the code I'd say that, even
> on GNU/Linux, there are probably other corner cases where
> dired-goto-file would fail:
>
> ;; FIXME: to fix this for embedded control characters etc, we
> ;; should escape everything that `ls -b' does.
> (setq str (string-replace " " "\\ " str)
> str (string-replace "\t" "\\t" str)
> str (string-replace "\n" "\\n" str))
>
> For example, on GNU/Linux, ls -b outputs:
>
> vacation\ 2022
>
> while on macOS it outputs:
>
> vacation 2022
Shouldn't we be talking ab out what "find ... -ls" produces instead?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 0:14 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-11 14:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:17 ` Eli Zaretskii
2023-03-11 17:09 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 14:02 UTC (permalink / raw)
To: Daniel Martín; +Cc: 62096, stephen.berman, drew.adams
[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]
Hi,
So here is a patch that should fix *BSD and macOS. For Windows, I don't
know if it is the right fix (so it does nothing on Windows, sorry Drew).
I choose "-dgils" because FreeBSD, NetBSD and macOS man pages state the
following about -ls switch for find(1):
The format is identical to that produced by "ls -dgils".
On OpenBSD, the find(1) man page says:
The format is identical to that produced by "ls -dils".
But the "-g" switch does not seems to do something different when the
"-l" is present.
For testing without recompiling Emacs, one could evaluate this:
--8<---------------cut here---------------start------------->8---
(setq find-ls-option-default-ls
(cons "-ls" (if (or (eq system-type 'berkeley-unix)
(eq system-type 'darwin))
"-dgils"
"-dilsb")))
--8<---------------cut here---------------end--------------->8---
Daniel: I'd like to hear what it does on macOS.
Drew: You could test on your system by "forcing"
'find-ls-option-default-ls' with the following:
--8<---------------cut here---------------start------------->8---
(setq find-ls-option-default-ls (cons "-ls" "-dils"))
--8<---------------cut here---------------end--------------->8---
This patch was produce on the main branch but FWIW I think it should
also go on emacs-29.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-find-ls-option-default-ls-for-BSD-MacOS-bug-6209.patch --]
[-- Type: text/x-patch, Size: 1049 bytes --]
From c9d343babc2ddc65066082669639964a7ddba017 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 10 Mar 2023 21:54:00 +0100
Subject: [PATCH] Fix 'find-ls-option-default-ls' for BSD/MacOS (bug#62096)
* lisp/find-dired.el (find-ls-option-default-ls): Adapt to a value
that works with OpenBSD and should also work with (Free|Net)BSD and
Darwin/MacOS.
---
lisp/find-dired.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/find-dired.el b/lisp/find-dired.el
index 33376ee4ed9..8f5aaa5f682 100644
--- a/lisp/find-dired.el
+++ b/lisp/find-dired.el
@@ -51,7 +51,10 @@ find-exec-terminator
:type 'string)
(defvar find-ls-option-default-ls
- (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
+ (cons "-ls" (if (or (eq system-type 'berkeley-unix)
+ (eq system-type 'darwin))
+ "-dgils"
+ "-dilsb")))
(defvar find-ls-option-default-exec
(cons (format "-exec ls -ld {} %s" find-exec-terminator) "-ld"))
--
2.39.1
[-- Attachment #3: Type: text/plain, Size: 18 bytes --]
--
Manuel Giraud
^ permalink raw reply related [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 11:55 ` Eli Zaretskii
@ 2023-03-11 14:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 14:12 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams
Eli Zaretskii <eliz@gnu.org> writes:
[...]
> This bug doesn't happen on Windows, so please don't remove the
> replacement unconditionally. There's some other factor at work here.
Hi Eli,
Yes, removing this replacement was just for testing. My final patch is
just a modification of 'find-ls-option-default-ls' and AFAIK it won't do
anything on Windows.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 14:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-11 14:17 ` Eli Zaretskii
2023-03-11 14:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 17:09 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 2 replies; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-11 14:17 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams, mardani29
> Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net, drew.adams@oracle.com
> Date: Sat, 11 Mar 2023 15:02:44 +0100
> From: Manuel Giraud via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> This patch was produce on the main branch but FWIW I think it should
> also go on emacs-29.
I'm okay with installing this on emacs-29, since macOS is supposed to
be a variant of BSD.
But please don't change the values for any other systems, not on the
release branch anyway.
Thanks.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 14:17 ` Eli Zaretskii
@ 2023-03-11 14:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 7:49 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 14:27 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, mardani29
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net, drew.adams@oracle.com
>> Date: Sat, 11 Mar 2023 15:02:44 +0100
>> From: Manuel Giraud via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> This patch was produce on the main branch but FWIW I think it should
>> also go on emacs-29.
>
> I'm okay with installing this on emacs-29, since macOS is supposed to
> be a variant of BSD.
>
> But please don't change the values for any other systems, not on the
> release branch anyway.
I think that my patch does just that: it modifies the value for
'berkeley-unix or 'darwin systems only. Before you would install it on
emacs-29, I'd like to see what it does on macOS (Daniel seems to run
this system).
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 14:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:17 ` Eli Zaretskii
@ 2023-03-11 17:09 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 18:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 52+ messages in thread
From: Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 17:09 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams
Manuel Giraud <manuel@ledu-giraud.fr> writes:
> Hi,
>
> So here is a patch that should fix *BSD and macOS. For Windows, I don't
> know if it is the right fix (so it does nothing on Windows, sorry Drew).
>
> I choose "-dgils" because FreeBSD, NetBSD and macOS man pages state the
> following about -ls switch for find(1):
> The format is identical to that produced by "ls -dgils".
>
> On OpenBSD, the find(1) man page says:
> The format is identical to that produced by "ls -dils".
>
> But the "-g" switch does not seems to do something different when the
> "-l" is present.
This is what I see on macOS:
$ find . -name "*.jpg" -ls
93775284 0 -rw-r--r-- 1 dmartin staff 0 Mar 10 18:33 ./we needed space.jpg
$ ls -dgils *.jpg
93775284 0 -rw-r--r-- 1 staff 0 Mar 10 18:33 we needed space.jpg
$ ls -dils *.jpg
93775284 0 -rw-r--r-- 1 dmartin staff 0 Mar 10 18:33 we needed space.jpg
The -g switch seems to add/remove the group column, despite the man page
saying that the switch has no effect.
As you can see, the output of find -ls on macOS really seems to match
the output of ls -dils better, which is in concordance with the OpenBSD
documentation.
>
> For testing without recompiling Emacs, one could evaluate this:
>
> (setq find-ls-option-default-ls
> (cons "-ls" (if (or (eq system-type 'berkeley-unix)
> (eq system-type 'darwin))
> "-dgils"
> "-dilsb")))
>
>
> Daniel: I'd like to hear what it does on macOS.
>
I've tested your patch and it seems to work fine on macOS. However,
users can install GNU findutils on macOS, and in those systems the bug
would still be present.
Is there a more reliable way to discern between GNU find and other find
implementations, without checking the system-type?
I know the GNU version of find supports --version, while the macOS find
returns an error, but I don't know how reliable that check would be.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 17:09 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-11 18:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 19:30 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 18:46 UTC (permalink / raw)
To: Daniel Martín; +Cc: 62096, stephen.berman, drew.adams
Daniel Martín <mardani29@yahoo.es> writes:
[...]
>> For testing without recompiling Emacs, one could evaluate this:
>>
>> (setq find-ls-option-default-ls
>> (cons "-ls" (if (or (eq system-type 'berkeley-unix)
>> (eq system-type 'darwin))
>> "-dgils"
>> "-dilsb")))
>>
>>
>> Daniel: I'd like to hear what it does on macOS.
>>
>
> I've tested your patch and it seems to work fine on macOS. However,
> users can install GNU findutils on macOS, and in those systems the bug
> would still be present.
Thanks for those tests.
> Is there a more reliable way to discern between GNU find and other find
> implementations, without checking the system-type?
Maybe this can be the subject for another bug report? Or you can
improve on this one? WDYT?
Me, I think that we could apply as is to emacs-29. FreeBSD and NetBSD
have not been tested on but at least we are in line with their find(1)
man page. Is there any other 'berkeley-unix system?
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 18:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-11 19:30 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 52+ messages in thread
From: Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-11 19:30 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams
Manuel Giraud <manuel@ledu-giraud.fr> writes:
>
>> Is there a more reliable way to discern between GNU find and other find
>> implementations, without checking the system-type?
>
> Maybe this can be the subject for another bug report? Or you can
> improve on this one? WDYT?
>
Yes, that can be a separate report. If the check can be improved, it
probably affects more than find-dired.
> Me, I think that we could apply as is to emacs-29. FreeBSD and NetBSD
> have not been tested on but at least we are in line with their find(1)
> man page. Is there any other 'berkeley-unix system?
Looking at configure.ac, there's also https://www.dragonflybsd.org/, but
it looks like just another FreeBSD.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 14:17 ` Eli Zaretskii
2023-03-11 14:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-12 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 11:32 ` Eli Zaretskii
2023-03-12 17:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 2 replies; 52+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-12 10:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, Manuel Giraud, mardani29
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net, drew.adams@oracle.com
>> Date: Sat, 11 Mar 2023 15:02:44 +0100
>> From: Manuel Giraud via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> This patch was produce on the main branch but FWIW I think it should
>> also go on emacs-29.
>
> I'm okay with installing this on emacs-29, since macOS is supposed to
> be a variant of BSD.
>
> But please don't change the values for any other systems, not on the
> release branch anyway.
>
> Thanks.
IICU filenames with embedded spaces and newlines are not supposed to
work without GNU ls, which implements a `--dired' option just for Emacs.
Admittedly that isn't the best situation, but it is not a regression
from Emacs 28.
Would someone please explain what the problem here is?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
` (2 preceding siblings ...)
2023-03-11 12:00 ` Eli Zaretskii
@ 2023-03-12 10:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
3 siblings, 0 replies; 52+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-12 10:55 UTC (permalink / raw)
To: Daniel Martín; +Cc: 62096, stephen.berman, manuel, drew.adams
Daniel Martín <mardani29@yahoo.es> writes:
> Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs@gnu.org> writes:
>
>> Ok, so commenting the string-replace at dired.el:3529 in
>> 'dired-goto-file-1' (ie. not replacing " " with "\\ ") does the trick
>> for me...
>>
>> That being said those are here for a reason. It might be a difference
>> between OpenBSD's find and the GNU one (I don't know for Windows).
>
> This bug also affects macOS. After reading the code I'd say that, even
> on GNU/Linux, there are probably other corner cases where
> dired-goto-file would fail:
>
> ;; FIXME: to fix this for embedded control characters etc, we
> ;; should escape everything that `ls -b' does.
> (setq str (string-replace " " "\\ " str)
> str (string-replace "\t" "\\t" str)
> str (string-replace "\n" "\\n" str))
>
> For example, on GNU/Linux, ls -b outputs:
>
> vacation\ 2022
>
> while on macOS it outputs:
>
> vacation 2022
`ls --dired -l' outputs a huge swath of numbers and options for Dired
detailing, among other information, the quoting style being used.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-12 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-12 11:32 ` Eli Zaretskii
2023-03-12 11:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 17:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-12 11:32 UTC (permalink / raw)
To: Po Lu; +Cc: 62096, stephen.berman, drew.adams, manuel, mardani29
> From: Po Lu <luangruo@yahoo.com>
> Cc: Manuel Giraud <manuel@ledu-giraud.fr>, 62096@debbugs.gnu.org,
> stephen.berman@gmx.net, drew.adams@oracle.com, mardani29@yahoo.es
> Date: Sun, 12 Mar 2023 18:54:44 +0800
>
> IICU filenames with embedded spaces and newlines are not supposed to
> work without GNU ls, which implements a `--dired' option just for Emacs.
That's not entirely accurate: ls-lisp.el also implements the
functionality for which --dired is required: it puts the special text
property on file names just like we do when we get --dired. So the
related features also work on MS-Windows (and on any other platform if
ls-lisp.el is used).
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-12 11:32 ` Eli Zaretskii
@ 2023-03-12 11:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 52+ messages in thread
From: Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-12 11:56 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, manuel, mardani29
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: Manuel Giraud <manuel@ledu-giraud.fr>, 62096@debbugs.gnu.org,
>> stephen.berman@gmx.net, drew.adams@oracle.com, mardani29@yahoo.es
>> Date: Sun, 12 Mar 2023 18:54:44 +0800
>>
>> IICU filenames with embedded spaces and newlines are not supposed to
>> work without GNU ls, which implements a `--dired' option just for Emacs.
>
> That's not entirely accurate: ls-lisp.el also implements the
> functionality for which --dired is required: it puts the special text
> property on file names just like we do when we get --dired. So the
> related features also work on MS-Windows (and on any other platform if
> ls-lisp.el is used).
Oh, that's quite nice. I didn't know this before, thanks.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-12 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 11:32 ` Eli Zaretskii
@ 2023-03-12 17:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 0 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-12 17:51 UTC (permalink / raw)
To: Po Lu; +Cc: Eli Zaretskii, stephen.berman, 62096, drew.adams, mardani29
Po Lu <luangruo@yahoo.com> writes:
[...]
> Would someone please explain what the problem here is?
Are you talking about the initial problem? If so, here it is:
On some non GNU/Linux system, if you use 'find-dired' to collect some
files 'dired-goto-file' won't work on files whose name contains space.
FWIW, "ls" is not involved here, only "find" and how Emacs should
interpret its output with the "-ls" flag.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-11 14:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 7:49 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 8:33 ` Eli Zaretskii
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-17 7:49 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, mardani29
Hi,
So do you think this could go in emacs-29?
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 7:49 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 8:33 ` Eli Zaretskii
2023-03-17 9:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-17 8:33 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams, mardani29
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: mardani29@yahoo.es, 62096@debbugs.gnu.org, stephen.berman@gmx.net,
> drew.adams@oracle.com
> Date: Fri, 17 Mar 2023 08:49:47 +0100
>
> So do you think this could go in emacs-29?
> --
> Manuel Giraud
If you mean the patch posted here:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62096#89
then it's okay for emacs-29, but please use memq instead of two eq
test against two literals system-type values.
Thanks.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 8:33 ` Eli Zaretskii
@ 2023-03-17 9:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 11:33 ` Eli Zaretskii
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-17 9:12 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, mardani29
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: mardani29@yahoo.es, 62096@debbugs.gnu.org, stephen.berman@gmx.net,
>> drew.adams@oracle.com
>> Date: Fri, 17 Mar 2023 08:49:47 +0100
>>
>> So do you think this could go in emacs-29?
>> --
>> Manuel Giraud
>
> If you mean the patch posted here:
>
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62096#89
Yes, I was talking about this one.
> then it's okay for emacs-29, but please use memq instead of two eq
> test against two literals system-type values.
Here is the new version. I also modified the commit message a bit.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-find-ls-option-default-ls-for-BSD-MacOS-bug-6209.patch --]
[-- Type: text/x-patch, Size: 1014 bytes --]
From d866c95800bec46dedff6c038f5c566ccb14b642 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 10 Mar 2023 21:54:00 +0100
Subject: [PATCH] Fix 'find-ls-option-default-ls' for BSD/MacOS (bug#62096)
* lisp/find-dired.el (find-ls-option-default-ls): Adapt to a value
that works with the default "find" on *BSD and Darwin/MacOS. Tested
on OpenBSD and MacOS.
---
lisp/find-dired.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/find-dired.el b/lisp/find-dired.el
index 33376ee4ed9..af029fb2074 100644
--- a/lisp/find-dired.el
+++ b/lisp/find-dired.el
@@ -51,7 +51,9 @@ find-exec-terminator
:type 'string)
(defvar find-ls-option-default-ls
- (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
+ (cons "-ls" (if (memq system-type '(berkeley-unix darwin))
+ "-dgils"
+ "-dilsb")))
(defvar find-ls-option-default-exec
(cons (format "-exec ls -ld {} %s" find-exec-terminator) "-ld"))
--
2.39.2
[-- Attachment #3: Type: text/plain, Size: 18 bytes --]
--
Manuel Giraud
^ permalink raw reply related [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 9:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 11:33 ` Eli Zaretskii
2023-03-17 15:25 ` Drew Adams
2023-03-17 17:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-17 11:33 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams, mardani29
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: mardani29@yahoo.es, 62096@debbugs.gnu.org, stephen.berman@gmx.net,
> drew.adams@oracle.com
> Date: Fri, 17 Mar 2023 10:12:05 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62096#89
>
> Yes, I was talking about this one.
>
> > then it's okay for emacs-29, but please use memq instead of two eq
> > test against two literals system-type values.
>
> Here is the new version. I also modified the commit message a bit.
LGTM, thanks.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 11:33 ` Eli Zaretskii
@ 2023-03-17 15:25 ` Drew Adams
2023-03-17 15:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:26 ` Eli Zaretskii
2023-03-17 17:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 2 replies; 52+ messages in thread
From: Drew Adams @ 2023-03-17 15:25 UTC (permalink / raw)
To: Eli Zaretskii, Manuel Giraud
Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net, mardani29@yahoo.es
Did this bug actually get fixed for ls-lisp also, e.g. MS Windows? I thought not, but I haven't followed this closely.
If this isn't yet fixed generally, then shouldn't the bug be kept open, perhaps limiting it to ls-lisp or whatever else still needs to be done?
IOW, will closing this bug be appropriate for ls-lisp users? Isn't the bug as reported still a bug, for ls-lisp users?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 15:25 ` Drew Adams
@ 2023-03-17 15:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:14 ` Drew Adams
2023-03-17 16:26 ` Eli Zaretskii
1 sibling, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-17 15:41 UTC (permalink / raw)
To: Drew Adams
Cc: Eli Zaretskii, stephen.berman@gmx.net, 62096@debbugs.gnu.org,
mardani29@yahoo.es
Drew Adams <drew.adams@oracle.com> writes:
> Did this bug actually get fixed for ls-lisp also, e.g. MS Windows? I
> thought not, but I haven't followed this closely.
No I don't think so. The current patch just affects non GNU find.
> If this isn't yet fixed generally, then shouldn't the bug be kept
> open, perhaps limiting it to ls-lisp or whatever else still needs to
> be done?
>
> IOW, will closing this bug be appropriate for ls-lisp users? Isn't the
> bug as reported still a bug, for ls-lisp users?
That makes sense: the current patch does fix on some arch but not all.
AFAIU, I don't think it related to ls-lisp: it is about find.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 15:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 16:14 ` Drew Adams
0 siblings, 0 replies; 52+ messages in thread
From: Drew Adams @ 2023-03-17 16:14 UTC (permalink / raw)
To: Manuel Giraud
Cc: Eli Zaretskii, stephen.berman@gmx.net, 62096@debbugs.gnu.org,
mardani29@yahoo.es
> > IOW, will closing this bug be appropriate for ls-lisp users? Isn't the
> > bug as reported still a bug, for ls-lisp users?
>
> That makes sense: the current patch does fix on some arch but not all.
> AFAIU, I don't think it related to ls-lisp: it is about find.
Maybe the bug as described is fixed for some platforms by fixing a particular `find' command (?). But isn't the bug as described still a bug for users of `ls-lisp'?
That's my question. If it's still a bug, then shouldn't we keep it open?
IOW, let's not confuse a _solution_ for some contexts with the _problem_. Of course, if someone can test the fix with use of `ls-lisp', and if it solves the problem for that context also, then great. I can't do that, so I'm just guessing. Thx.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 15:25 ` Drew Adams
2023-03-17 15:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 16:26 ` Eli Zaretskii
2023-03-17 17:20 ` Drew Adams
1 sibling, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-17 16:26 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096, stephen.berman, manuel, mardani29
> From: Drew Adams <drew.adams@oracle.com>
> CC: "mardani29@yahoo.es" <mardani29@yahoo.es>,
> "62096@debbugs.gnu.org"
> <62096@debbugs.gnu.org>,
> "stephen.berman@gmx.net" <stephen.berman@gmx.net>
> Date: Fri, 17 Mar 2023 15:25:44 +0000
>
> Did this bug actually get fixed for ls-lisp also, e.g. MS Windows? I thought not, but I haven't followed this closely.
There's nothing to fix in ls-lisp. The problem is in find-dired, not
in ls-lisp.
> If this isn't yet fixed generally, then shouldn't the bug be kept open, perhaps limiting it to ls-lisp or whatever else still needs to be done?
>
> IOW, will closing this bug be appropriate for ls-lisp users? Isn't the bug as reported still a bug, for ls-lisp users?
Why do you think this has anything to do with ls-lisp?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 16:26 ` Eli Zaretskii
@ 2023-03-17 17:20 ` Drew Adams
2023-03-17 17:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 18:42 ` Eli Zaretskii
0 siblings, 2 replies; 52+ messages in thread
From: Drew Adams @ 2023-03-17 17:20 UTC (permalink / raw)
To: Eli Zaretskii
Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net,
manuel@ledu-giraud.fr, mardani29@yahoo.es
> > Did this bug actually get fixed for ls-lisp also, e.g. MS Windows? I
> thought not, but I haven't followed this closely.
>
> There's nothing to fix in ls-lisp. The problem is in find-dired, not
> in ls-lisp.
>
> > If this isn't yet fixed generally, then shouldn't the bug be kept open,
> perhaps limiting it to ls-lisp or whatever else still needs to be done?
> >
> > IOW, will closing this bug be appropriate for ls-lisp users? Isn't the
> bug as reported still a bug, for ls-lisp users?
>
> Why do you think this has anything to do with ls-lisp?
Just a guess, based on some statements by Manuel
such as this one:
My final patch is just a modification of
'find-ls-option-default-ls' and AFAIK it
won't do anything on Windows.
And on the patch you've cited being just this,
which seems to only add darwin to the same case
as berkley-unix, having no effect for Windows:
(defvar find-ls-option-default-ls
- (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
+ (cons "-ls" (if (or (eq system-type 'berkeley-unix)
+ (eq system-type 'darwin))
+ "-dgils"
+ "-dilsb")))
But I guess you're confirming that the fix is
for MS Windows (which uses `ls-lisp') also.
I don't see how that can be the case, but if
it is then great. Thx.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 17:20 ` Drew Adams
@ 2023-03-17 17:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 18:56 ` Eli Zaretskii
2023-03-17 18:42 ` Eli Zaretskii
1 sibling, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-17 17:50 UTC (permalink / raw)
To: Drew Adams
Cc: Eli Zaretskii, stephen.berman@gmx.net, 62096@debbugs.gnu.org,
mardani29@yahoo.es
Drew Adams <drew.adams@oracle.com> writes:
[...]
> (defvar find-ls-option-default-ls
> - (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
> + (cons "-ls" (if (or (eq system-type 'berkeley-unix)
> + (eq system-type 'darwin))
> + "-dgils"
> + "-dilsb")))
>
> But I guess you're confirming that the fix is
> for MS Windows (which uses `ls-lisp') also.
> I don't see how that can be the case, but if
> it is then great. Thx.
No I do not think it fixes anything on Windows. But "ls-lisp" is also
not involved. If I understand correctly, 'find-ls-option-default-ls' is
the interpretation - in terms of ls switches - that dired does of a
"find -ls" command.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 11:33 ` Eli Zaretskii
2023-03-17 15:25 ` Drew Adams
@ 2023-03-17 17:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 18:57 ` Eli Zaretskii
1 sibling, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-17 17:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, mardani29
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
[...]
>> Here is the new version. I also modified the commit message a bit.
>
> LGTM, thanks.
Sorry, here is another version. WDYT? Maybe, Drew you could test it to
see if it fixes the bug for you.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-find-ls-option-default-ls-for-BSD-MacOS-bug-6209.patch --]
[-- Type: text/x-patch, Size: 1257 bytes --]
From e1c08afc943358e5afb49478f40722ebbf3cc07f Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Fri, 10 Mar 2023 21:54:00 +0100
Subject: [PATCH] Fix 'find-ls-option-default-ls' for BSD/MacOS (bug#62096)
* lisp/find-dired.el (find-gnu-find-p): New variable to determine
if "find" is a GNU find.
(find-ls-option-default-ls): Use 'find-gnu-find-p' and adapt to a
value that works with the default "find" on *BSD and Darwin/MacOS.
Tested on OpenBSD and MacOS.
---
lisp/find-dired.el | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lisp/find-dired.el b/lisp/find-dired.el
index 33376ee4ed9..264c6e3082f 100644
--- a/lisp/find-dired.el
+++ b/lisp/find-dired.el
@@ -50,8 +50,13 @@ find-exec-terminator
:group 'find-dired
:type 'string)
+(defvar find-gnu-find-p
+ (eq 0 (ignore-errors
+ (process-file find-program nil nil nil null-device "--version")))
+ "T if 'find-program' is a GNU find. NIL otherwise.")
+
(defvar find-ls-option-default-ls
- (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
+ (cons "-ls" (if find-gnu-find-p "-dilsb" "-dgils")))
(defvar find-ls-option-default-exec
(cons (format "-exec ls -ld {} %s" find-exec-terminator) "-ld"))
--
2.39.2
[-- Attachment #3: Type: text/plain, Size: 18 bytes --]
--
Manuel Giraud
^ permalink raw reply related [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 17:20 ` Drew Adams
2023-03-17 17:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 18:42 ` Eli Zaretskii
1 sibling, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-17 18:42 UTC (permalink / raw)
To: Drew Adams; +Cc: 62096, stephen.berman, manuel, mardani29
> From: Drew Adams <drew.adams@oracle.com>
> CC: "manuel@ledu-giraud.fr" <manuel@ledu-giraud.fr>,
> "mardani29@yahoo.es"
> <mardani29@yahoo.es>,
> "62096@debbugs.gnu.org" <62096@debbugs.gnu.org>,
> "stephen.berman@gmx.net" <stephen.berman@gmx.net>
> Date: Fri, 17 Mar 2023 17:20:52 +0000
>
> And on the patch you've cited being just this,
> which seems to only add darwin to the same case
> as berkley-unix, having no effect for Windows:
>
> (defvar find-ls-option-default-ls
> - (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
> + (cons "-ls" (if (or (eq system-type 'berkeley-unix)
> + (eq system-type 'darwin))
> + "-dgils"
> + "-dilsb")))
>
> But I guess you're confirming that the fix is
> for MS Windows (which uses `ls-lisp') also.
> I don't see how that can be the case, but if
> it is then great. Thx.
The patch changes options passed to the 'find' program. It has
nothing to do with ls-lisp, which is not involved in find-dired.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 17:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 18:56 ` Eli Zaretskii
0 siblings, 0 replies; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-17 18:56 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams, mardani29
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: Eli Zaretskii <eliz@gnu.org>, "mardani29@yahoo.es"
> <mardani29@yahoo.es>, "62096@debbugs.gnu.org" <62096@debbugs.gnu.org>,
> "stephen.berman@gmx.net" <stephen.berman@gmx.net>
> Date: Fri, 17 Mar 2023 18:50:41 +0100
>
> Drew Adams <drew.adams@oracle.com> writes:
>
> [...]
>
> > (defvar find-ls-option-default-ls
> > - (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb")))
> > + (cons "-ls" (if (or (eq system-type 'berkeley-unix)
> > + (eq system-type 'darwin))
> > + "-dgils"
> > + "-dilsb")))
> >
> > But I guess you're confirming that the fix is
> > for MS Windows (which uses `ls-lisp') also.
> > I don't see how that can be the case, but if
> > it is then great. Thx.
>
> No I do not think it fixes anything on Windows.
There's nothing to fix on MS-Windows, since the only version of 'find'
that can be available on MS-Windows is GNU Find.
> But "ls-lisp" is also not involved. If I understand correctly,
> 'find-ls-option-default-ls' is the interpretation - in terms of ls
> switches - that dired does of a "find -ls" command.
Exactly.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 17:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-17 18:57 ` Eli Zaretskii
2023-03-17 19:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-17 18:57 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams, mardani29
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: mardani29@yahoo.es, 62096@debbugs.gnu.org, stephen.berman@gmx.net,
> drew.adams@oracle.com
> Date: Fri, 17 Mar 2023 18:54:51 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> [...]
>
> >> Here is the new version. I also modified the commit message a bit.
> >
> > LGTM, thanks.
>
> Sorry, here is another version.
Why am I not surprised?
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 18:57 ` Eli Zaretskii
@ 2023-03-17 19:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 6:34 ` Eli Zaretskii
0 siblings, 1 reply; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-17 19:10 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, mardani29
Eli Zaretskii <eliz@gnu.org> writes:
[...]
>> Sorry, here is another version.
>
> Why am I not surprised?
😅 we can stop at the previous one. This last test whether
'find-program' is a GNU find instead of relying on 'system-type'.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-17 19:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-03-18 6:34 ` Eli Zaretskii
2023-03-18 10:16 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 52+ messages in thread
From: Eli Zaretskii @ 2023-03-18 6:34 UTC (permalink / raw)
To: Manuel Giraud; +Cc: 62096, stephen.berman, drew.adams, mardani29
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: mardani29@yahoo.es, 62096@debbugs.gnu.org, stephen.berman@gmx.net,
> drew.adams@oracle.com
> Date: Fri, 17 Mar 2023 20:10:30 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> [...]
>
> >> Sorry, here is another version.
> >
> > Why am I not surprised?
>
> 😅 we can stop at the previous one. This last test whether
> 'find-program' is a GNU find instead of relying on 'system-type'.
I installed the former one on the release branch and the latter on
master.
Please note that we don't use upper-case T and NIL in our
documentation; I fixed this when installing the patch.
^ permalink raw reply [flat|nested] 52+ messages in thread
* bug#62096: 30.0.50; find-dired, dired-goto-file and spaces
2023-03-18 6:34 ` Eli Zaretskii
@ 2023-03-18 10:16 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 52+ messages in thread
From: Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-03-18 10:16 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 62096, stephen.berman, drew.adams, mardani29
Eli Zaretskii <eliz@gnu.org> writes:
[...]
> I installed the former one on the release branch and the latter on
> master.
Make sense. Thank you.
> Please note that we don't use upper-case T and NIL in our
> documentation; I fixed this when installing the patch.
Ok.
--
Manuel Giraud
^ permalink raw reply [flat|nested] 52+ messages in thread
end of thread, other threads:[~2023-03-18 10:16 UTC | newest]
Thread overview: 52+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-10 14:54 bug#62096: 30.0.50; find-dired, dired-goto-file and spaces Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 15:43 ` Drew Adams
2023-03-10 15:59 ` Stephen Berman
2023-03-10 17:10 ` Drew Adams
2023-03-10 18:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 18:37 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 20:48 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 0:14 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 14:17 ` Eli Zaretskii
2023-03-11 14:27 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 7:49 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 8:33 ` Eli Zaretskii
2023-03-17 9:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 11:33 ` Eli Zaretskii
2023-03-17 15:25 ` Drew Adams
2023-03-17 15:41 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 16:14 ` Drew Adams
2023-03-17 16:26 ` Eli Zaretskii
2023-03-17 17:20 ` Drew Adams
2023-03-17 17:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 18:56 ` Eli Zaretskii
2023-03-17 18:42 ` Eli Zaretskii
2023-03-17 17:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-17 18:57 ` Eli Zaretskii
2023-03-17 19:10 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-18 6:34 ` Eli Zaretskii
2023-03-18 10:16 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 11:32 ` Eli Zaretskii
2023-03-12 11:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-12 17:51 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 17:09 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 18:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 19:30 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:31 ` Drew Adams
2023-03-10 21:43 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 12:00 ` Eli Zaretskii
2023-03-12 10:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-11 11:55 ` Eli Zaretskii
2023-03-11 14:12 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:05 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 19:55 ` Drew Adams
2023-03-10 20:42 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:24 ` Drew Adams
2023-03-10 21:32 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 21:45 ` Drew Adams
2023-03-10 22:03 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-10 22:20 ` Drew Adams
2023-03-11 11:58 ` Eli Zaretskii
2023-03-10 19:48 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).