From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62096: 30.0.50; find-dired, dired-goto-file and spaces Date: Fri, 17 Mar 2023 18:54:51 +0100 Message-ID: <87bkkrntzo.fsf@ledu-giraud.fr> References: <87edpw1wt3.fsf@ledu-giraud.fr> <877cvofvgg.fsf@gmx.net> <87a60k1nus.fsf@ledu-giraud.fr> <875yb81mh3.fsf@ledu-giraud.fr> <87y1o471z3.fsf@ledu-giraud.fr> <87fsab75dn.fsf@ledu-giraud.fr> <837cvnwewl.fsf@gnu.org> <877cvn748c.fsf@ledu-giraud.fr> <87sfe36cmc.fsf@ledu-giraud.fr> <83r0tneq0y.fsf@gnu.org> <87bkkr68t6.fsf@ledu-giraud.fr> <83o7orehnj.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62096@debbugs.gnu.org, stephen.berman@gmx.net, drew.adams@oracle.com, mardani29@yahoo.es To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 17 18:55:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdEIL-0007Gx-FE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Mar 2023 18:55:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdEIC-0000W3-SM; Fri, 17 Mar 2023 13:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdEIA-0000OO-WD for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 13:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdEIA-0002nq-Kg for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 13:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdEIA-0001oF-Dr for bug-gnu-emacs@gnu.org; Fri, 17 Mar 2023 13:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2023 17:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62096 X-GNU-PR-Package: emacs Original-Received: via spool by 62096-submit@debbugs.gnu.org id=B62096.16790756976941 (code B ref 62096); Fri, 17 Mar 2023 17:55:02 +0000 Original-Received: (at 62096) by debbugs.gnu.org; 17 Mar 2023 17:54:57 +0000 Original-Received: from localhost ([127.0.0.1]:45587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdEI4-0001nt-PF for submit@debbugs.gnu.org; Fri, 17 Mar 2023 13:54:57 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:26901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdEI2-0001nj-Kp for 62096@debbugs.gnu.org; Fri, 17 Mar 2023 13:54:55 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=4InevDcB PxMSowxv9VUTeOmzdC6F/kSu+P0KHXeWPz8=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=LO463KWlu6+9x2Mxo+qy76LhUxZnmd gQAynRmyFkgp9okyB9tSw0mHC57nrCnROV3SMAi9kYNDtv4yG9QAwhDw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=4InevDcBPxMSowxv 9VUTeOmzdC6F/kSu+P0KHXeWPz8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=PJeP810jyUJ7x2hBzzJ1tApRT4osXaOA0QEKrJ xR7AbX/KWaLPw9MaJdW0CnQSESxFrM80ekb6n+O/S/F8iVfDLMRUNK4BP3VogOYn7gvd71 EOx+ot/KnTNhE9SVHCI7KVKhSNs0C4ragGwMfAUZR/SqlZex6rabeXox7oakKS31DPUWda k46bQs51ZhuccLKuTCcxCp6UGx4UxRP/2/WB2IBek8+zIMc3rvk09JfCJq63KqIB5rywL4 btY55xKnrnhLG4+xFxtXmWYSAjYMQEy4yl+t5RSXCt64VNccI0mgb6FQUSknwHraSnSIb7 MEijmx/uMTCkxlRPAQ8xJyew== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id ae9631b5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 17 Mar 2023 18:54:53 +0100 (CET) In-Reply-To: <83o7orehnj.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Mar 2023 13:33:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258102 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] >> Here is the new version. I also modified the commit message a bit. > > LGTM, thanks. Sorry, here is another version. WDYT? Maybe, Drew you could test it to see if it fixes the bug for you. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-find-ls-option-default-ls-for-BSD-MacOS-bug-6209.patch >From e1c08afc943358e5afb49478f40722ebbf3cc07f Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 10 Mar 2023 21:54:00 +0100 Subject: [PATCH] Fix 'find-ls-option-default-ls' for BSD/MacOS (bug#62096) * lisp/find-dired.el (find-gnu-find-p): New variable to determine if "find" is a GNU find. (find-ls-option-default-ls): Use 'find-gnu-find-p' and adapt to a value that works with the default "find" on *BSD and Darwin/MacOS. Tested on OpenBSD and MacOS. --- lisp/find-dired.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/find-dired.el b/lisp/find-dired.el index 33376ee4ed9..264c6e3082f 100644 --- a/lisp/find-dired.el +++ b/lisp/find-dired.el @@ -50,8 +50,13 @@ find-exec-terminator :group 'find-dired :type 'string) +(defvar find-gnu-find-p + (eq 0 (ignore-errors + (process-file find-program nil nil nil null-device "--version"))) + "T if 'find-program' is a GNU find. NIL otherwise.") + (defvar find-ls-option-default-ls - (cons "-ls" (if (eq system-type 'berkeley-unix) "-gilsb" "-dilsb"))) + (cons "-ls" (if find-gnu-find-p "-dilsb" "-dgils"))) (defvar find-ls-option-default-exec (cons (format "-exec ls -ld {} %s" find-exec-terminator) "-ld")) -- 2.39.2 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=--