From: Drew Adams <drew.adams@oracle.com>
To: "H. Dieter Wilhelm" <dieter@duenenhof-wilhelm.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
"60587@debbugs.gnu.org" <60587@debbugs.gnu.org>,
"monnier@iro.umontreal.ca" <monnier@iro.umontreal.ca>
Subject: bug#60587: Patch for adding links to symbols' help documentation
Date: Thu, 2 Feb 2023 02:30:26 +0000 [thread overview]
Message-ID: <SJ0PR10MB5488701049C3D60D870FC72EF3D69@SJ0PR10MB5488.namprd10.prod.outlook.com> (raw)
In-Reply-To: <86tu05ujf1.fsf@duenenhof-wilhelm.de>
> Drew Adams <drew.adams@oracle.com> writes:
>
> >> > 1.
> >> > + :type '(choice (const :tag "Create links" t)
> >> > + (const :tag "Do not link" nil))
> >> >
> >> > is better as just :type 'boolean, and say in the
> >> > doc which Boolean value means which behavior.
> >>
> >> The doc string says now:
> >>
> >> "True (`t') means Emacs creates symbol link buttons in Info.
> >> Setting this variable to `nil' inhibits the creation of buttons
> >> on quoted symbols to their help strings. Please see the function
> >> `info-make-xrefs' for further details."
> >
> > Is the defcustom now :type 'boolean?
>
> Please tell me why you insist now on changing the :type from choice to
> boolean? Above you stated that it "is better than just :type boolean"!?
Misunderstanding.
1. I don't insist on anything.
2. I didn't say "is better than"; I said "is better as".
For #2: Sorry, I should have been less succinct.
I meant that (I think) that a `choice' such as what
you presented is simpler _as_ a `boolean' instead.
IOW, a boolean def is simpler. I should have said
it that way.
> I experimented in `customize' with :type 'boolean and the "toggle"
> button is fast and easy. On the other hand with 'choice I think the
> alternatives are clearer documented while changing it's values..
Yes, with `boolean' you can't specify a :tag.
But usually the doc string (which is also shown
in Customize) makes clear what each value does/means.
It was a minor comment. There's nothing wrong with
using `choice' as you did. Sorry for the noise.
> >> > 4. Or instead of having an option, maybe just have
> >> > a minor mode.
> >>
> >> That's also a nice idea. (Maybe for later.)
> >
> > See Stefan's reply...
>
> Alright, I'm going in this direction but I'm not so fast. 😅
There's no hurry.
> >> > 6. "clicking @kbd{mouse-2} or @kbd{mouse-1} on it"
> >> > can't be right, I think. At least that doesn't
> >> > express what `mouse-1-follows-link' does/means.
>
> On the suggestion of Eli, I just stated `mouse' and added a cross
> reference, ahem, link to the mouse manual section.
>
> Thanks for your interest
Thanks for working on this.
____
FWIW, I disagree with Eli here. I think saying
which mouse button to use is better than just
saying click the mouse. And which button to
click is taken care of automatically, if you use
\\[mouse-2], as you pointed out.
____
FWIW2: If `mouse-1-click-follows-link' is nil
then you can click `mouse-1' on a link to set
point there. That's the advantage of that choice
(and it was what Emacs used to do by default).
If the value is non-nil then a user can click
mouse-1 to follow links, which is an advantage
in being what users are used to in browsers.
(With a non-nil value you have to press and hold
mouse-1 for a bit, to set point there.)
Since `mouse-2' is for yanking normally, and
since contexts where there are links typically
don't also allow yanking, the classic Emacs
approach was (still is) a smart one.
And in an editor I, at least, more often want
to use the mouse to set point, even on links -
more often than I want to yank with the mouse
in contexts that have links. I prefer the old
default behavior, and I think Emacs should have
stuck with it.
next prev parent reply other threads:[~2023-02-02 2:30 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 23:47 bug#60587: 30.0.50; Info pages are lacking links from symbol names to the symbol's help documentation H. Dieter Wilhelm
2023-01-06 19:03 ` bug#60587: Patch for adding links to symbols' " H. Dieter Wilhelm
2023-01-07 7:38 ` Eli Zaretskii
2023-01-08 20:06 ` H. Dieter Wilhelm
2023-01-09 12:46 ` Eli Zaretskii
2023-01-09 14:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-09 20:01 ` H. Dieter Wilhelm
2023-01-13 23:33 ` H. Dieter Wilhelm
2023-01-14 7:12 ` Eli Zaretskii
2023-01-15 12:48 ` H. Dieter Wilhelm
2023-01-17 21:53 ` H. Dieter Wilhelm
2023-01-18 13:20 ` Eli Zaretskii
2023-01-20 21:09 ` H. Dieter Wilhelm
2023-01-20 21:59 ` Drew Adams
2023-01-20 23:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-22 13:00 ` H. Dieter Wilhelm
2023-01-21 8:21 ` Eli Zaretskii
2023-01-21 20:27 ` H. Dieter Wilhelm
2023-01-22 6:00 ` Eli Zaretskii
2023-01-22 22:09 ` Drew Adams
2023-01-23 12:14 ` Eli Zaretskii
2023-01-23 16:16 ` Drew Adams
2023-01-25 21:29 ` H. Dieter Wilhelm
2023-01-25 22:24 ` Drew Adams
2023-01-26 10:29 ` Ihor Radchenko
2023-01-26 15:06 ` Drew Adams
2023-01-26 15:12 ` Ihor Radchenko
2023-01-26 15:23 ` Drew Adams
2023-01-27 21:35 ` H. Dieter Wilhelm
2023-01-27 22:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-27 23:09 ` Drew Adams
2023-01-27 23:13 ` Drew Adams
2023-01-28 8:11 ` Eli Zaretskii
2023-01-28 17:30 ` Drew Adams
2023-02-01 22:09 ` H. Dieter Wilhelm
2023-02-02 2:30 ` Drew Adams [this message]
2023-02-05 0:48 ` H. Dieter Wilhelm
2023-02-05 3:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-05 13:54 ` H. Dieter Wilhelm
2023-02-06 21:04 ` H. Dieter Wilhelm
2023-02-12 11:04 ` H. Dieter Wilhelm
2023-02-14 20:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 22:18 ` H. Dieter Wilhelm
2023-02-16 3:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 23:53 ` H. Dieter Wilhelm
2023-02-21 2:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-01 21:45 ` H. Dieter Wilhelm
2023-03-11 8:32 ` Eli Zaretskii
2023-03-11 9:16 ` H. Dieter Wilhelm
2023-02-15 5:17 ` Richard Stallman
2023-02-15 9:53 ` Gregory Heytings
2023-02-15 13:42 ` Gregory Heytings
2023-01-26 10:37 ` Eli Zaretskii
2023-01-27 7:45 ` Juri Linkov
2023-01-27 8:11 ` Eli Zaretskii
2023-01-27 22:21 ` H. Dieter Wilhelm
2023-01-28 7:51 ` Eli Zaretskii
2023-02-01 21:26 ` H. Dieter Wilhelm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR10MB5488701049C3D60D870FC72EF3D69@SJ0PR10MB5488.namprd10.prod.outlook.com \
--to=drew.adams@oracle.com \
--cc=60587@debbugs.gnu.org \
--cc=dieter@duenenhof-wilhelm.de \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).