From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 50738-done@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#50738: `ert-deftest` bodies should not use lexical-binding=nil
Date: Sat, 25 Sep 2021 20:33:49 +0200 [thread overview]
Message-ID: <F3184B9D-A845-4BA4-A7AF-9212C2F2E228@acm.org> (raw)
In-Reply-To: <83zgs3vo0o.fsf@gnu.org>
23 sep. 2021 kl. 07.50 skrev Eli Zaretskii <eliz@gnu.org>:
> I think it's dangerous to do this in Emacs 28. After all, the
> original issue is with ERT, whereas the change will affect gobs of
> code. After the emacs-28 branch is cut, if you feel adventurous, ...
I agree, let's stick to fixing ERT now. Now done: in the most conservative way, using the ambient value of lexical-binding.
prev parent reply other threads:[~2021-09-25 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 11:13 bug#50738: `ert-deftest` bodies should not use lexical-binding=nil Mattias Engdegård
2021-09-22 14:26 ` Mattias Engdegård
2021-09-22 20:33 ` Lars Ingebrigtsen
2021-09-23 5:50 ` Eli Zaretskii
2021-09-25 18:33 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3184B9D-A845-4BA4-A7AF-9212C2F2E228@acm.org \
--to=mattiase@acm.org \
--cc=50738-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).