From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50738: `ert-deftest` bodies should not use lexical-binding=nil Date: Sat, 25 Sep 2021 20:33:49 +0200 Message-ID: References: <8620C815-C0FC-4C81-A1A0-1F0AFBD603AD@acm.org> <87ee9gtknn.fsf@gnus.org> <83zgs3vo0o.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12510"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50738-done@debbugs.gnu.org, Lars Ingebrigtsen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 20:34:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mUCVM-0002zy-Uy for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 20:34:33 +0200 Original-Received: from localhost ([::1]:52806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUCVK-0005Nj-UB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 14:34:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUCUt-0005Mi-Hh for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 14:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mUCUt-0008Uc-AN for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 14:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mUCUt-0002bN-7I for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 14:34:03 -0400 Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 18:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50738 X-GNU-PR-Package: emacs Mail-Followup-To: 50738@debbugs.gnu.org, mattiase@acm.org, mattiase@acm.org Original-Received: via spool by 50738-done@debbugs.gnu.org id=D50738.16325948429991 (code D ref 50738); Sat, 25 Sep 2021 18:34:03 +0000 Original-Received: (at 50738-done) by debbugs.gnu.org; 25 Sep 2021 18:34:02 +0000 Original-Received: from localhost ([127.0.0.1]:34709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUCUr-0002az-VM for submit@debbugs.gnu.org; Sat, 25 Sep 2021 14:34:02 -0400 Original-Received: from mail1440c50.megamailservers.eu ([91.136.14.40]:59232 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUCUp-0002ae-EB for 50738-done@debbugs.gnu.org; Sat, 25 Sep 2021 14:34:00 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1632594833; bh=OLd0HEMNGE8DOUtWOfs4b5CVyX7Q+nMjtGhau92ECfg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=jNiJz5Tm43lkIUfTB/Pdy3CAJ10FGLHAIsPpZHcu/m3ZpOsVz/Gr3LpN2il0L/nIx J3xF3RNevGNj0bBuuJ2FilOn54RjwNszmkZ0cU6HdF9xiU0npearTAXmsFp/z2L4c5 VBR2/agN6Ac/TjxsHaL5X3F6HwemXqJbZrwXagLE= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18PIXo1A007371; Sat, 25 Sep 2021 18:33:52 +0000 In-Reply-To: <83zgs3vo0o.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F21.614F6B90.0052, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=HoQVp2fS c=1 sm=1 tr=0 ts=614f6b91 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=5wx2o1iPK49L2bADWK0A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215498 Archived-At: 23 sep. 2021 kl. 07.50 skrev Eli Zaretskii : > I think it's dangerous to do this in Emacs 28. After all, the > original issue is with ERT, whereas the change will affect gobs of > code. After the emacs-28 branch is cut, if you feel adventurous, ... I agree, let's stick to fixing ERT now. Now done: in the most = conservative way, using the ambient value of lexical-binding.